On Mon, Dec 16, 2013 at 05:13:59PM +, Alin Serdean wrote:
> I can put in the ernno for the error but the problem is CryptGenRandom
> does not set the error number.
OK.
> So it is either just print the value of GetLastError() or I use
> FormatMessage function to get the text from that value. L
On Dec 16, 2013, at 10:38 PM, Ben Pfaff wrote:
> At that point I'll probably find myself looking up my concerns from this
> thread, though, to see it any of them have been resolved, since there
> was never any discussion.
I’ll get to your points before reposting.
Jarno
_
On Dec 16, 2013, at 10:36 PM, Jarno Rajahalme wrote:
> Ben,
>
> I have this series on a branch after these:
>
> http://patchwork.openvswitch.org/patch/2157/
> http://patchwork.openvswitch.org/patch/2158/
>
> Applying the first needs some manual work due to a typo fix in a comment I
> made on
On Mon, Dec 16, 2013 at 10:36:00PM -0800, Jarno Rajahalme wrote:
> Ben,
>
> I have this series on a branch after these:
>
> http://patchwork.openvswitch.org/patch/2157/
> http://patchwork.openvswitch.org/patch/2158/
>
> Applying the first needs some manual work due to a typo fix in a comment I
On Mon, Dec 16, 2013 at 10:26:15PM -0800, Harold Lim wrote:
> ... that has already defined the NOT_REACHED macro
>
> Add an #ifndef guard around NOT_REACHED macro.
How do we know that they are compatible? I don't think that this is a
good idea.
I'd be happy to rename NOT_REACHED to OVS_NOT_REAC
On Mon, Dec 16, 2013 at 10:26:13PM -0800, Harold Lim wrote:
> The input variable of ovs_scan is changed from 'template' to
> 'format'. template is a keyword in C++.
Can you rebase against current master (there's a small change in util.h
that throws off the patch), and add a Signed-off-by-line? Th
Ben,
I have this series on a branch after these:
http://patchwork.openvswitch.org/patch/2157/
http://patchwork.openvswitch.org/patch/2158/
Applying the first needs some manual work due to a typo fix in a comment I made
on the 1/3 of this series you acked earlier.
After these two are in, I’ll s
On Mon, Dec 16, 2013 at 10:26:14PM -0800, Harold Lim wrote:
> libopenvswitch.a is compiled with a -fPIC flag.
Why?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Nov 15, 2013 at 03:12:20PM -0800, Jarno Rajahalme wrote:
> This helps reduce confusion about when a flow is a flow and when it is
> just metadata.
>
> Signed-off-by: Jarno Rajahalme
I looked at my review comments and your responses, and they seem
reasonable. I didn't look at this patch,
... that has already defined the NOT_REACHED macro
Add an #ifndef guard around NOT_REACHED macro.
---
lib/util.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/util.h b/lib/util.h
index 462247b..1680cd6 100644
--- a/lib/util.h
+++ b/lib/util.h
@@ -150,7 +150,9 @@ is_pow2(uintmax_t x
The input variable of ovs_scan is changed from 'template' to
'format'. template is a keyword in C++.
---
lib/util.c |8
lib/util.h |2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/util.c b/lib/util.c
index 13d41a7..e12a488 100644
--- a/lib/util.c
+++ b/lib
libopenvswitch.a is compiled with a -fPIC flag.
---
lib/automake.mk |4
1 file changed, 4 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index fadc4be..c25b4dc 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -231,6 +231,10 @@ lib_libopenvswitch_a_SOURCES = \
l
On Fri, Nov 15, 2013 at 03:12:19PM -0800, Jarno Rajahalme wrote:
> Use one callback instead of many, helps in adding new functionality
> later on.
>
> Signed-off-by: Jarno Rajahalme
I see in the last round of reviews I only asked for an extra comment. I
see that you added one, so:
Acked-by: Be
Thanks! Applied.
On Mon, Dec 16, 2013 at 09:39:05AM -0800, Alex Wang wrote:
> Looks good to me,
>
>
> On Mon, Dec 16, 2013 at 9:24 AM, Ben Pfaff wrote:
>
> > This could use a review (should be easy).
> >
> > On Thu, Nov 21, 2013 at 03:03:43PM -0800, Ben Pfaff wrote:
> > > Signed-off-by: Ben P
Thanks! Applied.
On Mon, Dec 16, 2013 at 09:37:15AM -0800, Andy Zhou wrote:
> Looks good.
> Acked-by: Andy Zhou
>
>
> On Mon, Dec 16, 2013 at 9:28 AM, Ben Pfaff wrote:
>
> > This needs a review.
> >
> > On Mon, Nov 25, 2013 at 11:34:44AM -0800, Ben Pfaff wrote:
> > > Signed-off-by: Ben Pfaff
On Mon, Nov 25, 2013 at 08:19:50AM -0800, Bruce Davie wrote:
> Add two new tables to the VTEP schema in support of distributed L3.
> Each table contains MAC addresses to be used by VTEPs (both hardware
> and software) when issuing ARP requests on behalf of a logical router.
>
> Signed-off-by: Bruc
On Sun, Dec 15, 2013 at 05:57:57PM -0800, Ethan Jackson wrote:
> This patch moves flow installation and eviction from ofproto-dpif and
> the main thread, into ofproto-dpif-upcall. This performs
> significantly better (approximately 2x TCP_CRR improvement), and
> allows ovs-vswitchd to maintain sig
I think that this should be three patches, since it does three things
that don't seem related to me.
On Mon, Dec 16, 2013 at 06:57:40PM -0800, Harold Lim wrote:
> 1. libopenvswitch is updated to be compiled with -fPIC.
Why? C++ doesn't require -fPIC as far as I know.
> 2. The input variable of
On Mon, Dec 16, 2013 at 6:02 PM, Alin Serdean
wrote:
> I added also syslog.h as you suggested(this will help us in the future
> patches).
>
> Regarding the warnings I will send a detailed list iwth their corespondence
> in another mail and we can discuss further if we want to add them or not.
>
1. libopenvswitch is updated to be compiled with -fPIC.
2. The input variable of ovs_scan is changed from 'template' to
'format'. template is a keyword in C++.
3. Add an #ifndef guard around NOT_REACHED.
---
lib/automake.mk |4
lib/util.c |8
lib/util.h |4 ++
I added also syslog.h as you suggested(this will help us in the future patches).
Regarding the warnings I will send a detailed list iwth their corespondence in
another mail and we can discuss further if we want to add them or not.
I hope everything is in order now :).
Signed-off-by: Alin Serdea
- Original Message -
> From: "Harold Lim"
> To: dev@openvswitch.org
> Cc: "Harold Lim"
> Sent: Monday, December 16, 2013 4:53:34 PM
> Subject: [ovs-dev] [PATCH] Update openvswitch to allow linking from C++
> projects
>
> 1. libopenvswitch is updated to be compiled with -fPIC.
> 2.
On Sat, Nov 30, 2013 at 4:25 AM, Thomas Graf wrote:
> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
> index 6c482d0..2d8a1aa 100644
> --- a/lib/dpif-linux.c
> +++ b/lib/dpif-linux.c
> @@ -73,6 +73,7 @@ struct dpif_linux_dp {
> /* Attributes. */
> const char *name; /*
On Fri, Dec 13, 2013 at 6:22 AM, Thomas Graf wrote:
> Series implementing a zerocopy method for OVS upcall messages. Based
> on top of commit: (''openvswitch: Enable memory mapped Netlink i/o'')
Series applied, thanks.
___
dev mailing list
dev@openvswit
1. libopenvswitch is updated to be compiled with -fPIC.
2. The input variable of ovs_scan is changed from 'template' to
'format'. template is a keyword in C++.
3. Add an #ifndef guard around NOT_REACHED.
---
lib/automake.mk |2 ++
lib/util.c |8
lib/util.h |4 +++-
On Mon, Dec 16, 2013 at 09:01:37AM -0800, Ben Pfaff wrote:
> On Mon, Dec 16, 2013 at 06:42:23PM +0900, Simon Horman wrote:
> > On Mon, Dec 16, 2013 at 02:55:39PM +0900, Simon Horman wrote:
> > > Hi Ben,
> > >
> > > On Fri, Dec 13, 2013 at 12:28:21AM -0800, Ben Pfaff wrote:
> > > > I've been a litt
On Mon, Dec 16, 2013 at 08:56:30AM -0800, Ben Pfaff wrote:
> On Mon, Dec 16, 2013 at 02:55:39PM +0900, Simon Horman wrote:
> > On Fri, Dec 13, 2013 at 12:28:21AM -0800, Ben Pfaff wrote:
> > > I've been a little frustrated with the current approach to MPLS, because
> > > it
> > > seems quite diffic
Augmented as suggested and pushed to master, thanks for the review!
Jarno
On Dec 16, 2013, at 9:47 AM, Ben Pfaff wrote:
> On Tue, Dec 03, 2013 at 03:04:31PM -0800, Jarno Rajahalme wrote:
>> Propagate error response from parse_ofp_exact_flow() to the caller and
>> properly free() it afterward.
On Fri, Dec 13, 2013 at 10:25 AM, Pravin B Shelar wrote:
> In case of flow-miss kernel sends skb to userspace and then
> userspace sends execute netlink msg to switch the packet. But
> in this process skb rxhash is not restored. skb rxhash is used
> for calculating tunnel source port for vxlan. I
On Sun, Dec 15, 2013 at 8:25 PM, Aleksi Suhonen
wrote:
> Package: openvswitch
> Version: 1.9.3+git20131029-1.1
> Severity: important
>
> Dear Maintainer,
>
> I was upgrading our test server to the newest kernel shipping with
> Debian/unstable,
> namely "3.11-2", and DKMS failed on openvswitch-da
On Sun, Dec 15, 2013 at 05:57:56PM -0800, Ethan Jackson wrote:
> From: Joe Stringer
>
> Previously we used facets for ovs-appctl dpif/dump-flows commands.
> This switches to fetching flows directly from the dpif. This is
> necessary because future patches remove facets and subfacet entirely.
>
This is apparently used by CentOS 6.5.
Reported-by: Phil Daws
Signed-off-by: Jesse Gross
---
acinclude.m4| 2 ++
datapath/linux/compat/include/linux/netdevice.h | 13 +++--
datapath/linux/compat/netdevice.c | 13 -
3 files c
On Mon, Dec 16, 2013 at 11:39 AM, Eitan Eliahu wrote:
>
> Could we use #pragma warning(push) and pop to reduce the scope of the warning
> suppression.
Yeah. That is probably something we can use in cases where we cannot
fix the warnings nicely.
> Thanks,
> Eitan
>
> - Original Message -
Could we use #pragma warning(push) and pop to reduce the scope of the warning
suppression.
Thanks,
Eitan
- Original Message -
From: "Gurucharan Shetty"
To: "Alin Serdean"
Cc: dev@openvswitch.org
Sent: Monday, December 16, 2013 11:18:28 AM
Subject: Re: [ovs-dev] [PATCH] V2 windefs: comm
On Mon, Dec 16, 2013 at 10:18 AM, Alin Serdean
wrote:
>>> +//Disable warnings and runtime checks
>>> +#pragma warning( disable : 4116 4090 4700 4005 4133 4028 4098 4293 4715
>>> 4047)
>>> +#pragma runtime_checks( "", off )
>>> +#pragma warning( disable : 4996 ) //deprecated functions
>>> +#pragma
On Sun, Dec 15, 2013 at 10:06 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, applied.
On Mon, Dec 16, 2013 at 11:56:48AM -0600, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Mon, Dec 16, 2013 at 11:31 AM, Ben Pfaff wrote:
> > Ethan, will you review this? It fixes a crash.
> >
> > On Mon, Nov 25, 2013 at 02:14:33PM -0800, Ben Pfaff wrote:
> >> If one
>> +//Disable warnings and runtime checks
>> +#pragma warning( disable : 4116 4090 4700 4005 4133 4028 4098 4293 4715
>> 4047)
>> +#pragma runtime_checks( "", off )
>> +#pragma warning( disable : 4996 ) //deprecated functions
>> +#pragma warning( disable : 4244 ) //possible loss of data
>> +#pragm
Looks good to me, thx,
On Mon, Dec 16, 2013 at 10:08 AM, Joe Stringer wrote:
> This patch adds tests for the cfm fault_override feature which can be
> set through "ovs-appctl cfm/set-fault ". It brings up two
> ports with CFM, sets a fault, then checks that the fault status has
> propagated cor
This patch adds tests for the cfm fault_override feature which can be
set through "ovs-appctl cfm/set-fault ". It brings up two
ports with CFM, sets a fault, then checks that the fault status has
propagated correctly to the CFM module and the database. Finally, it
sets the fault override behaviour
OK, thanks for the review. I'll send a new version.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Acked-by: Ethan Jackson
On Mon, Dec 16, 2013 at 11:31 AM, Ben Pfaff wrote:
> Ethan, will you review this? It fixes a crash.
>
> On Mon, Nov 25, 2013 at 02:14:33PM -0800, Ben Pfaff wrote:
>> If one configured a controller which does not exist, waited for the switch
>> to enter fail-open mode, a
On Tue, Dec 03, 2013 at 03:04:31PM -0800, Jarno Rajahalme wrote:
> Propagate error response from parse_ofp_exact_flow() to the caller and
> properly free() it afterward.
>
> Signed-off-by: Jarno Rajahalme
I have a habit of marking functions that return a string that must be
freed as WARN_UNUSED_
Looks good to me,
On Mon, Dec 16, 2013 at 9:24 AM, Ben Pfaff wrote:
> This could use a review (should be easy).
>
> On Thu, Nov 21, 2013 at 03:03:43PM -0800, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/rconn.c | 12 +++-
> > 1 file changed, 11 insertions(+), 1 dele
Looks good.
Acked-by: Andy Zhou
On Mon, Dec 16, 2013 at 9:28 AM, Ben Pfaff wrote:
> This needs a review.
>
> On Mon, Nov 25, 2013 at 11:34:44AM -0800, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > FAQ | 44
> > 1 file changed, 44 ins
With ovs multithreading implementation, the bfd decay test
becomes fragile due to its high dependency on timing sequence.
This commit removes these dependencies and makes the test robust.
Signed-off-by: Alex Wang
---
v1 -> v2:
- rebase master.
---
tests/bfd.at | 143 +-
Ethan, will you review this? It fixes a crash.
On Mon, Nov 25, 2013 at 02:14:33PM -0800, Ben Pfaff wrote:
> If one configured a controller which does not exist, waited for the switch
> to enter fail-open mode, and then deleted the controller, then
> ofproto_set_controllers() would take ofproto_mu
On Dec 16, 2013, at 9:28 AM, Ben Pfaff wrote:
> On Mon, Nov 25, 2013 at 08:19:50AM -0800, Bruce Davie wrote:
>> Add two new tables to the VTEP schema in support of distributed L3.
>> Each table contains MAC addresses to be used by VTEPs (both hardware
>> and software) when issuing ARP requests
On Mon, Dec 16, 2013 at 9:25 AM, Ben Pfaff wrote:
> This needs a review.
>
> On Thu, Nov 21, 2013 at 05:03:13PM -0800, Ben Pfaff wrote:
>> Signed-off-by: Ben Pfaff
Looks good.
>> ---
>> FAQ | 13 +
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/FAQ b/FAQ
>> index 2912ae3..a
With ovs multithreading implementation, the bfd decay test
becomes fragile due to its high dependency on timing sequence.
This commit removes these dependencies and makes the test robust.
Signed-off-by: Alex Wang
---
v1 -> v2:
- rebase master.
---
tests/bfd.at | 143 +-
Commit 307464a1 (ofproto-dpif-monitor: Use heap to order the mport
wakeup time.) re-heapifies the heap in monitor_run(). So
monitor_run() should be protected by the write lock, rather than
the read lock.
This commit fixes the issue.
Signed-off-by: Alex Wang
---
v1 -> v2:
- rebase master.
---
This needs a review.
On Mon, Nov 25, 2013 at 11:34:44AM -0800, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 44
> 1 file changed, 44 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index 2912ae3..df7b6ef 100644
> --- a/FAQ
> +++ b/FAQ
> @@
Commit 307464a11 (ofproto-dpif-monitor: Use heap to order the mport
wakeup time.) makes bfd only send packet at specified periodic instant.
This fails to meet the RFC5880 requirement, which requires bfd send
FINAL immediately after receiving POLL.
This commit fixes the above issue by scheduling bf
On Mon, Nov 25, 2013 at 08:19:50AM -0800, Bruce Davie wrote:
> Add two new tables to the VTEP schema in support of distributed L3.
> Each table contains MAC addresses to be used by VTEPs (both hardware
> and software) when issuing ARP requests on behalf of a logical router.
>
> Signed-off-by: Bruc
This needs a review.
On Thu, Nov 21, 2013 at 05:03:13PM -0800, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index 2912ae3..a57362e 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -723,6 +723,19 @@ A: Did you in
This could use a review (should be easy).
On Thu, Nov 21, 2013 at 03:03:43PM -0800, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/rconn.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/rconn.c b/lib/rconn.c
> index f7f90f7..6c96fe0 100644
>
Yes. We're starting to accumulate a lot of those. I'm planning to work
on a unified solution.
On Fri, Dec 06, 2013 at 05:09:15PM -0800, Ethan Jackson wrote:
> Could we add a grep for this to the make?
>
> Ethan
>
> On Fri, Dec 6, 2013 at 3:57 PM, Joe Stringer wrote:
> > Acked-by: Joe Stringer
Thanks, applied.
On Fri, Dec 06, 2013 at 03:57:06PM -0800, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
> On 20 November 2013 16:50, Ben Pfaff wrote:
> > Putting "static inline" on a function definition in a .c file does not help
> > the compiler and does suppress warnings for unused function
Sorry about that.
I can put in the ernno for the error but the problem is CryptGenRandom does not
set the error number.
So it is either just print the value of GetLastError() or I use FormatMessage
function to get the text from that value. Like the following:
lib/entropy.c | 28
On Mon, Nov 11, 2013 at 09:03:03PM -0800, Ben Pfaff wrote:
> On Tue, Nov 12, 2013 at 09:19:59AM +0800, Jesse Gross wrote:
> > On Tue, Nov 12, 2013 at 7:53 AM, Ben Pfaff wrote:
> > > On Fri, Nov 08, 2013 at 10:54:38AM -0800, Jarno Rajahalme wrote:
> > >> Add DPIF-level support for meters. Allow met
Pushed, thanks!
I corrected a typo in a comment (“alloed” -> “allowed”), which breaks the next
patch in the series. The resolution is trivial, so I’d rather not send out a
new version if not needed otherwise.
Jarno
On Dec 13, 2013, at 3:59 PM, Ben Pfaff wrote:
> On Fri, Nov 15, 2013 at 03:
On Mon, Dec 16, 2013 at 12:02:00AM +0400, Vasiliy Tolstov wrote:
> 2013/12/14 Ben Pfaff :
> > Occasionally in the unit tests the following race can happen:
> >
> >1. ovs-vsctl updates database
> >2. ovs-vswitchd reconfigures, notifies ovs-vsctl that it is complete
> >3. ovs-appctl ofpro
On Mon, Dec 16, 2013 at 06:42:23PM +0900, Simon Horman wrote:
> On Mon, Dec 16, 2013 at 02:55:39PM +0900, Simon Horman wrote:
> > Hi Ben,
> >
> > On Fri, Dec 13, 2013 at 12:28:21AM -0800, Ben Pfaff wrote:
> > > I've been a little frustrated with the current approach to MPLS, because
> > > it
> >
On Mon, Dec 16, 2013 at 02:55:39PM +0900, Simon Horman wrote:
> On Fri, Dec 13, 2013 at 12:28:21AM -0800, Ben Pfaff wrote:
> > I've been a little frustrated with the current approach to MPLS, because it
> > seems quite difficult to understand. One particularly difficult bit for
> > me is the varia
On Fri, Dec 13, 2013 at 5:13 PM, Alin Serdean
wrote:
> This is an addition to the following patch:
> http://openvswitch.org/pipermail/dev/2013-November/034001.html .
> Beside the windefs.h creation more typedefs, defines and pragmas we're added.
>
> Signed-off-by: Alin Serdean
> ---
> ---
> diff
On Dec 14, 2013, at 11:27 AM, Gurucharan Shetty wrote:
> On Fri, Dec 13, 2013 at 6:53 PM, Kyle Mestery wrote:
>> Fixes the OVS builds on Fedora, which are currently broken upstream.
>>
>> Signed-off-by: Kyle Mestery
> Thanks for fixing.
> I applied this to master.
>
Thanks for the review and
On Mon, Dec 16, 2013 at 02:55:39PM +0900, Simon Horman wrote:
> Hi Ben,
>
> On Fri, Dec 13, 2013 at 12:28:21AM -0800, Ben Pfaff wrote:
> > I've been a little frustrated with the current approach to MPLS, because it
> > seems quite difficult to understand. One particularly difficult bit for
> > me
Update the netdev_class so that struct ofpbuf * is passed to rx_recv()
to provide both the data and size of the data to read a packet into.
On success, update struct ofpbuf size inside netdev_class rx_recv
implementation and return 0. This moves logic from the caller.
On error a negative error cod
If VLAN acceleration is used when the kernel receives a packet
then the outer-most VLAN tag will not be present in the packet
when it is received by netdev-linux. Rather, it will be present
in auxdata.
This patch uses recvmsg() instead of recv() to read auxdata for
each packet and if the vlan_tid
If VLAN acceleration is used when the kernel receives a packet
then the outer-most VLAN tag will not be present in the packet
when it is received by netdev-linux. Rather, it will be present
in auxdata.
The purpose of this series is to obtain the vlan_tid from auxdata
as appropriate and push it ont
This reworks lookup of rules for both table 0 and table action translation.
The result is that Table Mod settings, which can alter the miss-behaviour
of tables, including table 0, on a per-table basis may be honoured.
Previous patches proposed by myself which build on earlier merged patches
by And
Add table config to to struct ofproto and set it
when a table mod message is received.
This is in preparation for changing the behaviour of the switch
based on table config.
Cc: Andy Zhou
Signed-off-by: Simon Horman
---
v3
* As suggested by Ben Pfaff
+ Use atomic type for config field of st
This series of patches adds support for using Table Mod settings for
table-miss handling.
This series does not alter the default behaviour of Open vSwitch. And in
particular the OpenFlow1.1 behaviour is the default regardless of which
OpenFlow version is negotiated between the switch and the contr
73 matches
Mail list logo
