Re: [ovs-dev] OVS bonding features - liblagg

2013-10-21 Thread Ben Pfaff
Hi Jiri. Sorry about the delay in responding. I've been taking my time to mull the various issues that came up as I thought about it. When you suggested this off-list, my first thought was that this could be beneficial to all parties. After all, avoiding code duplication means that there is les

Re: [ovs-dev] vlan tag add/remove affect bandwidth a lot

2013-10-21 Thread Reid Price
The VMs are the same, but the traffic is not, one has VLAN tags, which seems to be provoking a difference in handling. Check that your drivers / intermediate switches are handling things correctly. -Reid On Sun, Oct 20, 2013 at 5:57 PM, Li, Chen wrote: > But, I don’t understand, all part o

Re: [ovs-dev] filename encoding in Python--any Python programmers in the house?

2013-10-21 Thread Reid Price
Apologies for the long answer. Skip to the last two paragraphs for suggestions. > "%s: %s %s" % (self.name, title, msg) I've narrowed this down a bit. The minimal reproduction is: # python -c '"%s%s" % ("\xc2", u"")' UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 0: ord

Re: [ovs-dev] [PATCH] odp-execute: Fix possible segfault.

2013-10-21 Thread Alex Wang
Yes, branch-2.0 is safe. Thanks, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] odp-execute: Fix possible segfault.

2013-10-21 Thread Ben Pfaff
On Fri, Oct 18, 2013 at 05:27:51PM -0700, Alex Wang wrote: > In current code, the odp_execute_actions() function does not check > the value of "userspace" function pointer before invoking it. This > patch adds a check for it. > > Signed-off-by: Alex Wang Applied to master, thanks. (It looks li

Re: [ovs-dev] [PATCH] ofproto: Fix coding style.

2013-10-21 Thread Ben Pfaff
On Fri, Oct 18, 2013 at 01:32:46AM -0700, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] classifier: Fix a typo.

2013-10-21 Thread Ben Pfaff
On Fri, Oct 18, 2013 at 01:32:45AM -0700, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-21 Thread Ben Pfaff
Commit e3b5693319c (Fix table checking for goto table instruction.) moved action checking into modify_flows__(), for good reason, but as a side effect made modify_flows__() abandon and never commit the ofopgroup that it started, if action checking failed. This commit fixes the problem. The follow

Re: [ovs-dev] [PATCH v7 3/3] Translation of fast failover groups

2013-10-21 Thread Ben Pfaff
On Tue, Oct 15, 2013 at 05:17:50PM +0900, Simon Horman wrote: > Fast failover groups use the actions in > the first bucket that is alive. > > Signed-off-by: Simon Horman Please make bucket_is_alive() log a rate-limited warning if it reaches the liveness depth limit. xlate_ff_group() abandons tr

Re: [ovs-dev] [mega mask stats v4 2/2] dpif-linux: collect and display mega flow mask stats

2013-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2013 at 02:37:34PM -0700, Andy Zhou wrote: > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7 2/3] Translation of indirect and all groups

2013-10-21 Thread Ben Pfaff
On Tue, Oct 15, 2013 at 05:17:49PM +0900, Simon Horman wrote: > Allow translation of indirect and all groups. Also allow insertion of > indirect and all groups by changing the maximum permitted number in the > groups table from 0 to OFPG_MAX. > > Implementation note: > > After translating the ac

Re: [ovs-dev] [mega mask stats v3 1/2] datapath: collect mega flow mask stats

2013-10-21 Thread Jesse Gross
Yes, I can commit both patches when it's ready. On Mon, Oct 21, 2013 at 2:36 PM, Andy Zhou wrote: > I will send out a V4 to address those remaining issues. Ben has reviewed and > acked the user space part of > patch, would you please consider commit both if v4 looks O.K.? > > > On Fri, Oct 18, 20

[ovs-dev] [mega mask stats v4 1/2] datapath: collect mega flow mask stats

2013-10-21 Thread Andy Zhou
Collect mega flow mask stats. ovs-dpctl show command can be used to display them. Signed-off-by: Andy Zhou --- v1-v2: * remove get_dp_megaflow_stats(), extend get_dp_stats() instead * use __always_unused instead of GCC extensions * fix comments * fix the logic of c

[ovs-dev] [mega mask stats v4 2/2] dpif-linux: collect and display mega flow mask stats

2013-10-21 Thread Andy Zhou
Signed-off-by: Andy Zhou v1-v2: * format fixes * added contents to ovs-dpctl man page * allow mask count to be zero. v2->v3: * Avoid divide by zero if n_pkts is zero. v3->v4: * Minor style changes --- NEWS |2 ++ lib/dpif-lin

Re: [ovs-dev] [mega mask stats v3 1/2] datapath: collect mega flow mask stats

2013-10-21 Thread Andy Zhou
I will send out a V4 to address those remaining issues. Ben has reviewed and acked the user space part of patch, would you please consider commit both if v4 looks O.K.? On Fri, Oct 18, 2013 at 5:35 PM, Jesse Gross wrote: > On Fri, Oct 18, 2013 at 4:54 PM, Andy Zhou wrote: > > Collect mega flow

Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel structures (for GRE, VXLAN etc.)

2013-10-21 Thread Romain Lenglet
- Original Message - > From: "Romain Lenglet" > To: "Jesse Gross" > Cc: dev@openvswitch.org > Sent: Friday, October 18, 2013 6:46:05 PM > Subject: Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel > structures (for GRE, VXLAN etc.) > > - Original Message - > > From: "J

[ovs-dev] [PATCH 1/2] cfm: Add ovsdb column "cfm_flap_count".

2013-10-21 Thread Alex Wang
This commit adds a new ovsdb column "cfm_flap_count". It is to count the number of cfm fault flapping since start. Signed-off-by: Alex Wang --- lib/cfm.c | 19 +++ lib/cfm.h |1 + ofproto/ofproto-dpif.c |1 + ofproto/ofproto.h

[ovs-dev] [PATCH 2/2] bfd: Add ovsdb key "bfd:flap_count".

2013-10-21 Thread Alex Wang
This commit adds a new ovsdb key "bfd:flap_count". It is to count the number of bfd state flapping since start. Signed-off-by: Alex Wang --- lib/bfd.c| 14 ++ tests/bfd.at | 50 ++ vswitchd/vswitch.xml |7 ++

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: Implement group callbacks

2013-10-21 Thread Ben Pfaff
On Tue, Oct 15, 2013 at 05:17:48PM +0900, Simon Horman wrote: > This is a first step towards implementing the dpif side of groups. > > In order to be useful the action translation code needs > to be taught about groups. > > Signed-off-by: Simon Horman The code in group_get_stats() worries me.

Re: [ovs-dev] [PATCH v2.44 1/5] odp: Allow VLAN actions after MPLS actions

2013-10-21 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 10:15:07AM +0900, Simon Horman wrote: > From: Joe Stringer > > OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the > presence of VLAN tags. To allow correct behaviour to be committed in > each situation, this patch adds a second round of VLAN tag

Re: [ovs-dev] [PATCH v2.44 2/5] ofp-actions: Add separate OpenFlow 1.3 action parser

2013-10-21 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 10:15:08AM +0900, Simon Horman wrote: > From: Joe Stringer > > This patch adds new ofpact_from_openflow13() and > ofpacts_from_openflow13() functions parallel to the existing ofpact > handling code. In the OpenFlow 1.3 version, push_mpls is handled > differently, but all o

Re: [ovs-dev] [PATCH] ofproto: Send only one OFPT_FLOW_REMOVED message when a flow expires.

2013-10-21 Thread Ben Pfaff
Thanks, applied to master and branch-2.0. On Fri, Oct 18, 2013 at 05:25:05PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > On Oct 18, 2013, at 4:30 PM, Ben Pfaff wrote: > > > Commit 15aaf59932a3 (ofproto: Add global locking around flow table > > changes.) introduce

[ovs-dev] filename encoding in Python--any Python programmers in the house?

2013-10-21 Thread Ben Pfaff
The Debian builds of Open vSwitch have suffered mysterious (to me) errors for some time, e.g.: https://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=amd64&ver=1.9.3%2Bgit20131021-1&stamp=1382373784&file=log The root of these problems seems to be in filename encoding. The Debian

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2013 at 09:40:58AM -0700, Jarno Rajahalme wrote: > I went along with the direction of allowing these actions only for > IPv4, as the spec says. This brings difficulties down the road, > however. Basically it becomes impossible to translate between these > set actions and the OF 1.2+

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-21 Thread Jarno Rajahalme
On Oct 17, 2013, at 3:02 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 02:59:07PM -0700, Jarno Rajahalme wrote: >> >> On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: >> >>> On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: Signed-off-by: Jarno Rajahalme >>> >>> This rais

[ovs-dev] openvswitch_1.9.3+git20131021-1_i386.changes ACCEPTED into unstable

2013-10-21 Thread Debian FTP Masters
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Mon, 21 Oct 2013 08:53:11 -0700 Source: openvswitch Binary: openvswitch-datapath-source openvswitch-datapath-dkms openvswitch-common openvswitch-switch openvswitch-ipsec openvswitch-pki openvswitch-controller openvswi

[ovs-dev] Processing of openvswitch_1.9.3+git20131021-1_i386.changes

2013-10-21 Thread Debian FTP Masters
openvswitch_1.9.3+git20131021-1_i386.changes uploaded successfully to localhost along with the files: openvswitch_1.9.3+git20131021-1.dsc openvswitch_1.9.3+git20131021.orig.tar.xz openvswitch_1.9.3+git20131021-1.debian.tar.gz openvswitch-common_1.9.3+git20131021-1_i386.deb openvswitch-swi