On Mon, Oct 21, 2013 at 09:40:58AM -0700, Jarno Rajahalme wrote: > I went along with the direction of allowing these actions only for > IPv4, as the spec says. This brings difficulties down the road, > however. Basically it becomes impossible to translate between these > set actions and the OF 1.2+ set field action, due to the different > semantics. I found that in some cases we can track that the action is > being performed on an IPv4 packet, by checking the flow->dl_type while > checking the actions. This check is not possible with flows that do > not match on the dl_type, or any indirect actions, like with group > buckets. > > Therefore I feel the decision how we treat these actions also decides > whether it makes sense to even try to translate the set actions > deprecated in OF 1.2 to set field actions. I'm now inclined to allow > the set actions on DSCP, ECN, and TTL to act on both IPv4 and IPv6 > packets. Any possible negative impact of this choice is limited to an > OF 1.1 controller setting these fields without matching the dl_type to > IPv4 in any phase of a pipeline. I think the chances to encounter this > in the wild are rather slim :-)
OK. I wondered whether this would come up. Let's change those actions to apply to both IPv4 and IPv6, then. As I said, I'm fine with that choice too. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
