From: Guolin Yang
In monitor_daemon(), it set subprogram_name to "" which causes
system crash in some platform. This change set subprogram name
to program name.
Signed-off-by: Guolin Yang
---
lib/daemon.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/daemon.c b/lib
On Sat, Sep 07, 2013 at 03:51:26AM +0300, Daniel Baluta wrote:
> On Fri, Sep 6, 2013 at 8:30 PM, Ben Pfaff wrote:
> > On Fri, Sep 06, 2013 at 12:23:40AM +0300, Daniel Baluta wrote:
> >> Fix typo in enum ofp13_flow_mod_flags comment caused probably
> >> by a copy/paste error.
> >>
> >> Signed-off-b
On Fri, Sep 6, 2013 at 8:30 PM, Ben Pfaff wrote:
> On Fri, Sep 06, 2013 at 12:23:40AM +0300, Daniel Baluta wrote:
>> Fix typo in enum ofp13_flow_mod_flags comment caused probably
>> by a copy/paste error.
>>
>> Signed-off-by: Daniel Baluta
>> ---
>> Changes since v1:
>> * fixed typo in comm
On Fri, Sep 6, 2013 at 2:54 PM, Pravin B Shelar wrote:
> Rehashing in ovs-workqueue can cause ovs-mutex lock contentions
> in case of heavy flow setups where both needs ovs-mutex. So by
> moving rehashing to flow-setup we can eliminate contention.
> This also simplify ovs locking and reduces depe
Rehashing in ovs-workqueue can cause ovs-mutex lock contentions
in case of heavy flow setups where both needs ovs-mutex. So by
moving rehashing to flow-setup we can eliminate contention.
This also simplify ovs locking and reduces dependence on
workqueue.
Signed-off-by: Pravin B Shelar
---
datap
Thanks!
On Fri, Sep 06, 2013 at 02:48:43PM -0700, Ethan Jackson wrote:
> I sent out a fix.
>
> Ethan
>
> On Thu, Sep 5, 2013 at 3:38 PM, Ben Pfaff wrote:
> > It looks like bundle_send_learning_packets() has the same sort of
> > mac-learning deadlock fixed in another place by commit d6d5bbc9e43f
Holding the mac learning rwlock while calling send_packet() which
calls xlate_actions() is dangerous because somewhere deep in the chain
the same lock might be acquired causing a deadlock. Though we haven't
run into this problem in testing, it seems prudent to refactor it.
Reported-by: Ben Pfaff
I sent out a fix.
Ethan
On Thu, Sep 5, 2013 at 3:38 PM, Ben Pfaff wrote:
> It looks like bundle_send_learning_packets() has the same sort of
> mac-learning deadlock fixed in another place by commit d6d5bbc9e43f5.
>
> I'm sending this email as a placeholder to remind one of us to fix
> this.
>
>
Yep, we've already seen that once with the mac rwlock though in a very
similar situation involving STP. I'm not totally sure if it can
happen here or not, but it feels quite a bit safer to be conservative
here. Also holding the lock for less time is better anyways.
Ethan
On Fri, Sep 6, 2013 at
On Fri, Sep 6, 2013 at 1:28 PM, Pravin B Shelar wrote:
> Rather than rehashing flow table in a workqueue, we can safely
> do it at flow install. This simplify ovs locking and reduces
> dependence on workqueue.
>
> Signed-off-by: Pravin B Shelar
It might also be good to add a comment about the p
Rather than rehashing flow table in a workqueue, we can safely
do it at flow install. This simplify ovs locking and reduces
dependence on workqueue.
Signed-off-by: Pravin B Shelar
---
datapath/datapath.c | 50 +++---
datapath/datapath.h |2 ++
2
On Thu, Sep 5, 2013 at 6:20 PM, Simon Horman wrote:
> Hi Jesse,
>
> I have been looking at updating the recirculation implementation for
> currently merged multi-threaded miss handling and planned changes by
> Ethan to remove facts from ovs-vswtichd. I would like this chance to
> thank Ethan for s
vxlan-udp-recv function lookup vxlan_sock struct on every packet
recv by using udp-port number. we can use sk->sk_user_data to
store vxlan_sock and avoid lookup.
I have open coded rcu-api to store and read vxlan_sock from
sk_user_data to avoid sparse warning as sk_user_data is not
__rcu pointer.
b
On Sep 6, 2013, at 12:53 PM, Ethan Jackson wrote:
> Holding the mac learning rwlock while calling send_packet() which
> calls xlate_actions() is dangerous because somewhere deep in the chain
> the same lock might be acquired causing a deadlock. Though we haven't
> run into this problem in testi
On Fri, Sep 6, 2013 at 12:38 PM, Jesse Gross wrote:
> On Fri, Sep 6, 2013 at 12:30 PM, Pravin Shelar wrote:
>> On Fri, Sep 6, 2013 at 12:15 PM, Jesse Gross wrote:
>>> On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/
On Fri, Sep 6, 2013 at 11:16 AM, Pravin B Shelar wrote:
> OVS already has compat functions to handle GSO packets.
> Following patch get rid of GSO packet handling in lisp
> and use ovs iptunnel_xmit() function for same.
>
> CC: Lori Jakab
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
On Fri, Sep 6, 2013 at 12:30 PM, Pravin Shelar wrote:
> On Fri, Sep 6, 2013 at 12:15 PM, Jesse Gross wrote:
>> On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
>>> diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c
>>> index db14f2f..3d4fec3 100644
>>> --- a/datapa
On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
> Backport of upstream commit 117961878cc1 (vxlan: remove net
> arg from vxlan[6]_xmit_skb()).
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
ht
On Fri, Sep 6, 2013 at 12:15 PM, Jesse Gross wrote:
> On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
>> diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c
>> index db14f2f..3d4fec3 100644
>> --- a/datapath/linux/compat/vxlan.c
>> +++ b/datapath/linux/compat/vxlan.
On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
> Backport of upstream commit 8b7ed2d91d6af (iptunnels: remove
> net arg from iptunnel_xmit()).
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
h
OVS already has compat functions to handle GSO packets.
Following patch get rid of GSO packet handling in lisp
and use ovs iptunnel_xmit() function for same.
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
---
datapath/vport-lisp.c | 221 +++--
1 files
On Fri, Sep 6, 2013 at 11:39 AM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c
> index db14f2f..3d4fec3 100644
> --- a/datapath/linux/compat/vxlan.c
> +++ b/datapath/linux/compat/vxlan.c
> @@ -124,7 +124,8 @@ static int vxlan_udp_encap_recv(str
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
---
datapath/vport-lisp.c | 43 +++
1 files changed, 3 insertions(+), 40 deletions(-)
diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
index 259cc2b..2cec115 100644
--- a/datapath/vport-lisp.c
+++
vxlan-udp-recv function lookup vxlan_sock struct on every packet
recv by using udp-port number. we can use sk->sk_user_data to
store vxlan_sock and avoid lookup.
I have open coded rcu-api to store and read vxlan_sock from
sk_user_data to avoid sparse warning as sk_user_data is not
__rcu pointer.
b
Backport of upstream commit 8b7ed2d91d6af (iptunnels: remove
net arg from iptunnel_xmit()).
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/net/ip_tunnels.h |2 +-
datapath/linux/compat/ip_tunnels_core.c|2 +-
datapath/linux/compat/vxlan.c |3
Backport of upstream commit 117961878cc1 (vxlan: remove net
arg from vxlan[6]_xmit_skb()).
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/net/vxlan.h |2 +-
datapath/linux/compat/vxlan.c |2 +-
datapath/vport-vxlan.c|3 +--
3 files ch
On Fri, Sep 6, 2013 at 11:16 AM, Pravin B Shelar wrote:
> CC: Lori Jakab
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Looks good to me.
On 9/6/13 9:16 PM, Pravin B Shelar wrote:
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
Acked-by: Lorand Jakab
---
datapath/vport-lisp.c | 43 +++
1 files changed, 3 insertions(+), 40 deletions(-)
diff --git a/datapath/vport-li
Thanks.
I pushed series to master and 2.0.
On Wed, Sep 4, 2013 at 1:59 PM, Jesse Gross wrote:
> On Wed, Sep 4, 2013 at 1:53 PM, Pravin B Shelar wrote:
>> Patch removes genl, netlink, rtnl compat code and dpif-linux
>> fallback-id compat code.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by:
On Fri, Sep 06, 2013 at 12:23:40AM +0300, Daniel Baluta wrote:
> Fix typo in enum ofp13_flow_mod_flags comment caused probably
> by a copy/paste error.
>
> Signed-off-by: Daniel Baluta
> ---
> Changes since v1:
> * fixed typo in commit message :)
>
> include/openflow/openflow-1.3.h |2
> -} __aligned(__alignof__(long));
> +} __aligned(8); /* 8 byte alignment ensures this can be accessed as a long */
Don't you really want __aligned(MAX(__alignof__(__be64), sizeof (long))) ?
David
___
dev mailing list
dev@openvswitch.org
http
31 matches
Mail list logo
