Yep, we've already seen that once with the mac rwlock though in a very
similar situation involving STP.  I'm not totally sure if it can
happen here or not, but it feels quite a bit safer to be conservative
here.  Also holding the lock for less time is better anyways.

Ethan

On Fri, Sep 6, 2013 at 1:20 PM, Jarno Rajahalme <jrajaha...@nicira.com> wrote:
>
> On Sep 6, 2013, at 12:53 PM, Ethan Jackson <et...@nicira.com> wrote:
>
> Holding the mac learning rwlock while calling send_packet() which
> calls xlate_actions() is dangerous because somewhere deep in the chain
> the same lock might be acquired causing a deadlock.  Though we haven't
> run into this problem in testing, it seems prudent to refactor it.
>
>
> This would be a problem only if there was a nested attempt on a write lock,
> right?
>
>   Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to