On Fri, Sep 6, 2013 at 8:30 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Fri, Sep 06, 2013 at 12:23:40AM +0300, Daniel Baluta wrote:
>> Fix typo in enum ofp13_flow_mod_flags comment caused probably
>> by a copy/paste error.
>>
>> Signed-off-by: Daniel Baluta <dbal...@ixiacom.com>
>> ---
>> Changes since v1:
>> * fixed typo in commit message :)
>>
>> include/openflow/openflow-1.3.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/openflow/openflow-1.3.h
>> b/include/openflow/openflow-1.3.h
>> index 1071d3d..1093156 100644
>> --- a/include/openflow/openflow-1.3.h
>> +++ b/include/openflow/openflow-1.3.h
>> @@ -117,7 +117,7 @@ enum ofp13_table_config {
>> };
>>
>> /* OpenFlow 1.3 specific flags
>> - * (struct ofp12_flow_mod, member flags). */
>> + * (struct ofp13_flow_mod, member flags). */
>
> Hmm. I thought the issue you saw here was that there is no
> ofp12_flow_mod structure (because OF1.1, 1.2, 1.3 all use the same
> message). By the same token, there is no ofp13_flow_mod structure
> either, so I think that this version of the comment would be equally
> confusing.
>
> What do you think of the following instead?
>
> --8<--------------------------cut here-------------------------->8--
>
> From: Daniel Baluta <dbal...@ixiacom.com>
> Date: Fri, 6 Sep 2013 00:23:40 +0300
> Subject: [PATCH] openflow-1.3.h: Fix typo
>
> Fix typo in enum ofp13_flow_mod_flags comment caused probably
> by a copy/paste error.
>
> Signed-off-by: Daniel Baluta <dbal...@ixiacom.com>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> include/openflow/openflow-1.3.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/openflow/openflow-1.3.h b/include/openflow/openflow-1.3.h
> index 1071d3d..767e048 100644
> --- a/include/openflow/openflow-1.3.h
> +++ b/include/openflow/openflow-1.3.h
> @@ -116,8 +116,7 @@ enum ofp13_table_config {
> OFPTC13_DEPRECATED_MASK = 3 /* Deprecated bits */
> };
>
> -/* OpenFlow 1.3 specific flags
> - * (struct ofp12_flow_mod, member flags). */
> +/* OpenFlow 1.3 specific flags for flow_mod messages. */
> enum ofp13_flow_mod_flags {
> OFPFF13_NO_PKT_COUNTS = 1 << 3, /* Don't keep track of packet count. */
> OFPFF13_NO_BYT_COUNTS = 1 << 4 /* Don't keep track of byte count. */
> --
> 1.7.10.4
This looks good to me. Thanks for clarification!
Daniel.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
