This corrects an minor oversight in "ofproto-dpif: Make vlan splinters thread
safe." which add thread-safety to these functions.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 5a64
Hey Ethan,
> Basically if the remote endpoint signaled cpath down, and
> forwarding_if_rx is enabled, that state should be sticky even if we
> lose some of their packets.
>
We do have a similar issue in BFD. I'm not sure if I fully understand your
suggestion. But I have a intuitive fix below:
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true the interface will be considered
capable of packet I/O as long as there is packet received at
interface. This is important in that when link becomes temporarily
conjested, consecutive BFD control packet
Really sorry, this patch does not include all the changes. Please ignore
this patch.
On Wed, Aug 21, 2013 at 3:24 PM, Alex Wang wrote:
> This commit adds a new boolean option "forwarding_if_rx" to bfd.
>
> When forwarding_if_rx is true the interface will be considered
> capabale of packet I/O a
looks good.
Kais
On Wed, Aug 21, 2013 at 1:01 PM, Ben Pfaff wrote:
> Otherwise new Clang complains about this function because it only sometimes
> releases the lock (that is, it only does it when there is a lock to
> release).
>
> I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1
On Wed, Aug 21, 2013 at 10:06 AM, James Page wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 21/08/13 18:01, Jesse Gross wrote:
On 21/08/13 17:16, Jesse Gross wrote:
>> What's the status of OVS 1.12? Is this just a dev
>> branch or is it planned for release?
This commit adds a new boolean option "forwarding_if_rx" to bfd.
When forwarding_if_rx is true the interface will be considered
capabale of packet I/O as long as there is packet received at
interface. This is important in that when link becomes temporarily
conjested, consecutive BFD control packe
Thanks, merged.
Ethan
On Wed, Aug 21, 2013 at 2:54 PM, Ben Pfaff wrote:
> On Wed, Aug 21, 2013 at 02:50:59PM -0700, Ethan Jackson wrote:
>> GCC 4.6.3 gets confused by the str_to_*() functions in ofp-parse and
>> spits out the following warning.
>>
>> error: ???priority??? may be used uninitializ
On Wed, Aug 21, 2013 at 02:50:59PM -0700, Ethan Jackson wrote:
> GCC 4.6.3 gets confused by the str_to_*() functions in ofp-parse and
> spits out the following warning.
>
> error: ???priority??? may be used uninitialized in this function
>
> Signed-off-by: Ethan Jackson
Seems reasonable.
Acked
GCC 4.6.3 gets confused by the str_to_*() functions in ofp-parse and
spits out the following warning.
error: ‘priority’ may be used uninitialized in this function
Signed-off-by: Ethan Jackson
---
lib/ofp-parse.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
Acked-by: Ethan Jackson
On Wed, Aug 21, 2013 at 1:01 PM, Ben Pfaff wrote:
> I don't see any other way to make Clang realize that these are the real
> mutex implementation functions.
>
> I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
> I previously used version 1:3.4~svn187484
On Wed, Aug 21, 2013 at 2:26 PM, Ethan Jackson wrote:
> This patch is basically ready, two minor comments and we'll get it merged
> today.
>
> First the title line should be changed to "bfd: Implement
> forwarding_if_rx." Note the period.
>
>
Yes, how could I miss that.
> >
> > -return bf
This patch is basically ready, two minor comments and we'll get it merged today.
First the title line should be changed to "bfd: Implement
forwarding_if_rx." Note the period.
>
> -return bfd->state == STATE_UP
> -&& bfd->rmt_diag != DIAG_PATH_DOWN
> -&& bfd->rmt_diag != DIAG_
On Aug 21, 2013, at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 1e09c56..7b4ef41 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -5124,7 +5124,7 @@ choose_rule_to_evict(struct oftable *tabl
On Wed, Aug 21, 2013 at 01:47:45PM -0700, Romain Lenglet wrote:
> - Original Message -
> > From: "Ben Pfaff"
> > To: "Romain Lenglet"
> > Cc: dev@openvswitch.org
> > Sent: Wednesday, August 21, 2013 1:25:59 PM
> > Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in
> >
Implement a per-exporter flow cache with active timeout expiration.
Add columns "cache_active_timeout" and "cache_max_flows" into table
"IPFIX" to configure each cache.
Add per-flow elements "octetDeltaSumOfSquares",
"minimumIpTotalLength", and "maximumIpTotalLength" to replace
"ethernetTotalLengt
- Original Message -
> From: "Ben Pfaff"
> To: "Romain Lenglet"
> Cc: dev@openvswitch.org
> Sent: Wednesday, August 21, 2013 1:25:59 PM
> Subject: Re: [PATCH] ipfix: implement flow caching and aggregation in exporter
>
> On Tue, Aug 20, 2013 at 05:54:27PM -0700, Romain Lenglet wrote:
> >
On Tue, Aug 20, 2013 at 05:54:27PM -0700, Romain Lenglet wrote:
> Implement a per-exporter flow cache with active timeout expiration.
> Add columns "cache_active_timeout" and "cache_max_flows" into table
> "IPFIX" to configure each cache.
>
> Add per-flow elements "octetDeltaSumOfSquares",
> "mini
On Wed, Aug 21, 2013 at 11:26:13AM -0700, Jarno Rajahalme wrote:
> On Aug 12, 2013, at 9:57 PM, Ben Pfaff wrote:
>
> > OpenFlow 1.3 says that the band_types member of struct ofp_meter_features
> > is a bitmap of OFPMBT_* values. The OFPMBT_* values are 1-based, so
> > until now, to avoid wasting
On Wed, Aug 21, 2013 at 01:00:18PM -0700, Ethan Jackson wrote:
> The existing upcall stub size is not large enough even for the
> smallest miss upcalls.
>
> Signed-off-by: Ethan Jackson
> Reported-by: Guolin Yang
Acked-by: Ben Pfaff
___
dev mailing l
On Wed, Aug 21, 2013 at 01:00:19PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
> Reported-by: Guolin Yang
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I get a bunch of thread-safety warnings with the latest Clang without this
patch, because Clang is smart enough to see locking and unlocking but not
smart enough to figure out the relationships. This refactoring avoids the
warnings.
I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1
New Clang versions raise warnings about the incorrect old annotation.
I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |2 +-
ofproto/ofproto-dpif.h |2 +-
2 files chan
I upgraded from Clang 1:3.4~svn187484-1~exp1 to 1:3.4~svn188890-1~exp1 this
morning and got new thread safety warnings. This series fixes them.
All the new warnings appear to be false positives.
Ben Pfaff (4):
ovs-thread: Mark lock and unlock functions as
no_thread_safety_analysis.
ofpro
I don't see any other way to make Clang realize that these are the real
mutex implementation functions.
I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.
Signed-off-by: Ben Pfaff
---
lib/compiler.h |3 +++
lib/ovs-thread.c
Otherwise new Clang complains about this function because it only sometimes
releases the lock (that is, it only does it when there is a lock to
release).
I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.
Signed-off-by: Ben Pfaff
-
Signed-off-by: Ethan Jackson
Reported-by: Guolin Yang
---
lib/netdev.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index 088aea9..bf942a0 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -126,7 +126,9 @@ netdev_run(void)
ovs_rw
The existing upcall stub size is not large enough even for the
smallest miss upcalls.
Signed-off-by: Ethan Jackson
Reported-by: Guolin Yang
---
ofproto/ofproto-dpif-upcall.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.h b/ofproto/ofproto-dp
On Aug 12, 2013, at 9:57 PM, Ben Pfaff wrote:
> OpenFlow 1.3 says that the band_types member of struct ofp_meter_features
> is a bitmap of OFPMBT_* values. The OFPMBT_* values are 1-based, so
> until now, to avoid wasting bit 0, OVS mapped an OFPMBT_* with value 1 to
> bit 0, value 2 to bit 1, a
The subfacet rates (e.g. add rate, del rate) were computed by exponential
moving averaging function in ofproto-dpif.c. This patch replaces that
logic with coverage counters. And the rates can be checked by running
"ovs-appctl coverage/show" command.
Signed-off-by: Alex Wang
---
ofproto/ofproto
This commit changes the "ovs-appctl coverage/show" command to show the
per-second, per-minute and per-hour rates of function invocation. More
importantly, this makes using coverage counter an easy way to monitor
the execution of specific functions.
Signed-off-by: Alex Wang
---
lib/coverage-unix
On Tue, Aug 20, 2013 at 03:12:16PM -0700, Ben Pfaff wrote:
> On Tue, Aug 20, 2013 at 05:05:26PM -0400, Ed Maste wrote:
> > On 20 August 2013 14:10, Ben Pfaff wrote:
> > > Without this patch, I get Clang warnings that I don't understand for each
> > > of the non-static functions in dirs.c:
> > >
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/08/13 18:01, Jesse Gross wrote:
>>> On 21/08/13 17:16, Jesse Gross wrote:
> What's the status of OVS 1.12? Is this just a dev
> branch or is it planned for release?
> It's actually a dead branch. It looks like we're going to
On Wed, Aug 21, 2013 at 9:54 AM, James Page wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Hi Jesse
>
> On 21/08/13 17:16, Jesse Gross wrote:
What's the status of OVS 1.12? Is this just a dev branch or is
it planned for release?
>> It's actually a dead branch. It looks li
On Wed, Aug 21, 2013 at 05:05:01AM -0400, Ed Maste wrote:
> On 20 August 2013 14:10, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Ed Maste
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinf
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Jesse
On 21/08/13 17:16, Jesse Gross wrote:
>>> What's the status of OVS 1.12? Is this just a dev branch or is
>>> it planned for release?
> It's actually a dead branch. It looks like we're going to get a
> few more things in and call the version
On Wed, Aug 21, 2013 at 3:00 AM, James Page wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 21/08/13 10:26, James Page wrote:
>>> support and looks at least somewhat related, so it might be a
>>> good
place to start:
https://git.kernel.org/cgit/linux/kernel/git/torvalds
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/08/13 10:26, James Page wrote:
>> support and looks at least somewhat related, so it might be a
>> good
>>> place to start:
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/net/openvswitch?id=351638e7deeed2ec8ce451b53
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/08/13 17:23, Jesse Gross wrote:
>> Is this the case? Is the delta between DKMS and native kernel
>>> disappearing? Can I just ship the userspace tooling for 13.10
>>> of Ubuntu?
> It's going away but it's not quite there yet. The 3.11 upstream
On 20 August 2013 14:10, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Ed Maste
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Processing commands for cont...@bugs.debian.org:
> tags 719665 + sid jessie
Bug #719665 [src:libterralib] libterralib: FTBFS: Impossible to satisfy
Build-Depends
Added tag(s) sid and jessie.
> tags 719736 + sid jessie
Bug #719736 [openvswitch] openvswitch: build FTBFS "make check" failures on
mo
42 matches
Mail list logo
