looks good.
Kais

On Wed, Aug 21, 2013 at 1:01 PM, Ben Pfaff <b...@nicira.com> wrote:

> Otherwise new Clang complains about this function because it only sometimes
> releases the lock (that is, it only does it when there is a lock to
> release).
>
> I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
> I previously used version 1:3.4~svn187484-1~exp1.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
>  ofproto/ofproto-dpif.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 6f87aa6..4f1da53 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -4838,6 +4838,7 @@ choose_miss_rule(enum ofputil_port_config config,
> struct rule_dpif *miss_rule,
>
>  void
>  rule_release(struct rule_dpif *rule)
> +    OVS_NO_THREAD_SAFETY_ANALYSIS
>  {
>      if (rule) {
>          ovs_rwlock_unlock(&rule->up.evict);
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to