[ovs-dev] [mega output v2] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Andy Zhou
ovs-dpctl sometimes displays wildcarded fields as exact match. This patch fixes those cases. This patch implements the following logic. When OVS_FLOW_ATTR_MASK is missing, the entire key attributes will be displayed as exact match fields. When OVS_FLOW_ATTR_MASK is present, but some individual key

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Justin Pettit
Yeah, no problem. Thanks. --Justin On Jun 27, 2013, at 10:43 PM, Ben Pfaff wrote: > Justin, I'd appreciate if you'd handle this one. > > On Jun 27, 2013 10:37 PM, "Justin Pettit" wrote: >> Who wants to make the change? Ben, unless you want to handle it, Andy, can >> you respin it as a v2?

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Ben Pfaff
Justin, I'd appreciate if you'd handle this one. On Jun 27, 2013 10:37 PM, "Justin Pettit" wrote: > Who wants to make the change? Ben, unless you want to handle it, Andy, > can you respin it as a v2? If so, then I'll backport it and commit it when > I get back home in the next hour. > > --Justi

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Andy Zhou
I will send out a v2 patch soon. On Thu, Jun 27, 2013 at 10:37 PM, Justin Pettit wrote: > Who wants to make the change? Ben, unless you want to handle it, Andy, > can you respin it as a v2? If so, then I'll backport it and commit it when > I get back home in the next hour. > > --Justin > > >

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Justin Pettit
Who wants to make the change? Ben, unless you want to handle it, Andy, can you respin it as a v2? If so, then I'll backport it and commit it when I get back home in the next hour. --Justin On Jun 27, 2013, at 10:32 PM, Andy Zhou wrote: > Ben, thanks for the review. I agree with your comme

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Andy Zhou
Ben, thanks for the review. I agree with your comments. On Thu, Jun 27, 2013 at 10:16 PM, Ben Pfaff wrote: > On Wed, Jun 26, 2013 at 01:10:03AM -0700, Andy Zhou wrote: > > ovs-dpctl sometimes displays wildcarded fields as exact match. This > > patch fixes those cases. > > > > This patch impleme

Re: [ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Ben Pfaff
On Wed, Jun 26, 2013 at 01:10:03AM -0700, Andy Zhou wrote: > ovs-dpctl sometimes displays wildcarded fields as exact match. This > patch fixes those cases. > > This patch implements the following logic. When OVS_FLOW_ATTR_MASK is > missing, the entire key attributes will be displayed as exact matc

Re: [ovs-dev] [PATCH 4/5] flow: Only un-wildcard relevant IP headers.

2013-06-27 Thread Justin Pettit
That's a good idea as a sanity check--especially since the consequences are bad (the flow is rejected by the kernel). I'll look at adding that. --Justin On Jun 27, 2013, at 6:37 PM, Ethan Jackson wrote: > Out of curiosity, we don't we simply not emit the wildcards for those > fields of the p

Re: [ovs-dev] [PATCH 5/5] netflow: Only un-wildcard IPv4 packets.

2013-06-27 Thread Justin Pettit
Thanks for the reviews. I've pushed this series to all affected branches. --Justin On Jun 27, 2013, at 6:37 PM, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > On Thu, Jun 27, 2013 at 6:16 PM, Justin Pettit wrote: >> NetFlow v5 only supports IPv4, so don't bother un-wildcarding >> non-I

Re: [ovs-dev] [PATCH 1/2] Datapath: Bug fix: kernel rejects mega flow with encap masks

2013-06-27 Thread Jesse Gross
On Wed, Jun 26, 2013 at 8:54 AM, Andy Zhou wrote: > Bug #18233 > > Signed-off-by: Andy Zhou > --- > datapath/flow.c |1 + > 1 file changed, 1 insertion(+) Both applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

[ovs-dev] [PATCH 2/2] datapath: Bug fix: Kernel rejects flow with valid vlan field

2013-06-27 Thread Andy Zhou
Bug #18233 Signed-off-by: Andy Zhou --- datapath/flow.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 778771f..2ac36b6 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -1329,8 +1329,9 @@ static int ovs_key_from_nlattrs(st

[ovs-dev] [PATCH 1/2] Datapath: Bug fix: kernel rejects mega flow with encap masks

2013-06-27 Thread Andy Zhou
Bug #18233 Signed-off-by: Andy Zhou --- datapath/flow.c |1 + 1 file changed, 1 insertion(+) diff --git a/datapath/flow.c b/datapath/flow.c index fc6752e..778771f 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -1558,6 +1558,7 @@ int ovs_match_from_nlattrs(struct sw_flow_match *match,

[ovs-dev] [PATCH] datapath: Bug fix: kernel incorrectly rejects valid mega flow

2013-06-27 Thread Andy Zhou
Fix a few bugs in kernel netlink validation code. Bug #18233 Signed-off-by: Andy Zhou --- datapath/flow.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index fc6752e..2740898 100644 --- a/datapath/flow.c +++ b/da

Re: [ovs-dev] [PATCH 3/5] odp-util: Fix converting masked VLAN from flow.

2013-06-27 Thread Ethan Jackson
Sounds good to me. Ethan On Thu, Jun 27, 2013 at 6:43 PM, Jesse Gross wrote: > It's a validation limitation: if you have a vlan packet then you need > to have an exact match on a corresponding EtherType. If you only want > to match on the Ethernet header then it's fully maskable. > > On Thu, Jun

Re: [ovs-dev] [PATCH 3/5] odp-util: Fix converting masked VLAN from flow.

2013-06-27 Thread Jesse Gross
It's a validation limitation: if you have a vlan packet then you need to have an exact match on a corresponding EtherType. If you only want to match on the Ethernet header then it's fully maskable. On Thu, Jun 27, 2013 at 6:30 PM, Ethan Jackson wrote: > Is the lack of support for bitwise masking

Re: [ovs-dev] [PATCH 5/5] netflow: Only un-wildcard IPv4 packets.

2013-06-27 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Jun 27, 2013 at 6:16 PM, Justin Pettit wrote: > NetFlow v5 only supports IPv4, so don't bother un-wildcarding > non-IPv4 packets. > > Signed-off-by: Justin Pettit > --- > ofproto/netflow.c|5 - > ofproto/netflow.h|2 +- > ofpr

Re: [ovs-dev] [PATCH 4/5] flow: Only un-wildcard relevant IP headers.

2013-06-27 Thread Ethan Jackson
Out of curiosity, we don't we simply not emit the wildcards for those fields of the packet which are irrelevant? I.E. if an ethernet packet says to exact match the IP src, simply don't when we translate from a flow to an odp key? Acked-by: Ethan Jackson On Thu, Jun 27, 2013 at 6:16 PM, Justin P

Re: [ovs-dev] [PATCH 3/5] odp-util: Fix converting masked VLAN from flow.

2013-06-27 Thread Ethan Jackson
Is the lack of support for bitwise masking if the ethertype a kernel limitation or a userspace one? If it's a userspace limitation I think we should handle the case where it could be bitwise. If it's a kernel limitation, I think the current patch is fine. Acked-by: Ethan Jackson On Thu, Jun 27

Re: [ovs-dev] [PATCH 2/5] odp-util: Correct printing the VLAN PCP mask.

2013-06-27 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Jun 27, 2013 at 6:16 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > lib/odp-util.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/odp-util.c b/lib/odp-util.c > index fd4207a..7724be4 100644 > --- a/lib/odp-uti

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Remove old comment.

2013-06-27 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Jun 27, 2013 at 6:16 PM, Justin Pettit wrote: > --- > ofproto/ofproto-dpif-xlate.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index d77e4df..e338fc4 100644 > --- a/of

[ovs-dev] [PATCH 3/5] odp-util: Fix converting masked VLAN from flow.

2013-06-27 Thread Justin Pettit
When converting the VLAN from a flow to an ODP key, the processing logic would always store the VLAN ethertype. However, when handling a mask, it should be a mask, not an ethertype. And since we don't support bit-wise masking of the ethertype, just make it an exact-match mask. Signed-off-by: Jus

[ovs-dev] [PATCH 2/5] odp-util: Correct printing the VLAN PCP mask.

2013-06-27 Thread Justin Pettit
Signed-off-by: Justin Pettit --- lib/odp-util.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index fd4207a..7724be4 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -1063,7 +1063,7 @@ format_odp_key_attr(const struct nlattr *a, const

[ovs-dev] [PATCH 1/5] ofproto-dpif: Remove old comment.

2013-06-27 Thread Justin Pettit
--- ofproto/ofproto-dpif-xlate.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index d77e4df..e338fc4 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -547,7 +547,6 @@ xlate_normal

[ovs-dev] [PATCH 4/5] flow: Only un-wildcard relevant IP headers.

2013-06-27 Thread Justin Pettit
When determining the fields to un-wildcard, we need to be careful about only un-wildcarding fields that are relevant. Also, we didn't properly handle IPv6 addresses. Signed-off-by: Justin Pettit --- lib/bond.c |4 ++-- lib/bundle.c|2 +- lib/flow.c | 20 ++---

[ovs-dev] [PATCH 5/5] netflow: Only un-wildcard IPv4 packets.

2013-06-27 Thread Justin Pettit
NetFlow v5 only supports IPv4, so don't bother un-wildcarding non-IPv4 packets. Signed-off-by: Justin Pettit --- ofproto/netflow.c|5 - ofproto/netflow.h|2 +- ofproto/ofproto-dpif-xlate.c |2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Simon Horman
On Thu, Jun 27, 2013 at 02:14:42PM -0700, Justin Pettit wrote: > > On Jun 27, 2013, at 2:08 PM, Jesse Gross wrote: > > > On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: > >> The code that converts netlink attributes to a flow match always > >> stored TCP and UDP ports in the IPv4 structur

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

2013-06-27 Thread Jesse Gross
On Thu, Jun 27, 2013 at 12:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 26, 2013, at 21:39 , ext Jesse Gross wrote: >>> >>> OK, so you need to use the kernel version from the "with-linux" option >>> given to configure then? >>> I have configured with --with-linux=/lib/modules/`uname

[ovs-dev] [PATCH] datapath: Resolve external module dependencies.

2013-06-27 Thread Jesse Gross
The Open vSwitch kernel module now has dependencies on symbols exported by other kernel modules (currently just for GRE). In order for it to load, the dependencies must be correctly resolved ahead of time. This runs depmod as part of the module installation process and updates the installation inst

Re: [ovs-dev] [PATCH 1/2] datapath: Make GRE support conditional on CONFIG_NET_IPGRE_DEMUX.

2013-06-27 Thread Jesse Gross
On Thu, Jun 27, 2013 at 5:06 PM, Pravin Shelar wrote: > On Thu, Jun 27, 2013 at 4:14 PM, Jesse Gross wrote: >> I thought about that but I don't think that it's really the right >> thing to do as we converge the out of tree and in-tree modules. I >> think it's pretty clear that if you are running

Re: [ovs-dev] [PATCH 1/2] datapath: Make GRE support conditional on CONFIG_NET_IPGRE_DEMUX.

2013-06-27 Thread Pravin Shelar
On Thu, Jun 27, 2013 at 4:14 PM, Jesse Gross wrote: > I thought about that but I don't think that it's really the right > thing to do as we converge the out of tree and in-tree modules. I > think it's pretty clear that if you are running with the latest > upstream kernel then we shouldn't be using

Re: [ovs-dev] [xlate v1 15/18] lacp: Handle unknown slaves in lacp_process_packet().

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 04:41:18PM -0700, Ethan Jackson wrote: > > That's OK, but it would also be OK to just mention how one can tell. > > That's the problem. There's no obvious way to tell other than just > knowing that it's lacp_process_packet(). I could mark the function > somehow, but that'

Re: [ovs-dev] [xlate v1 15/18] lacp: Handle unknown slaves in lacp_process_packet().

2013-06-27 Thread Ethan Jackson
> That's OK, but it would also be OK to just mention how one can tell. That's the problem. There's no obvious way to tell other than just knowing that it's lacp_process_packet(). I could mark the function somehow, but that's weird. The new patch is better. I'll send it out soon. Ethan X-CudaM

Re: [ovs-dev] [xlate v1 15/18] lacp: Handle unknown slaves in lacp_process_packet().

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 04:35:55PM -0700, Ethan Jackson wrote: > > There are other lacp_*() functions that don't gracefully handle a null > > slave, how can one figure out which ones matter? > > I originally handled them, but then realized that the only one that > actually mattered was lacp_proces

Re: [ovs-dev] [xlate v1 15/18] lacp: Handle unknown slaves in lacp_process_packet().

2013-06-27 Thread Ethan Jackson
> There are other lacp_*() functions that don't gracefully handle a null > slave, how can one figure out which ones matter? I originally handled them, but then realized that the only one that actually mattered was lacp_process_packet(). That said, I think you're right that it's important to be co

Re: [ovs-dev] [PATCH 1/2] datapath: Make GRE support conditional on CONFIG_NET_IPGRE_DEMUX.

2013-06-27 Thread Jesse Gross
I thought about that but I don't think that it's really the right thing to do as we converge the out of tree and in-tree modules. I think it's pretty clear that if you are running with the latest upstream kernel then we shouldn't be using any backports, which in turn means that GRE support is contr

Re: [ovs-dev] [PATCH 1/2] datapath: Make GRE support conditional on CONFIG_NET_IPGRE_DEMUX.

2013-06-27 Thread Pravin Shelar
I think we can use gre compat code if gre-demux not available. Attached is incremental, what do you think? On Thu, Jun 27, 2013 at 10:02 AM, Jesse Gross wrote: > Pravin, can you take a look at this patch while we figure out the > Debian issues on the other one? > > On Tue, Jun 25, 2013 at 12:31

[ovs-dev] [partition v2 3/3] classifier: Speed up lookup when metadata partitions the flow table.

2013-06-27 Thread Ben Pfaff
We have a controller that puts many rules with different metadata values into the flow table, where metadata is used (by "resubmit"s) to distinguish stages in a pipeline. Thus, any given flow only needs to be hashed into classifier "cls_table"s that contain a match for the flow's metadata value. T

[ovs-dev] [partition v2 2/3] match: New function minimatch_matches_flow().

2013-06-27 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c |3 +- lib/flow.c | 126 ++ lib/flow.h | 10 +++-- lib/match.c | 31 +- lib/match.h | 18 +--- 5 files changed, 147 insertions(+), 41 deletions(-) di

[ovs-dev] [partition v2 0/3] speed up classification based on metadata

2013-06-27 Thread Ben Pfaff
This is a repost of the series previously posted May 8, rebased against current master. It needs to be tested internally to make sure that it actually provides the promised large performance boost. Ben Pfaff (3): openvswitch/types.h: New macros OVS_BE16_MAX, OVS_BE32_MAX, OVS_BE64_MAX. ma

[ovs-dev] [partition v2 1/3] openvswitch/types.h: New macros OVS_BE16_MAX, OVS_BE32_MAX, OVS_BE64_MAX.

2013-06-27 Thread Ben Pfaff
These seem slightly nicer than e.g. htons(UINT16_MAX). Signed-off-by: Ben Pfaff --- include/openvswitch/types.h |4 lib/match.c | 30 +++--- lib/meta-flow.c | 11 +-- lib/nx-match.c |8 lib/ofp-act

Re: [ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 10:07:36AM -0700, Ben Pfaff wrote: > On Thu, Jun 27, 2013 at 01:39:51AM +0300, Jarno Rajahalme wrote: > > > > Signed-off-by: Jarno Rajahalme > > I'm looking this over. I wanted to tweak some stuff, so I sent it all out as another series starting here: http://open

[ovs-dev] [meters 2/9] ofpact: New function ovs_instruction_type_from_ofpact_type().

2013-06-27 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 99 + lib/ofp-actions.h | 13 +-- 2 files changed, 79 insertions(+), 33 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index b934be1..14b1961 100644 --- a/lib/ofp-actions

[ovs-dev] [meters 5/9] ofproto: Use another method to find meter_id.

2013-06-27 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 12 +- lib/ofp-actions.h |2 - ofproto/ofproto.c | 60 ++--- 3 files changed, 40 insertions(+), 34 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 22d8cad..e1b44

[ovs-dev] [meters 3/9] ofproto: Implement OpenFlow 1.3 meter table.

2013-06-27 Thread Ben Pfaff
From: Jarno Rajahalme Signed-off-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 20 ++- lib/ofp-actions.h |2 + lib/rconn.c| 14 +- ofproto/ofproto-dpif.c |4 + ofproto/ofproto-provider.h | 49 +- ofproto/ofproto.c

[ovs-dev] [meters 7/9] ofproto: Meter-related comment updates.

2013-06-27 Thread Ben Pfaff
--- ofproto/ofproto-provider.h | 55 +-- ofproto/ofproto.c |2 +- ofproto/ofproto.h |1 - 3 files changed, 33 insertions(+), 25 deletions(-) diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h index 0e08d19..72c8

[ovs-dev] [meters 6/9] ofproto: Allocate meter bands separately from the meters themselves.

2013-06-27 Thread Ben Pfaff
This simplifies updates since nothing has to move except the meter bands. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 96 1 files changed, 30 insertions(+), 66 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 341cf

[ovs-dev] [meters 1/9] ofp-actions: Give ovs_instruction funcs names that start with that prefix.

2013-06-27 Thread Ben Pfaff
This seems slightly clearer, because ofpact_instruction_* makes me look for a type named ofpact_instruction. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 16 lib/ofp-actions.h |4 ++-- lib/ofp-parse.c |2 +- 3 files changed, 11 insertions(+), 11 deletions(-) dif

[ovs-dev] [meters 4/9] ofproto: Change 'const uint32_t *meter_id' to just 'uint32_t meter_id'.

2013-06-27 Thread Ben Pfaff
I see no point in passing a uint32_t by const pointer. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 31 +-- 1 files changed, 13 insertions(+), 18 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index bea6df1..6d87972 100644 --- a/ofproto/ofproto

[ovs-dev] [meters 0/9] Revised meters patch 4/5 proposal

2013-06-27 Thread Ben Pfaff
I spent some time looking at and playing with patch 4/5 "v2: ofproto: Implement OpenFlow 1.3 meter table." and decided that there was a fair bit that I wanted to tweak. This series represent what I came up with: IMPORTANT: In this series, I intend to squash all the patches after "Implement OpenFl

[ovs-dev] [meters 9/9] ofproto: Break handle_meter_mod() into sub-functions.

2013-06-27 Thread Ben Pfaff
This makes the code more obviously correct, to my eye, especially regarding the freeing of the 'band' ofpbuf. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 192 1 files changed, 103 insertions(+), 89 deletions(-) diff --git a/ofproto/ofpr

[ovs-dev] [meters 8/9] ofproto: Get rid of 'last_meter'.

2013-06-27 Thread Ben Pfaff
I don't see much value in this member because there is already an assumption that there is a relatively small maximum number of meters (ofproto allocates memory proportional to the maximum number of meters). Signed-off-by: Ben Pfaff --- ofproto/ofproto-provider.h |1 - ofproto/ofproto.c

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 02:42:09PM -0700, Jesse Gross wrote: > On Thu, Jun 27, 2013 at 2:10 PM, Ben Pfaff wrote: > > On Thu, Jun 27, 2013 at 02:08:22PM -0700, Jesse Gross wrote: > >> On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: > >> > The code that converts netlink attributes to a flow m

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Jesse Gross
On Thu, Jun 27, 2013 at 2:10 PM, Ben Pfaff wrote: > On Thu, Jun 27, 2013 at 02:08:22PM -0700, Jesse Gross wrote: >> On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: >> > The code that converts netlink attributes to a flow match always >> > stored TCP and UDP ports in the IPv4 structure. Thi

Re: [ovs-dev] [xlate v1 12/18] connmgr: Remove connmgr_must_output_local().

2013-06-27 Thread Ethan Jackson
Looks like a win, I've folded it in. Thanks. Ethan On Wed, Jun 26, 2013 at 2:45 PM, Ben Pfaff wrote: > On Wed, Jun 26, 2013 at 02:13:03PM -0700, Ben Pfaff wrote: >> On Mon, Jun 24, 2013 at 06:59:26PM -0700, Ethan Jackson wrote: >> > connmgr_must_output_local() requires a 'struct connmgr' handle

Re: [ovs-dev] [xlate v1 14/18] bond: Handle unknown slaves in bond_check_admissibility().

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 02:34:21PM -0700, Ethan Jackson wrote: > > Should we add bond_get_active_slave_tag() to the tags in this case? > > I don't think so but perhaps I'm wrong. If the slave isn't in the > bond, no matter what happens to the active_slave the answer is going > to be BV_DROP. At

Re: [ovs-dev] [xlate v1 14/18] bond: Handle unknown slaves in bond_check_admissibility().

2013-06-27 Thread Ethan Jackson
> Should we add bond_get_active_slave_tag() to the tags in this case? I don't think so but perhaps I'm wrong. If the slave isn't in the bond, no matter what happens to the active_slave the answer is going to be BV_DROP. At the point where the slave is added to the bond, we're going to revalidate

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Justin Pettit
On Jun 27, 2013, at 2:08 PM, Jesse Gross wrote: > On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: >> The code that converts netlink attributes to a flow match always >> stored TCP and UDP ports in the IPv4 structure. This commit >> properly puts TCP and UDP traffic into appropriate IPv4

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 02:08:22PM -0700, Jesse Gross wrote: > On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: > > The code that converts netlink attributes to a flow match always > > stored TCP and UDP ports in the IPv4 structure. This commit > > properly puts TCP and UDP traffic into appr

Re: [ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Jesse Gross
On Thu, Jun 27, 2013 at 1:58 PM, Justin Pettit wrote: > The code that converts netlink attributes to a flow match always > stored TCP and UDP ports in the IPv4 structure. This commit > properly puts TCP and UDP traffic into appropriate IPv4 and IPv6 > structures. > > Signed-off-by: Justin Pettit

[ovs-dev] [PATCH] datapath: Convert IPv6 TCP and UDP port netlink attributes properly.

2013-06-27 Thread Justin Pettit
The code that converts netlink attributes to a flow match always stored TCP and UDP ports in the IPv4 structure. This commit properly puts TCP and UDP traffic into appropriate IPv4 and IPv6 structures. Signed-off-by: Justin Pettit --- datapath/flow.c | 31 +++ 1 fi

Re: [ovs-dev] [PATCH] bridge: Don't log flow miss model on every reconfiguration.

2013-06-27 Thread Alex Wang
Looks good to me, On Wed, Jun 26, 2013 at 8:35 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > vswitchd/bridge.c |5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 4ac2b26..578c678 100644 > --- a/vswitchd/bridg

Re: [ovs-dev] [PATCH] ofp-errors: Fix typos in error enumeration names.

2013-06-27 Thread Alex Wang
Looks good to me, On Wed, Jun 19, 2013 at 1:55 PM, Ben Pfaff wrote: > OFPGMFC is so nice these constants said it twice. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-errors.h |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/ofp-errors.h b/lib/ofp-errors.

[ovs-dev] [PATCH] ovs-dpctl: Fix mega flow output

2013-06-27 Thread Andy Zhou
ovs-dpctl sometimes displays wildcarded fields as exact match. This patch fixes those cases. This patch implements the following logic. When OVS_FLOW_ATTR_MASK is missing, the entire key attributes will be displayed as exact match fields. When OVS_FLOW_ATTR_MASK is present, but some individual key

Re: [ovs-dev] [PATCH 3/3 v2] ovsdb-server: Add and remove databases during run time.

2013-06-27 Thread Ben Pfaff
On Wed, Jun 26, 2013 at 11:29:36AM -0700, Gurucharan Shetty wrote: > On Wed, Jun 26, 2013 at 10:51 AM, Gurucharan Shetty wrote: > > > > > > > On Tue, Jun 25, 2013 at 5:01 PM, Ben Pfaff wrote: > > > >> On Tue, Jun 25, 2013 at 01:18:36AM -0700, Gurucharan Shetty wrote: > >> > The commit allows a us

Re: [ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 01:39:51AM +0300, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme I'm looking this over. I noticed that there are lots of meter_ids passed by pointer that could be passed by value. I am folding this in: diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index

Re: [ovs-dev] [PATCH 1/2] datapath: Make GRE support conditional on CONFIG_NET_IPGRE_DEMUX.

2013-06-27 Thread Jesse Gross
Pravin, can you take a look at this patch while we figure out the Debian issues on the other one? On Tue, Jun 25, 2013 at 12:31 PM, Jesse Gross wrote: > Now that GRE support has been upstreamed into Linux, OVS is > using the components in the native kernel when available. However, > this means th

Re: [ovs-dev] [PATCH] datapath: optimize flow compare and mask functions

2013-06-27 Thread Jesse Gross
On Sat, Jun 22, 2013 at 5:32 AM, Andy Zhou wrote: > For architectures can load and store unaligned long efficiently, use 4 > or 8 bytes operations. This improves the efficiency compare to byte wise > operations. > > This patch is uses ideas and code from a patch submitted by Peter Klausler > title

Re: [ovs-dev] [PATCH 3/5] ofp-util: Meter fixes.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 09:11:07AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 27, 2013, at 3:13 , ext Ben Pfaff wrote: > > > On Thu, Jun 27, 2013 at 01:39:50AM +0300, Jarno Rajahalme wrote: > >> Validate claimed message length for meter stats in ofp-util.c. > >> Clean up meters i

Re: [ovs-dev] [PATCH] v2: ofp-util: Meter fixes.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 12:10:42PM +0300, Jarno Rajahalme wrote: > Validate claimed message length for meter stats in ofp-util.c. > Clean up meters in ofp-util.h. > Fix the impossible duration values in ofp-print.at.Summary: > > Signed-off-by: Jarno Rajahalme Thanks! Applied to master. One tip

Re: [ovs-dev] Possible regression in "datapath: Mega flow implementation"

2013-06-27 Thread Andy Zhou
Not likely. The change I am working on should only affect the display of the mask field, not the key values. On Thu, Jun 27, 2013 at 8:53 AM, Jesse Gross wrote: > Is this related to the issue that Andy started to work on here?: > http://openvswitch.org/pipermail/dev/2013-June/028820.html > > O

Re: [ovs-dev] Possible regression in "datapath: Mega flow implementation"

2013-06-27 Thread Jesse Gross
Is this related to the issue that Andy started to work on here?: http://openvswitch.org/pipermail/dev/2013-June/028820.html On Thu, Jun 27, 2013 at 2:05 AM, Simon Horman wrote: > Hi Justin, > > Thanks. > > I have enabled some extra debugging as you suggest and I now agree that the > zero UDP sour

Re: [ovs-dev] [PATCH 3/5] ofp-util: Meter fixes.

2013-06-27 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jun 27, 2013, at 3:13 , ext Ben Pfaff wrote: > On Thu, Jun 27, 2013 at 01:39:50AM +0300, Jarno Rajahalme wrote: >> Validate claimed message length for meter stats in ofp-util.c. >> Clean up meters in ofp-util.h. >> Fix the impossible duration values in ofp-print.at. >> >> Signed-off-by: Jarno

[ovs-dev] [PATCH] v2: ofp-util: Meter fixes.

2013-06-27 Thread Jarno Rajahalme
Validate claimed message length for meter stats in ofp-util.c. Clean up meters in ofp-util.h. Fix the impossible duration values in ofp-print.at.Summary: Signed-off-by: Jarno Rajahalme --- v2: Remove unnecessary length check in ofputil_decode_meter_config() and ofputil_decode_meter_stats(), a

Re: [ovs-dev] Possible regression in "datapath: Mega flow implementation"

2013-06-27 Thread Simon Horman
Hi Justin, Thanks. I have enabled some extra debugging as you suggest and I now agree that the zero UDP source and destination ports are suspicious. And that the packet in question is an IPv6/UDP mDNS packet with source and destination port of 5353 rather than a router solicitation request as I

Re: [ovs-dev] [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

2013-06-27 Thread David Miller
From: Isaku Yamahata Date: Thu, 27 Jun 2013 14:29:38 +0900 > So you mean like this patch? The callers of dev_forward_skb() are > only veth, macvlan and l2tp, which seem fine with this change. Yes, it is what I was suggesting. ___ dev mailing list dev@

Re: [ovs-dev] [PATCH 2/2] datapath: Resolve external module dependencies.

2013-06-27 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jun 26, 2013, at 21:39 , ext Jesse Gross wrote: >> >> OK, so you need to use the kernel version from the "with-linux" option given >> to configure then? >> I have configured with --with-linux=/lib/modules/`uname -r`/build so that >> happened to work for me. > > Would you mind taking a look