On Thu, Jun 27, 2013 at 09:11:07AM +0000, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jun 27, 2013, at 3:13 , ext Ben Pfaff wrote: > > > On Thu, Jun 27, 2013 at 01:39:50AM +0300, Jarno Rajahalme wrote: > >> Validate claimed message length for meter stats in ofp-util.c. > >> Clean up meters in ofp-util.h. > >> Fix the impossible duration values in ofp-print.at. > >> > >> Signed-off-by: Jarno Rajahalme <jarno.rajaha...@nsn.com> > > > > I think that the check in ofputil_decode_meter_config() is > > unnecessary, because ofputil_pull_bands() will check itself, via > > ofpbuf_try_pull(). > > So when the 'len' wraps to "negative" territory, the > ofpbuf_try_pull() will obviously fail trying to pull huge amount of > data.
Right. I don't know whether this is obvious enough to be clean coding or not, but I do think that it works. Thanks for the revised version. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
