On Jun 27, 2013, at 3:13 , ext Ben Pfaff wrote: > On Thu, Jun 27, 2013 at 01:39:50AM +0300, Jarno Rajahalme wrote: >> Validate claimed message length for meter stats in ofp-util.c. >> Clean up meters in ofp-util.h. >> Fix the impossible duration values in ofp-print.at. >> >> Signed-off-by: Jarno Rajahalme <jarno.rajaha...@nsn.com> > > I think that the check in ofputil_decode_meter_config() is > unnecessary, because ofputil_pull_bands() will check itself, via > ofpbuf_try_pull().
So when the 'len' wraps to "negative" territory, the ofpbuf_try_pull() will obviously fail trying to pull huge amount of data. > But it looks like I forgot to make a corresponding > improvement in ofputil_pull_band_stats(), and the new change in > ofputil_decode_meter_config() isn't enough, because if len > msg->size > then the ofpbuf_pull() in ofputil_pull_band_stats() will assert-fail. > Right? Right, will post a new patch with these fixed soon. Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
