Thanks for the reviews. I pushed to all affected branches.
--Justin
On Jun 25, 2013, at 10:23 PM, Ben Pfaff wrote:
> Looks good.
>
> On Jun 25, 2013 6:29 PM, "Justin Pettit" wrote:
> We always look at the fragment status and often look at other L3
> headers when processing the packet, so ju
Looks good.
On Jun 25, 2013 6:29 PM, "Justin Pettit" wrote:
> We always look at the fragment status and often look at other L3
> headers when processing the packet, so just un-wildcard the
> Ethertype.
>
> Signed-off-by: Justin Pettit
> ---
> lib/bfd.c|1 -
> lib/cfm.c
That's good, thanks. Looks good.
On Jun 25, 2013 9:26 PM, "Justin Pettit" wrote:
> I found this by inspection, but how about something like the following?
>
> -=-=-=-=-=-=-=-=-=-
> With tunnels carrying IP packets, ECN bits are always inherited by the
> encapsulating tunnel. However, it doesn't
I found this by inspection, but how about something like the following?
-=-=-=-=-=-=-=-=-=-
With tunnels carrying IP packets, ECN bits are always inherited by the
encapsulating tunnel. However, it doesn't make sense to unwildcard the inner
packet's TOS fields if the packet is not IP.
Found by
The change log could use some explanation of why, e.g. a description of
what bug this fixes.
On Jun 25, 2013 6:29 PM, "Justin Pettit" wrote:
> Signed-off-by: Justin Pettit
> ---
> ofproto/tunnel.c |7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/ofproto/tunnel.
We always look at the fragment status and often look at other L3
headers when processing the packet, so just un-wildcard the
Ethertype.
Signed-off-by: Justin Pettit
---
lib/bfd.c|1 -
lib/cfm.c|1 -
lib/flow.c |1 -
ofproto/ne
Signed-off-by: Justin Pettit
---
ofproto/tunnel.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
index dedfca8..1a39aea 100644
--- a/ofproto/tunnel.c
+++ b/ofproto/tunnel.c
@@ -253,11 +253,14 @@ tnl_port_send(const struct tnl_port
Thanks, applied to master.
On Tue, Jun 25, 2013 at 02:26:38PM -0700, Alex Wang wrote:
> looks good to me,
>
>
> On Wed, Jun 19, 2013 at 2:02 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/ofp-parse.c|4 ++--
> > tests/ovs-ofctl.at |4 ++--
> > 2 files changed
On Tue, Jun 25, 2013 at 01:18:36AM -0700, Gurucharan Shetty wrote:
> The commit allows a user to add a database file to a
> ovsdb-server during run time. One can also remove a
> database file from ovsdb-server's control.
>
> Feature #14595.
> Signed-off-by: Gurucharan Shetty
I could see a number
On Fri, Jun 21, 2013 at 3:32 AM, James Page wrote:
> Hi OpenvSwitch Devs
>
> Ubuntu Saucy is about to bump kernel version from 3.9 to 3.10; I started
> looking at the impact of this on ovs but swiftly went down the rabbit hole
> of not really understanding how the introduction of 802.1ad support i
On Tue, Jun 25, 2013 at 4:35 AM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On May 7, 2013, at 21:55 , ext Pravin Shelar wrote:
>
>> On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme
>> wrote:
>>> This reduces repeated code and makes it easier to add new UDP tunneling
>>> protocols.
>>>
>> This
On Tue, Jun 25, 2013 at 12:38:32PM -0700, Ben Pfaff wrote:
> We can add a "bad meter" extension error very easily by editing
> ofp-errors.h. Feel free to use the Nicira extension namespace for
> this, or you could easily add a Nokia-Siemens extension namespace by
> adding a *_VENDOR_ID to openflow
>> insmod fails in my test VM:
> >>
> >> + insmod /cdrom/openvswitch.ko
> >> [ 13.017859] Disabling lock debugging due to kernel taint
> >> [ 13.018742] openvswitch: Unknown symbol gre_del_protocol (err 0)
> >> [ 13.019312] openvswitch: Unknown symbol gre_add_protocol (err 0)
On Tue, Jun 25, 2013 at 2:47 PM, Roam Pune wrote:
>
>
> On Mon, Jun 24, 2013 at 10:09 AM, Ben Pfaff wrote:
>>
>> [oops, sorry, re-sending because I screwed up the list address on the
>> first try]
>>
>> I'm getting the following warnings in my OVS master build tree (commit
>> ede77a461fb "datapat
On Tue, Jun 25, 2013 at 2:41 PM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 02:38:29PM -0700, Gurucharan Shetty wrote:
> > On Tue, Jun 25, 2013 at 2:18 PM, Ben Pfaff wrote:
> >
> > > On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote:
> > > > Currently, if we have just one databas
On Mon, Jun 24, 2013 at 10:09 AM, Ben Pfaff wrote:
> [oops, sorry, re-sending because I screwed up the list address on the
> first try]
>
> I'm getting the following warnings in my OVS master build tree (commit
> ede77a461fb "datapath: Fix a kernel crash caused by corrupted mask
> list."):
>
>
On Tue, Jun 25, 2013 at 02:38:29PM -0700, Gurucharan Shetty wrote:
> On Tue, Jun 25, 2013 at 2:18 PM, Ben Pfaff wrote:
>
> > On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote:
> > > Currently, if we have just one database, we can optionally skip the
> > > database name when provid
On Tue, Jun 25, 2013 at 2:16 PM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 01:02:30AM -0700, Gurucharan Shetty wrote:
> > An upcoming commit provides the ability to add and remove databases.
> > Having the databases in a shash instead of an array makes it easier
> > to add and remove databases.
On Tue, Jun 25, 2013 at 2:18 PM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote:
> > Currently, if we have just one database, we can optionally skip the
> > database name when providing the DB path for certain options (ex:
> > --remote=db:[db,]table,column).
Thanks for the answers. This is good enough. ;D
On Tue, Jun 25, 2013 at 2:25 PM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 02:14:49PM -0700, Alex Wang wrote:
> > But I still want to ask, what is the performance cost caused by using
> > vlan-splinter? Is that in that the using device driver can
looks good to me,
On Wed, Jun 19, 2013 at 2:02 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-parse.c|4 ++--
> tests/ovs-ofctl.at |4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
> index 1c5c761..fdec1
On Tue, Jun 25, 2013 at 02:14:49PM -0700, Alex Wang wrote:
> But I still want to ask, what is the performance cost caused by using
> vlan-splinter? Is that in that the using device driver can be faster than
> matching datapath flow?
Looking up the splinter ports, on input and output, in an extra h
On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote:
> Currently, if we have just one database, we can optionally skip the
> database name when providing the DB path for certain options (ex:
> --remote=db:[db,]table,column). But in case we have multiple databases,
> it is mandatory.
>
On Tue, Jun 25, 2013 at 01:02:30AM -0700, Gurucharan Shetty wrote:
> An upcoming commit provides the ability to add and remove databases.
> Having the databases in a shash instead of an array makes it easier
> to add and remove databases.
>
> Feature #14595.
> Signed-off-by: Gurucharan Shetty
ov
Thanks for writing these up. They look pretty good, thorough and easy
to follow. Comments below.
The first test fails on my system. Does it pass on yours against master?
I don't think we need to bother setting the datapath-id and the hwaddr
on all the bridges at creation time. I wouldn't both
Sorry Ben for the bugging,
But I still want to ask, what is the performance cost caused by using
vlan-splinter? Is that in that the using device driver can be faster than
matching datapath flow?
Thanks a lot ;D
___
dev mailing list
dev@openvswitch.org
h
On Tue, Jun 25, 2013 at 01:33:33PM -0700, Alex Wang wrote:
> Thanks Ben,
>
> I noticed that my third comment was wrong by experiment. The following is
> just a resend of my previous email with the code review:
>
> "
>
> > 3. The packets with vlan header are missed in kernel and examined in
> > "
Thanks, I went with that.
On Tue, Jun 25, 2013 at 01:09:47PM -0700, Ethan Jackson wrote:
> I like NAME_get_unsafe() personally.
>
> Thanks,
>
> Ethan
>
> On Tue, Jun 25, 2013 at 1:05 PM, Ben Pfaff wrote:
> > On Tue, Jun 25, 2013 at 12:56:09PM -0700, Ethan Jackson wrote:
> >> I don't really lik
Thanks Ben,
I noticed that my third comment was wrong by experiment. The following is
just a resend of my previous email with the code review:
"
> 3. The packets with vlan header are missed in kernel and examined in
> "ofproto/ofproto-dpif.c". The "vsp_vlandev_to_realdev()" and
> "vsp_realdev_to
On Mon, Jun 24, 2013 at 10:16:15PM -0700, Alex Wang wrote:
> On Mon, Jun 24, 2013 at 6:13 PM, Alex Wang wrote:
>
> > Thanks for the answers,
> >
> > On Mon, Jun 24, 2013 at 5:03 PM, Ben Pfaff wrote:
> >
> >> On Mon, Jun 24, 2013 at 03:56:31PM -0700, Alex Wang wrote:
> >> > 1. What is usually the
I like NAME_get_unsafe() personally.
Thanks,
Ethan
On Tue, Jun 25, 2013 at 1:05 PM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 12:56:09PM -0700, Ethan Jackson wrote:
>> I don't really like the names of the functions "NAME_get" and
>> "NAME_get__" could we come up with something that's a bit mo
On Tue, Jun 25, 2013 at 12:56:09PM -0700, Ethan Jackson wrote:
> I don't really like the names of the functions "NAME_get" and
> "NAME_get__" could we come up with something that's a bit more
> specific about the difference between them? Maybe get_init and get?
> I'm not sure what would be best .
On Tue, Jun 25, 2013 at 12:55:30PM -0700, Pavithra Ramesh wrote:
> Signed-off-by: Pavithra Ramesh
This isn't a full review, but: there are tons of [ignore]s in this
patch. It's best not to ignore output. Please try to remove as many
as you can.
___
de
I don't really like the names of the functions "NAME_get" and
"NAME_get__" could we come up with something that's a bit more
specific about the difference between them? Maybe get_init and get?
I'm not sure what would be best . . .
Acked-by: Ethan Jackson
On Mon, Jun 24, 2013 at 10:51 AM, Ben P
Signed-off-by: Pavithra Ramesh
---
tests/automake.mk |1 +
tests/bfd.at | 214
tests/testsuite.at |1 +
3 files changed, 216 insertions(+), 0 deletions(-)
create mode 100644 tests/bfd.at
diff --git a/tests/automake.mk b/tests/
On Thu, Jun 20, 2013 at 05:26:23PM +0300, Jarno Rajahalme wrote:
> Adds commands add-meter, mod-meter, del-meter, del-meters, dump-meter,
> dump-meters, meter-stats, and meter-features.
>
> Syntax is as follows:
>
> add-meter meter= (kbps|pktps) [burst] [stats] bands=
> type=(drop|dscp_remark)
On Tue, Jun 25, 2013 at 11:26:41AM -0700, Alex Wang wrote:
> Delete trailing whitespaces.
>
> Signed-off-by: Alex Wang
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jun 20, 2013 at 05:26:21PM +0300, Jarno Rajahalme wrote:
>
> Signed-off-by: Jarno Rajahalme
These patches seem OK as far as they go.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jun 20, 2013 at 05:26:19PM +0300, Jarno Rajahalme wrote:
>
> Signed-off-by: Jarno Rajahalme
I rebased this patch against master and resolved a bunch of conflicts
to come up with the appended patch.
I have some comments on this patch.
We can add a "bad meter" extension error very easily
Now that GRE support has been upstreamed into Linux, OVS is
using the components in the native kernel when available. However,
this means that it is now dependent on the appropriate kernel
config, which is CONFIG_NET_IPGRE_DEMUX on 2.6.37 and later.
Reported-by: Ben Pfaff
Signed-off-by: Jesse Gro
The Open vSwitch kernel module now has dependencies on symbols
exported by other kernel modules (currently just for GRE). In
order for it to load, the dependencies must be correctly resolved
ahead of time. This runs depmod as part of the module installation
process and updates the installation inst
>
> 3. The packets with vlan header are missed in kernel and examined in
> "ofproto/ofproto-dpif.c". The "vsp_vlandev_to_realdev()" and
> "vsp_realdev_to_vlandev()" are used to convert between "vlandev port" and
> "realdev port". And the performance cost is in that there is no datapath
> flow insta
Your message dated Tue, 25 Jun 2013 18:48:39 +
with message-id
and subject line Bug#714080: fixed in openvswitch 1.4.2+git20120612-9.1
has caused the Debian Bug report #714080,
regarding openvswitch-datapath-dkms: packet don't pass in postrouting iptables
table
to be marked as done.
This mea
Accepted:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.8
Date: Tue, 25 Jun 2013 09:52:45 +
Source: openvswitch
Binary: openvswitch-datapath-source openvswitch-datapath-dkms
openvswitch-common openvswitch-switch openvswitch-ipsec openvswitch-pki
openvswitch-controller openvswitc
On 06/26/2013 12:27 AM, Ben Pfaff wrote:
> I am currently working on a 1.9.x upload for sid. It's not ready
> (some lintian complaints that I agree with and want to fix). Would
> you prefer to get this fix through the above process before I upload,
> then?
Hi Ben,
Thanks a lot for the quick rep
openvswitch_1.4.2+git20120612-9.1_amd64.changes uploaded successfully to
localhost
along with the files:
openvswitch_1.4.2+git20120612-9.1.dsc
openvswitch_1.4.2+git20120612-9.1.debian.tar.gz
openvswitch-common_1.4.2+git20120612-9.1_amd64.deb
openvswitch-switch_1.4.2+git20120612-9.1_amd64.d
On Tue, Jun 25, 2013 at 9:21 AM, Andy Zhou wrote:
> OVS_ACTION_ATTR_USERSPACE action was sending the key from the matching
> flow. This works for exact match flows because flow keys are the
> same as packet keys. However, it does not work with wildcarded flows as
> the packet keys may be different
Hey Ben,
Seems I left this out.
On Tue, Jun 25, 2013 at 11:26 AM, Alex Wang wrote:
> Delete trailing whitespaces.
>
> Signed-off-by: Alex Wang
> ---
> build-aux/extract-ofp-errors |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build-aux/extract-ofp-errors b/build
Delete trailing whitespaces.
Signed-off-by: Alex Wang
---
build-aux/extract-ofp-errors |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors
index 6e86252..bffead4 100755
--- a/build-aux/extract-ofp-errors
+++ b/build-a
On Tue, Jun 25, 2013 at 10:27:53AM -0700, Alex Wang wrote:
> Thanks for the answers.
>
>
> On Tue, Jun 25, 2013 at 10:24 AM, Ben Pfaff wrote:
>
> > On Tue, Jun 25, 2013 at 10:22:41AM -0700, Alex Wang wrote:
> > > Looks good to me.
> > >
> > > Curious about what do OFPBAC and ONFBIC stand for?
>
Just sent v2 patch using OVS_CB for review.
On Tue, Jun 25, 2013 at 9:57 AM, Andy Zhou wrote:
> No, the patch was prepared before your email.
>
>
> On Tue, Jun 25, 2013 at 9:53 AM, Jesse Gross wrote:
>
>> On Tue, Jun 25, 2013 at 8:22 AM, Andy Zhou wrote:
>> > OVS_ACTION_ATTR_USERSPACE action
OVS_ACTION_ATTR_USERSPACE action was sending the key from the matching
flow. This works for exact match flows because flow keys are the
same as packet keys. However, it does not work with wildcarded flows as
the packet keys may be different than the flow keys. This patch uses
the packet keys carrie
On Mon, Jun 24, 2013 at 10:03 PM, Ben Pfaff wrote:
> On Mon, Jun 24, 2013 at 03:50:45PM -0700, Ansis Atteka wrote:
> > On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
> >
> > > Signed-off-by: Ben Pfaff
> > > ---
> > > lib/random.c | 26 +-
> > > 1 files changed, 17
On Thu, Jun 20, 2013 at 05:26:18PM +0300, Jarno Rajahalme wrote:
>
> Signed-off-by: Jarno Rajahalme
I'm applied this to master. I'm appending the incremental that I
folded in. Most of the changes are minor improvements (some just
stylistic). The only important change is that it looked to me l
Thanks for the answers.
On Tue, Jun 25, 2013 at 10:24 AM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 10:22:41AM -0700, Alex Wang wrote:
> > Looks good to me.
> >
> > Curious about what do OFPBAC and ONFBIC stand for?
>
> These come from the OpenFlow specification. Presumably they stand for
> "
On Tue, Jun 25, 2013 at 10:22:41AM -0700, Alex Wang wrote:
> Looks good to me.
>
> Curious about what do OFPBAC and ONFBIC stand for?
These come from the OpenFlow specification. Presumably they stand for
"OpenFlow Protocol Bad ACtion" and "Open Networking Foundation Bad
InstruCtion".
Thanks for
Looks good to me.
Curious about what do OFPBAC and ONFBIC stand for?
On Mon, Jun 24, 2013 at 1:58 PM, Ben Pfaff wrote:
> This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error
> code for duplicate instruction." It uses the error code proposed there.
>
> Signed-off-by: Ben Pfa
On Mon, Jun 24, 2013 at 1:58 PM, Ben Pfaff wrote:
> OpenFlow 1.2 standardized experimenter error codes in a way different from
> the Nicira extension. This commit implements the OpenFlow 1.2+ version.
>
> This commit also makes it easy to add error codes for new experimenter IDs
> by adding new
The commit allows a user to add a database file to a
ovsdb-server during run time. One can also remove a
database file from ovsdb-server's control.
Feature #14595.
Signed-off-by: Gurucharan Shetty
---
ovsdb/jsonrpc-server.c |9 ++
ovsdb/jsonrpc-server.h |2 +
ovsdb/ovsdb-server.1.in |
No, the patch was prepared before your email.
On Tue, Jun 25, 2013 at 9:53 AM, Jesse Gross wrote:
> On Tue, Jun 25, 2013 at 8:22 AM, Andy Zhou wrote:
> > OVS_ACTION_ATTR_USERSPACE action was sending the key from the matching
> > flow. This works for exact match flows because flow keys are the
On Tue, Jun 25, 2013 at 8:22 AM, Andy Zhou wrote:
> OVS_ACTION_ATTR_USERSPACE action was sending the key from the matching
> flow. This works for exact match flows because flow keys are the
> same as packet keys. However, it does not work with wildcarded flows as
> the packet keys may be different
Sorry for the delayed reply, Ben
I'm about to conduct a final review and then pass the patch. Thanks,
On Tue, Jun 25, 2013 at 9:10 AM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 08:32:34AM -0700, Alex Wang wrote:
> > > > > > "
> > > > > > oem = ofpbuf_put_uninit(buf, sizeof *oem);
> >
On Mon, Jun 24, 2013 at 2:30 PM, Ben Pfaff wrote:
> On Mon, Jun 24, 2013 at 01:39:15PM -0700, Gurucharan Shetty wrote:
> > On Mon, Jun 24, 2013 at 1:10 PM, Ben Pfaff wrote:
> >
> > > On Thu, Jun 20, 2013 at 07:38:48AM -0700, Gurucharan Shetty wrote:
> > > > The commit allows a user to add a data
An upcoming commit provides the ability to add and remove databases.
Having the databases in a shash instead of an array makes it easier
to add and remove databases.
Feature #14595.
Signed-off-by: Gurucharan Shetty
---
ovsdb/ovsdb-server.c | 186 +
The commit allows a user to add a database file to a
ovsdb-server during run time. One can also remove a
database file from ovsdb-server's control.
Feature #14595.
Signed-off-by: Gurucharan Shetty
---
ovsdb/jsonrpc-server.c |9 ++
ovsdb/jsonrpc-server.h |2 +
ovsdb/ovsdb-server.1.in |
Currently, if we have just one database, we can optionally skip the
database name when providing the DB path for certain options (ex:
--remote=db:[db,]table,column). But in case we have multiple databases,
it is mandatory.
With this commit, we make the database name mandatory. This provides
increa
OVS_ACTION_ATTR_USERSPACE action was sending the key from the matching
flow. This works for exact match flows because flow keys are the
same as packet keys. However, it does not work with wildcarded flows as
the packet keys may be different than the flow keys. This patch preserves
the packet keys a
On Tue, Jun 25, 2013 at 08:08:08AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Jun 25, 2013, at 1:22 , ext Ben Pfaff wrote:
>
> > What I really want to do is reconcile the two patch series, so that we
> > can get the best features from both. Your code is always solid in my
> > experi
On Tue, Jun 25, 2013 at 9:27 AM, Ben Pfaff wrote:
> On Tue, Jun 25, 2013 at 10:19:13PM +0800, Thomas Goirand wrote:
>> Hi Ben Pfaff, Jesse Gross, the release team, and others,
>>
>> Mehdi found out the upstream bug fix for this, and I incorporated it as
>> a patch for the Wheezy version. The patch
On Tue, Jun 25, 2013 at 10:19:13PM +0800, Thomas Goirand wrote:
> Hi Ben Pfaff, Jesse Gross, the release team, and others,
>
> Mehdi found out the upstream bug fix for this, and I incorporated it as
> a patch for the Wheezy version. The patch applied cleanly, and we have
> tested it, it really fix
On Mon, Jun 24, 2013 at 02:46:45PM -0700, Ansis Atteka wrote:
> On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
>
> > None of these test programs are threaded, but has little cost and means
> > that "grep" doesn't turn up any instances of these thread-unsafe functions
> > in our tree.
> >
> > S
On Tue, Jun 25, 2013 at 08:32:34AM -0700, Alex Wang wrote:
> > > > > "
> > > > > oem = ofpbuf_put_uninit(buf, sizeof *oem);
> > > > > oem->type = htons(NXET_VENDOR);
> > > > > "
> > > > >
> > > > > In the "ovs_hex_dump()" function which prints the encoded header, it
> > uses
> > > >
> > > > "
> > > > oem = ofpbuf_put_uninit(buf, sizeof *oem);
> > > > oem->type = htons(NXET_VENDOR);
> > > > "
> > > >
> > > > In the "ovs_hex_dump()" function which prints the encoded header, it
> uses
> > > > "fprintf(stream, "%02hhx"
> > > > to print it and the value is again in
Hi Ben Pfaff, Jesse Gross, the release team, and others,
Mehdi found out the upstream bug fix for this, and I incorporated it as
a patch for the Wheezy version. The patch applied cleanly, and we have
tested it, it really fixes the bug as we expected. We now use the
attached patch in production.
I
Package: openvswitch-datapath-dkms
Version: 1.4.2+git20120612-9
Severity: normal
Dear Maintainer,
The issue occur in a particular configuration:
* a openvswitch bridge with a ip set on the bridge
* a tap network interface with a ip configured inside a namespace
* and some iptables rules (ie: NAT
On May 7, 2013, at 21:55 , ext Pravin Shelar wrote:
> On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme
> wrote:
>> This reduces repeated code and makes it easier to add new UDP tunneling
>> protocols.
>>
> This approach is different from what tunnel upstream patches does.
> Since there is no li
Me too, on Debian 3.2.46-1 x86_64 GNU/Linux
Jarno
On Jun 24, 2013, at 20:09 , ext Ben Pfaff wrote:
> [oops, sorry, re-sending because I screwed up the list address on the
> first try]
>
> I'm getting the following warnings in my OVS master build tree (commit
> ede77a461fb "datapath: Fix a ke
I think the upstream kernel has a similar issue with tunneling.
I'm preparing a patch.
thanks,
On Tue, Jun 25, 2013 at 05:11:47PM +0900, Isaku Yamahata wrote:
> Reset skb->pkt_type when sending tunneled packets.
> Packet can have pkt_type of PACKET_OTHERHOST when coming to ovs bridge.
> If such p
Reset skb->pkt_type when sending tunneled packets.
Packet can have pkt_type of PACKET_OTHERHOST when coming to ovs bridge.
If such packets are handled by loopback device, the packet is dropped
by ip_rcv().
On the other hand when flow rule isn't installed in kernel datapath,
OVS_ACTION_ATTR_OUTPUT i
On Jun 25, 2013, at 1:22 , ext Ben Pfaff wrote:
> What I really want to do is reconcile the two patch series, so that we
> can get the best features from both. Your code is always solid in my
> experience, so I'm kind of inclined to just review yours and apply it,
> and then go through the Cente
80 matches
Mail list logo
