On Mon, Jun 24, 2013 at 1:58 PM, Ben Pfaff <b...@nicira.com> wrote: > OpenFlow 1.2 standardized experimenter error codes in a way different from > the Nicira extension. This commit implements the OpenFlow 1.2+ version. > > This commit also makes it easy to add error codes for new experimenter IDs > by adding new *_VENDOR_ID definitions to openflow-common.h. > > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > v3->v4: Remove unneeded check in extract-ofp-errors. Remove bad > change to ofp-actions.at test. > > OPENFLOW-1.1+ | 3 - > build-aux/extract-ofp-errors | 321 > +++++++++++++++++++++--------------- > include/openflow/nicira-ext.h | 1 - > include/openflow/openflow-1.2.h | 5 +- > include/openflow/openflow-common.h | 25 +++- > lib/automake.mk | 7 +- > lib/ofp-errors.c | 72 ++++++--- > lib/ofp-errors.h | 89 ++++++---- > tests/ofp-errors.at | 51 +++++- > utilities/ovs-ofctl.c | 15 +- > 10 files changed, 376 insertions(+), 213 deletions(-) > > + > + vendor_map[name] = id_ > + vendor_loc[name] = "%s:%d" % (fileName, lineNumber) > + > + >
I saw unnecessary trailing whitespaces here. Apart from that, it all looks good to me. Thanks,
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
