On Tue, Jun 25, 2013 at 2:41 PM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Jun 25, 2013 at 02:38:29PM -0700, Gurucharan Shetty wrote: > > On Tue, Jun 25, 2013 at 2:18 PM, Ben Pfaff <b...@nicira.com> wrote: > > > > > On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote: > > > > Currently, if we have just one database, we can optionally skip the > > > > database name when providing the DB path for certain options (ex: > > > > --remote=db:[db,]table,column). But in case we have multiple > databases, > > > > it is mandatory. > > > > > > > > With this commit, we make the database name mandatory. This provides > > > > increased flexibility for an upcoming commit that provides the > ability > > > > to add and remove databases during run time. > > > > > > > > Feature #14595. > > > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> > > > > > > Please mention this change in NEWS also. > > > > > Does this look fine? > > > > diff --git a/NEWS b/NEWS > > index aae3378..fadd9dd 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -7,7 +7,9 @@ post-v1.11.0 > > - New "check-oftest" Makefile target for running OFTest against Open > > vSwitch. See README-OFTest for details. > > - The flow eviction threshold has been moved to the Open_vSwitch > table. > > - > > + - Database names are now mandatory when specifying ovsdb-server > options > > + through database paths(ex: Private key option with the database > name > > + should look like "--private-key=db:Open_vSwitch,SSL,private_key"). > > It looks like you deleted a blank line. We try to keep two blank > lines between the notes for different versions. > Okay. I saw a single blank line between v1.11.0 and v1.10.0 and followed the same. I will add the extra line.
> Instead of "paths(ex: ", can you write "paths (e.g. "? This is the > style we use other places. > Will do. > > Thanks, > > Ben. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
