Simon,
I think 8848 is not for MPLS multicast. With RFC5332, 8848 is to be used when
top label is upstream assigned label.
-Nagendra
-Original Message-
From: dev-boun...@openvswitch.org [mailto:dev-boun...@openvswitch.org] On
Behalf Of Simon Horman
Sent: Wednesday, May 29, 2013 11:37 A
This moves generic action execution code out of lib/dpif-netedev.c
and into a new file, lib/execute-actions.c.
This is in preparation for using execute_set_action()
in lib/odp-util.c to handle recirculation/
Signed-off-by: Simon Horman
---
v10
* As suggested by Ben Pfaff
- Rename lib/execute-a
Recirculation is a technique to allow a frame to re-enter
frame processing. This is intended to be used after actions
have been applied to the frame with modify the frame in
some way that makes it possible for richer processing to occur.
An example is and indeed targeted use case is MPLS. If an MP
Add set skb_mark support to execute_set_action.
This also adds support for the user-space datapath
to honour such actions if they occur before recirculation,
which will be added by a subsequent patch.
This is in preparation for using execute_set_action()
to handle recirculation.
Signed-off-by: Si
Now that execute_actions() is available it can be used as a generic
replacement for special-case action execution in
execute_controller_action().
As suggested by Jesse Gross.
Signed-off-by: Simon Horman
---
v10
* As suggested by Ben Pfaff
- use {} with if statement for OVS_ACTION_ATTR_OUTPUT i
The ethertype should always be updated on mpls_pop
as there may be a transition between MPLS unicast (0x8847) and
MPLS multicast (0x8848).
Ben Pfaff tells me that this is consistent with the
behaviour described in EXT-194 of the JIRA bug tracker.
Signed-off-by: Simon Horman
---
v11
* Include i
On Mon, May 27, 2013 at 10:51:31PM -0700, David Miller wrote:
> From: Simon Horman
> Date: Fri, 24 May 2013 16:02:50 +0900
>
> > In the case where a non-MPLS packet is received and an MPLS stack is
> > added it may well be the case that the original skb is GSO but the
> > NIC used for transmit do
Reported-by: Maxime Brun
Signed-off-by: Gurucharan Shetty
---
AUTHORS|1 +
debian/openvswitch-controller.init |8 +---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 498e9f0..d15173e 100644
--- a/AUTHORS
+++ b/AUTHOR
On Tue, May 28, 2013 at 12:17:39PM -0700, Neil Mckee wrote:
> It would be helpful if ovs-vsctl(1) had a way to write out the
> netdev ifIndex numbers, where applicable, of the bridge ports. This
> would help to harmonize integration with SNMP, sFlow, LLDP and more.
>
> Could it be an extra column
I made a few comments on v2 that came late and didn't make it into
v3. But I'm happy with v3 otherwise.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 28, 2013 at 02:36:04PM -0700, Ethan Jackson wrote:
> Suggested-by: Ben Pfaff
> Signed-off-by: Ethan Jackson
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 28, 2013 at 02:36:08PM -0700, Ethan Jackson wrote:
> It's no longer possible for a single datapath flow to be slow
> pathed for two different reasons. This patch updates the code to
> reflect this fact (marginally simplifying it).
>
> Signed-off-by: Ethan Jackson
Looks good, thanks.
Applied to master. Thank you.
Ethan
On Tue, May 28, 2013 at 2:35 PM, Pavithra Ramesh wrote:
> Invoke the function to reconfigure BFD when a port/interface
> is deleted.
>
> Signed-off-by: Pavithra Ramesh
> ---
> lib/bfd.c |5 +++--
> ofproto/ofproto-dpif.c |2 ++
> 2 file
On Tue, May 28, 2013 at 03:56:58PM -0700, Gurucharan Shetty wrote:
> On Mon, May 20, 2013 at 11:00 AM, Ben Pfaff wrote:
>
> > On Mon, May 20, 2013 at 06:53:14AM +, Gurucharan Shetty wrote:
> > > This commit provides an option to enable or disable packet processing
> > > coming from the datapa
The reserved multicast Ethernet addresses begin with 01:80:c2, not
01:08:c2.
Reported-by: Padmanabhan Krishnan
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
lib/packets.c | 32
tutorial/Tutorial | 12 ++--
tutorial/t-stage0 |2 +-
It has been observed that when we upgrade openvswitch with
thousands of openflow flows already established and there is heavy
traffic going through the switch, restoring flows can take a very
long time (8 minutes in one use case) with CPU running at 100%.
This can make the upgrade very expensive.
Currently we are adding the manager after starting ovs-vswitchd.
Instead, add the manager after flow restore is completed.
Bug #16086.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-ctl.in | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/ut
While upgrading openvswitch, it helps to restore openflow flows before
starting packet processing. Typically we want to restart openvswitch,
add the openflow flows and then start packet processing.
To do this, we look for the other_config:flow-restore-wait column
in the Open_vSwitch table during
On Mon, May 20, 2013 at 11:00 AM, Ben Pfaff wrote:
> On Mon, May 20, 2013 at 06:53:14AM +, Gurucharan Shetty wrote:
> > This commit provides an option to enable or disable packet processing
> > coming from the datapath.
> >
> > This option is useful during Open vSwitch upgrades. Typically we
Thank you for the reviews. I pushed this to master.
On Tue, May 28, 2013 at 03:18:09PM -0700, Alex Wang wrote:
> And the previous email marks the completion of review of this series of
> patches. Thanks.
>
>
> On Tue, May 28, 2013 at 3:16 PM, Alex Wang wrote:
>
> > This patch looks good to me
On Thu, May 23, 2013 at 05:15:20PM -0700, Ethan Jackson wrote:
> This patch implements a new interface to xlate_actions which, aside
> from being simpler and more intuitive, achieves several goals. It
> pulls all of xlate_actions() results into a single structure which
> will be easier to cache an
And the previous email marks the completion of review of this series of
patches. Thanks.
On Tue, May 28, 2013 at 3:16 PM, Alex Wang wrote:
> This patch looks good to me.
>
>
> On Tue, May 28, 2013 at 11:50 AM, Alex Wang wrote:
>
>> Thanks Ben, the README is clear to me.
>>
>> I'll play with th
This patch looks good to me.
On Tue, May 28, 2013 at 11:50 AM, Alex Wang wrote:
> Thanks Ben, the README is clear to me.
>
> I'll play with the oftest more and finish all review.
>
>
> On Tue, May 28, 2013 at 11:44 AM, Ben Pfaff wrote:
>
>> On Fri, May 17, 2013 at 03:23:50PM -0700, Ben Pfaff w
This patch changes the name of action_xlate_ctx to xlate_ctx. Aside
from being a bit snappier, it fits more cleanly with structures
added in future patches.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif.c | 187
1 file changed, 92 inserti
Upon close inspection, it appears that it's not possible for
actions to differ between subfacets belonging to a given facet.
Given this fact, it makes sense to move datapath actions from
subfacets to their parent facets. It's both conceptually more
straightforward, and necessary for future threadi
Used in future commits.
Signed-off-by: Ethan Jackson
---
lib/ofpbuf.h |6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
index 8b03c7e..0c12162 100644
--- a/lib/ofpbuf.h
+++ b/lib/ofpbuf.h
@@ -107,6 +107,12 @@ static inline struct ofpbuf *ofpbuf_from_list(co
Before this patch, when in band control was enabled, every DHCP
packet had to be sent to userspace to calculate it's actions.
Those DHCP packets intended for the local port would have a special
action added to ensure they actually make it there. This
unnecessarily complicates the code, so this pat
It's no longer possible for a single datapath flow to be slow
pathed for two different reasons. This patch updates the code to
reflect this fact (marginally simplifying it).
Signed-off-by: Ethan Jackson
---
lib/odp-util.c | 53 +++-
lib/odp-
Before this patch, datapath keys with ODP_FIT_TO_LITTLE, would be
assigned subfacets and installed in the kernel with a SLOW_MATCH
slow path reason. This is problematic, because these flow keys
can't be reliable converted into a 'struct flow' thus breaking a
fundamental assumption of ofproto-dpif.
Suggested-by: Ben Pfaff
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index b547298..22544f1 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofpro
> There's something funny going on with rule_dpif_lookup() calls here.
> handle_flow_miss() calls rule_dpif_lookup(). It only uses it in the
> handle_flow_miss_without_facet() case, and only to pass it to
> handle_flow_miss_without_facet(). In the
> handle_flow_miss_with_facet() case, it still ca
>> subfacet_make_actions() was previously used such that it composed its
>> actions into an on-stack buffer, then made a copy of that buffer into
>> an exact-sized dynamically allocated buffer. Now, it uses a 0-sized
>> dynamically allocated buffer. I think this will cause multiple
>> realloc() c
On Fri, May 24, 2013 at 05:01:34PM -0700, Jesse Gross wrote:
> Originally no rule existed for packets that did not match an
> OpenFlow flow and therefore every packet with a rule could be
> counted as a hit. However, newer versions of OVS have hidden
> miss rules so this is no longer true. To retur
On Tue, May 28, 2013 at 02:08:05PM -0700, Alex Wang wrote:
> This patch looks good to me.
Thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This patch looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, May 25, 2013 at 03:44:39PM -0500, Ethan Jackson wrote:
> > I think the "if" test here cannot ever be true, because the loop
> > un-set all of the bits in 'slow'. (I think that this was also the
> > case before the patch.) Perhaps we should just delete it.
>
> I've removed it from the pat
When the OFPC_FRAG_DROP policy is in effect, IP fragments are supposed to
be dropped before they reach the flow table. Open vSwitch properly dropped
IP fragments in this case, but still accounted them to the packet and byte
counters for the flow that they would have hit if the OFPC_FRAG_NX_MATCh
p
Invoke the function to reconfigure BFD when a port/interface
is deleted.
Signed-off-by: Pavithra Ramesh
---
lib/bfd.c |5 +++--
ofproto/ofproto-dpif.c |2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/bfd.c b/lib/bfd.c
index 95dad2d..761c91c 100644
--
One more thing I forgot to mention in the previous round. All patches
need a Signed-off-by in the commit message which roughly states that
you realize this is going to an open source project, and you have the
right to submit the code (see "SubmittingPatches" for a detailed
explanation). If you co
Hello All,
It would be helpful if ovs-vsctl(1) had a way to write out the netdev ifIndex
numbers, where applicable, of the bridge ports.This would help to
harmonize integration with SNMP, sFlow, LLDP and more.
Could it be an extra column in the output from "ovs-vsctl list Port" ? Or a
k
Thanks Ben, the README is clear to me.
I'll play with the oftest more and finish all review.
On Tue, May 28, 2013 at 11:44 AM, Ben Pfaff wrote:
> On Fri, May 17, 2013 at 03:23:50PM -0700, Ben Pfaff wrote:
> > +Second, obtain a copy of OFTest and install its prerequisites. You
> > +need a copy
On Mon, May 27, 2013 at 04:54:54AM -0700, Lorand Jakab wrote:
> Since commit 0ad90c8 it is possible to set tunnel destination IP address
> in the flow. This allows creating a LISP "map-cache" in the flow table.
> Update the LISP documentation to reflect these possibilities.
>
> Signed-off-by: Lor
Invoke the function to reconfigure BFD when a port/interface
is deleted.
---
lib/bfd.c |5 +++--
ofproto/ofproto-dpif.c |2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/bfd.c b/lib/bfd.c
index 95dad2d..761c91c 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@
On Fri, May 17, 2013 at 03:23:50PM -0700, Ben Pfaff wrote:
> +Second, obtain a copy of OFTest and install its prerequisites. You
> +need a copy of OFTest that includes this commit available at
> +https://github.com/blp/oftest/commits/master:
> +
> +commit 406614846c5eae01f0eb460a9f107e7ed60492
On Tue, May 28, 2013 at 10:30:38AM -0700, Alex Wang wrote:
> The first three patches all look good to me.
>
> Just one comment, you forgot to delete the declaration and initialization
> of 'n_listeners' in function "netdev_dummy_receive".
Thanks, I've removed those now.
__
On Fri, May 17, 2013 at 3:23 PM, Ben Pfaff wrote:
> Ethan pointed out that this wasn't very useful.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-dummy.c| 16 +++-
> tests/ofproto-dpif.at | 24
> 2 files changed, 11 insertions(+), 29 deletions(-)
>
On Thu, May 23, 2013 at 11:12 PM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
> Pravin,
>
> Please find some review comments below,
Thanks for comments.
>
> Jarno
>
> On May 23, 2013, at 23:01 , ext Pravin B Shelar wrote:
> ...
>> diff --git a/datapath/linux/compat/gre.c b/datapath/linux/compat/g
Looks good to me. If you would, please add a period to the end of the
first line in the commit message, and update the comment of
bfd_configure() to mention that NULL is an acceptable value for 'cfg'.
Once that's done, I'll merge.
Thanks,
Ethan
On Thu, May 23, 2013 at 7:31 PM, Pavithra Ramesh
On Fri, May 24, 2013 at 06:51:20PM -0700, Justin Pettit wrote:
> On May 23, 2013, at 3:51 PM, Ben Pfaff wrote:
>
> > +Open vSwitch maintain a separate set of 256 packet buffers for each
>
> I know you pushed it, but it should be "maintains".
OK, I pushed a fix as follows.
--8<-
On Tue, May 28, 2013 at 09:09:08AM -0700, Justin Pettit wrote:
> It looks like "xenserver/etc_profile.d_openvswitch.sh" is broken in
> how it tries to handle "ovs-dpctl show" output. Unless you want to
> jump on it, I'll look at it later this week.
It's all yours.
On May 28, 2013, at 9:05 AM, Ben Pfaff wrote:
> On Tue, May 28, 2013 at 03:50:25PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>>When i played with OVS again today, i found that the argument
>> of "ovs-dpctl show" is not correct, so INSTALL.KVM need to be
>> updated accordin
On Tue, May 28, 2013 at 03:50:25PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> When i played with OVS again today, i found that the argument
> of "ovs-dpctl show" is not correct, so INSTALL.KVM need to be
> updated accordingly.
>
> Signed-off-by: Zhi Yong Wu
Applied to maste
Package: openvswitch
Version: 1.4.2+git20120612-9
Severity: important
# dkms install -m openvswitch -v 1.4.2+git20120612 -k 3.8-2-amd64
Kernel preparation unnecessary for this kernel. Skipping...
Building module:
cleaning build area(bad exit status: 2)
../configure --with-linux='/lib/module
From: Zhi Yong Wu
When i played with OVS again today, i found that the argument
of "ovs-dpctl show" is not correct, so INSTALL.KVM need to be
updated accordingly.
Signed-off-by: Zhi Yong Wu
---
INSTALL.KVM |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/INSTALL.KV
OK, let me send v2
On Tue, May 28, 2013 at 3:42 PM, Justin Pettit wrote:
> Thanks for catching that. The argument is actually optional. Would you
> mind respinning the patch to not specify "ovs-system"?
>
> --Justin
>
>
> On May 28, 2013, at 12:37 AM, zwu.ker...@gmail.com wrote:
>
> > From: Z
Thanks for catching that. The argument is actually optional. Would you mind
respinning the patch to not specify "ovs-system"?
--Justin
On May 28, 2013, at 12:37 AM, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> When i played with OVS again today, i found that the syntax
> of "ovs-dp
From: Zhi Yong Wu
When i played with OVS again today, i found that the syntax
of "ovs-dpctl show" was changed, so INSTALL.KVM need to be
updated accordingly.
Signed-off-by: Zhi Yong Wu
---
INSTALL.KVM |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/INSTALL.KVM b/INS
57 matches
Mail list logo
