On Thu, May 23, 2013 at 05:15:20PM -0700, Ethan Jackson wrote: > This patch implements a new interface to xlate_actions which, aside > from being simpler and more intuitive, achieves several goals. It > pulls all of xlate_actions() results into a single structure which > will be easier to cache and pass around in future. And it shields > xlate_ctx from the rest of the code, making it possible to factor > xlate_actions() in the future (hopefully). > > Signed-off-by: Ethan Jackson <et...@nicira.com>
struct xlate_in has a pointer to struct initial_vals whereas xlate_action_ctx has an instance of it. initial_vals is tiny (only 16 bits) and it hardly seems the risk of getting a stale pointer for whatever reason. Otherwise this looks good to me. It was hard to pick out the bits that aren't basically search-and-replace, though, so if there is anything I should scrutinize, please point it out. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
