This patch looks good to me.
On Tue, May 28, 2013 at 11:50 AM, Alex Wang <al...@nicira.com> wrote: > Thanks Ben, the README is clear to me. > > I'll play with the oftest more and finish all review. > > > On Tue, May 28, 2013 at 11:44 AM, Ben Pfaff <b...@nicira.com> wrote: > >> On Fri, May 17, 2013 at 03:23:50PM -0700, Ben Pfaff wrote: >> > +Second, obtain a copy of OFTest and install its prerequisites. You >> > +need a copy of OFTest that includes this commit available at >> > +https://github.com/blp/oftest/commits/master: >> > + >> > + commit 406614846c5eae01f0eb460a9f107e7ed604924f >> > + Author: Ben Pfaff <b...@nicira.com> >> > + >> > + make ovs-dummy platform work again >> > + >> > + Commit e1b8da9 (dataplane: single-threaded rewrite) changed the >> > + DataPlanePort required interface but it did not update the >> ovs-dummy >> > + implementation to match. This commit makes the platform work >> again. >> >> This makes it sound as though it's necessary to get that commit >> specifically. It's not (anymore), because it has been merged into the >> upstream repo. Here's some better text that I've substituted locally: >> >> Second, obtain a copy of OFTest and install its prerequisites. You >> need a copy of OFTest that includes commit 406614846c5 (make ovs-dummy >> platform work again). This commit was merged into the OFTest >> repository on Feb 1, 2013, so any copy of OFTest more recent than that >> should work. >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev >> > >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
