On Thu, May 02, 2013 at 08:20:52PM -0700, Jesse Gross wrote:
> On Thu, May 2, 2013 at 1:30 PM, Andy Zhou wrote:
> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > index e890fd8..6048e9b 100644
> > --- a/include/linux/openvswitch.h
> > +++ b/include/linux/openvswitch.h
>
On Thu, May 2, 2013 at 1:30 PM, Andy Zhou wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index e890fd8..6048e9b 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -287,6 +313,8 @@ enum ovs_key_attr {
> OVS_KEY_ATTR_IPV4_TU
Thanks!
If that was a question to me, then yes, I think it would be good to fix this
on branch 1.10 too. The old code resulted in ifIndex==-95 being offered to
the sFlow module for traffic from a non-ifindex-port. -95 being the -errno
that the netdev replies with to indicate that it doesn't
On Thu, May 02, 2013 at 09:53:25AM -0700, Jesse Gross wrote:
> On Wed, May 1, 2013 at 10:31 PM, Simon Horman wrote:
> > On Wed, May 01, 2013 at 09:53:42PM -0700, Jesse Gross wrote:
> >> On Wed, May 1, 2013 at 3:57 PM, Simon Horman wrote:
> >> > On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gros
On Thu, May 02, 2013 at 12:56:37PM -0700, Ben Pfaff wrote:
> I made the following comment on v1, did you do anything about it?
>
> > Also, the action parser in ofp-actions.def rejects any pop_mpls action
> > with an MPLS ethertype attached, in two places. We should fix that.
Sorry for not being
strftime() returns 0 and leaves the contents of the output buffer
unspecified if the output buffer is not big enough. Thus, one should
check strftime()'s return value. Until now, OVS has had a few invocations
of strftime() that did not check the return value. This commit fixes
those. I believe
Before this patch, stats for 'facet->rule' were handled differently
than stats which 'facet' resubmitted into. The former were
maintained in 'facet' until it was destroyed, while the latter were
pushed regularly in facet_push_stats().
This inconsistent behavior was not only confusing, it was ofte
Thanks for the review. I applied this to master.
None of the unchecked uses of strftime() in the tree looks very risky
to me, but you're right that it would be better to check. I'll work
on that.
Thanks,
Ben.
On Thu, May 02, 2013 at 03:02:36PM -0700, Andy Zhou wrote:
> Looks good with the cha
On Mon, Apr 29, 2013 at 02:42:56PM -0700, Andy Zhou wrote:
> Add fflush() to the 'rate' command of 'ovs-benchmark'. On a tty console
> the output is line-buffered. However, piped output by default has a
> deeper (usually 4KB) buffer, the output won't appear to the other end of
> the pipe until thi
Looks good with the changes. I am a bit uncomfortable with places where
strftime() return value is not checked. They are there in the original
code, not strictly related to this change.
On Wed, May 1, 2013 at 11:29 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dynamic-string.c
Thanks for noticing that. I changed gethostname() to getaddrinfo() in
the comment and I'll push this soon (unless the comment needs some
other change?).
On Thu, May 02, 2013 at 02:08:52PM -0700, Andy Zhou wrote:
> Looks good. The comment above lookup_hostname() mentioned gethostbyname()
> may ne
Thank you, I applied this to master.
On Thu, May 02, 2013 at 01:43:28PM -0700, Andy Zhou wrote:
> Looks good.
>
>
> On Wed, May 1, 2013 at 11:38 AM, Ben Pfaff wrote:
>
> > POSIX says that multithreaded programs must not use sigprocmask() but must
> > use pthread_sigmask() instead. This commit
OVS_KEY_ATTR_MEGA may not be strictly required in the end, but it makes the
of ovs-dpctl changes easier.
I will try to remove it in the next few commits.
On Thu, May 2, 2013 at 1:35 PM, Ben Pfaff wrote:
> On Thu, May 02, 2013 at 01:30:05PM -0700, Andy Zhou wrote:
> > +/**
> > + * enum ovs_mask
Looks good.
On Wed, May 1, 2013 at 11:38 AM, Ben Pfaff wrote:
> POSIX says that multithreaded programs must not use sigprocmask() but must
> use pthread_sigmask() instead. This commit makes that replacement.
>
> The actual use of signals in Open vSwitch is still not thread safe
> following thi
On Thu, May 02, 2013 at 01:30:05PM -0700, Andy Zhou wrote:
> +/**
> + * enum ovs_mask_attr - attributes for %OVS_KEY_ATTR_MASK.
> + * @OVS_MASK_ATTR_TYPE: The %OVS_KEY_ATTR_* whose value is matched with a
> mask.
> + * Attributes that nested attributes may not be masked; specify masks on the
s/th
This patch introduces new fields in openvswitch.h for mega flow. It
is prerequisite for both kernel and user space mega flow changes.
Signed-off-by: Andy Zhou
---
include/linux/openvswitch.h | 33 +
1 file changed, 33 insertions(+)
diff --git a/include/linux/op
I made the following comment on v1, did you do anything about it?
> Also, the action parser in ofp-actions.def rejects any pop_mpls action
> with an MPLS ethertype attached, in two places. We should fix that.
Thanks,
Ben.
On Thu, May 02, 2013 at 01:26:38PM +0900, Simon Horman wrote:
> The ethe
Applied to master and branch-1.11, thanks. Do we need this on
branch-1.10 also?
On Tue, Apr 30, 2013 at 10:38:53PM -0700, Neil Mckee wrote:
> I learned how to squash patches...
>
> Change sFlow model to reflect per-bridge sampling. Before we were presenting
> a separate
> sFlow data-source (sa
This patch refactors the netlink flow handling code to make
the processing, error checking and prerequisite checking
more stream lined.
Signed-off-by: Andy Zhou
---
datapath/datapath.c | 44 +++-
datapath/flow.c | 652 ---
datapath/flow.h
On Thu, May 2, 2013 at 10:38 AM, Pravin Shelar wrote:
> On Thu, May 2, 2013 at 10:20 AM, Jesse Gross wrote:
>> It is an error to try to change the type of a vport using the set
>> command. However, while we check that this is an error, we still
>> proceed to allocate memory which then gets freed
There has been a lot of discussion on patch 4. Do you plan to update
and re-send the series, or do you expect further discussion or review
of the rest of the series before we go on?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
On Tue, Apr 30, 2013 at 05:21:28AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
>
> > On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
> > wrote:
> >>
> >> Another thing that I came to think only when reading Ben's ne
On Mon, Apr 29, 2013 at 10:49:35AM -0700, Jesse Gross wrote:
> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
> > Another thing that I came to think only when reading Ben's new tutorial:
> > Output to the input port is skipped. This would be a problem if you only
> >
These seem slightly nicer than e.g. htons(UINT16_MAX).
Signed-off-by: Ben Pfaff
---
include/openvswitch/types.h |6 +-
lib/match.c | 30 +++---
lib/meta-flow.c | 11 +--
lib/nx-match.c |8
lib/ofp-a
On Thu, May 2, 2013 at 10:20 AM, Jesse Gross wrote:
> It is an error to try to change the type of a vport using the set
> command. However, while we check that this is an error, we still
> proceed to allocate memory which then gets freed immediately.
> This stops processing after noticing the erro
I applied it. Please try it out. After some time without new
reported problems I guess we should release 1.4.7.
On Tue, Apr 30, 2013 at 10:14:04AM +0100, Zoltan Kiss wrote:
> Hi,
>
> Just a reminder, in case this patch fell off the radar: please
> review it sometime.
>
> Regards,
>
> Zoli
>
Thanks, applied to branch-1.4.
At the same time, I noticed that I had forgotten to tag 1.4.6, so I
did that too.
On Wed, May 01, 2013 at 09:55:58AM -0700, Justin Pettit wrote:
> The code's tricky, but I looked over it a couple of times, and it
> looks reasonable to me.
>
> Thanks,
>
> --Justin
It is an error to try to change the type of a vport using the set
command. However, while we check that this is an error, we still
proceed to allocate memory which then gets freed immediately.
This stops processing after noticing the error, which does not
actually fix a bug but is more correct.
Si
Thanks, I applied this to master, branch-1.10, branch-1.11.
On Thu, May 02, 2013 at 09:44:03AM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On May 1, 2013, at 5:15 PM, Ben Pfaff wrote:
>
> > When ovs-vswitchd deletes a port with dpif_linux_port_del(), that function
> > uses de
On Thu, May 2, 2013 at 12:59 AM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 30, 2013, at 18:54 , ext Jesse Gross wrote:
>
>> On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo)
>> wrote:
>>>
>>> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
>>>
On Sun, Apr 28, 2
Thanks, applied.
On Wed, May 01, 2013 at 11:42:49PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On May 1, 2013, at 5:13 PM, Ben Pfaff wrote:
>
> > MAX_PORTS is currently USHRT_MAX (also 65535). I think that's a
> > coincidence; I don't remember MAX_PORTS being mentioned when
On Wed, May 1, 2013 at 10:31 PM, Simon Horman wrote:
> On Wed, May 01, 2013 at 09:53:42PM -0700, Jesse Gross wrote:
>> On Wed, May 1, 2013 at 3:57 PM, Simon Horman wrote:
>> > On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gross wrote:
>> >> On Wed, May 1, 2013 at 12:50 AM, Simon Horman wrote:
Looks good.
--Justin
On May 1, 2013, at 5:15 PM, Ben Pfaff wrote:
> These helpers simplify new code to be added in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-linux.c | 46 +-
> 1 files changed, 33 insertions(+), 13 deletions
Looks good.
--Justin
On May 1, 2013, at 5:15 PM, Ben Pfaff wrote:
> When ovs-vswitchd deletes a port with dpif_linux_port_del(), that function
> uses del_channel() to delete the corresponding channel, including closing
> its Netlink socket fd. However, if the vport gets removed by some other
On May 2, 2013, at 9:12 AM, Justin Pettit wrote:
> By the way, would you mind pushing the tags for the 1.10.0 release?
Ugh. It looks like you did. I don't see it in my git repo for some reason.
I'll check.
--Justin
___
dev mailing list
dev@openv
On May 2, 2013, at 8:59 AM, Ben Pfaff wrote:
> On Thu, May 02, 2013 at 12:16:19AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Looks good, thanks.
Thanks. I pushed it to master.
By the way, would you mind pushing the tags for the 1.10.0 release?
--Justin
__
On Thu, May 02, 2013 at 12:16:19AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 02/05/13 17:32, steve_1...@hushmail.com wrote:
> On Thu, May 2, 2013 at 11:17 AM, Roger Pau Monné wrote:
>> On 02/05/13 17:09, agya naila wrote:
>>> Does any one have test this script performance with Xen live migration?
>>> what is the performance result compared with brctl. I hope any body wa
On Thu, May 2, 2013 at 11:17 AM, Roger Pau Monné wrote:
> On 02/05/13 17:09, agya naila wrote:
>> Does any one have test this script performance with Xen live migration?
>> what is the performance result compared with brctl. I hope any body want
>> to share it. I want to use this script with my Xe
On Thu, May 2, 2013 at 5:18 PM, Ian Campbell wrote:
> On Thu, 2013-05-02 at 16:17 +0100, Roger Pau Monne wrote:
> > On 02/05/13 17:09, agya naila wrote:
> > > Does any one have test this script performance with Xen live migration?
> > > what is the performance result compared with brctl. I hope an
On Thu, 2013-05-02 at 16:17 +0100, Roger Pau Monne wrote:
> On 02/05/13 17:09, agya naila wrote:
> > Does any one have test this script performance with Xen live migration?
> > what is the performance result compared with brctl. I hope any body want
> > to share it. I want to use this script with m
On 02/05/13 17:09, agya naila wrote:
> Does any one have test this script performance with Xen live migration?
> what is the performance result compared with brctl. I hope any body want
> to share it. I want to use this script with my Xen 4.2.1 using xend/xm
> toostack.
I have not tried it myself,
Does any one have test this script performance with Xen live migration?
what is the performance result compared with brctl. I hope any body want to
share it. I want to use this script with my Xen 4.2.1 using xend/xm
toostack.
Best Regards,
Agya
On Wed, Apr 24, 2013 at 1:57 PM, Ian Campbell wrot
On Thu, May 02, 2013 at 02:31:44PM +0900, Simon Horman wrote:
> On Wed, May 01, 2013 at 09:53:42PM -0700, Jesse Gross wrote:
> > On Wed, May 1, 2013 at 3:57 PM, Simon Horman wrote:
> > > On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gross wrote:
> > >> On Wed, May 1, 2013 at 12:50 AM, Simon Horm
Update handling of the following actions to use the dl_type set by MPLS
push and pop actions if it differs from the original dl_type. This is
consistent with the existing checking of load actions and allows
their existing checks to enforce dl_type pre-requisites correctly.
output_reg
Do not perform validation of learn actions during parsing.
I believe this is consistent with the handling of all other actions.
Verification of all actions, including learn actions, occurs separately
in ofpact_check__().
This the code portion of this patch is larger than might otherwise be
expect
On Apr 30, 2013, at 18:54 , ext Jesse Gross wrote:
> On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
>>
>> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
>>
>>> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
>>> wrote:
Another t
Signed-off-by: Justin Pettit
---
FAQ |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/FAQ b/FAQ
index 6d260aa..1f0f841 100644
--- a/FAQ
+++ b/FAQ
@@ -126,7 +126,7 @@ A: All official releases have been through a comprehensive
testing
LTS release, we will provide an up
48 matches
Mail list logo
