Re: [ovs-dev] [PATCH 2/2] Prepare for post-1.10.0 (1.10.90).

2013-02-04 Thread Justin Pettit
On Feb 4, 2013, at 10:03 PM, Ben Pfaff wrote: > On Mon, Feb 04, 2013 at 09:57:53PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Looks good, thanks. Thanks for the reviews. I've created a new "branch-1.10" branch and pushed all these changes to master. --Justin _

Re: [ovs-dev] [PATCH 1/2] Prepare for 1.10.0.

2013-02-04 Thread Justin Pettit
On Feb 4, 2013, at 10:02 PM, Ben Pfaff wrote: > On Mon, Feb 04, 2013 at 09:57:52PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Seems reasonable, if you correct the split of an item carried over from > NEWS. Done. Thanks. --Justin

Re: [ovs-dev] [PATCH] NEW: Rearrange announcements related to 1.10 and 1.9.

2013-02-04 Thread Justin Pettit
On Feb 4, 2013, at 10:00 PM, Ben Pfaff wrote: > On Mon, Feb 04, 2013 at 09:46:42PM -0800, Justin Pettit wrote: >> Suggested-by: Ben Pfaff >> Signed-off-by: Justin Pettit > > s/NEW/NEWS/ in the title. Yeah, I noticed that after I sent it. > It looks like you added the "Tunneling" section for

Re: [ovs-dev] [PATCH 2/2] Prepare for post-1.10.0 (1.10.90).

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 09:57:53PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] Prepare for 1.10.0.

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 09:57:52PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Seems reasonable, if you correct the split of an item carried over from NEWS. Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/ma

Re: [ovs-dev] [PATCH] NEW: Rearrange announcements related to 1.10 and 1.9.

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 09:46:42PM -0800, Justin Pettit wrote: > Suggested-by: Ben Pfaff > Signed-off-by: Justin Pettit s/NEW/NEWS/ in the title. It looks like you added the "Tunneling" section for 1.10 in the middle of an existing item, rather than between items. Thanks, Ben. ___

Re: [ovs-dev] [PATCH] NEWS: Correct some items incorrectly stating they arrived in 1.9.0.

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 09:48:06PM -0800, Justin Pettit wrote: > On Feb 4, 2013, at 2:47 PM, Ben Pfaff wrote: > > > On Mon, Feb 04, 2013 at 02:20:58PM -0800, Justin Pettit wrote: > >> A few items were listed as arriving in 1.9.0, but they actually were new > >> to 1.10.0. > >> > >> Signed-off-by

[ovs-dev] [PATCH 2/2] Prepare for post-1.10.0 (1.10.90).

2013-02-04 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |4 configure.ac |2 +- debian/changelog |7 +++ 3 files changed, 12 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index e1fbd13..be0365a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +post-v1.10.0 +--

[ovs-dev] [PATCH 1/2] Prepare for 1.10.0.

2013-02-04 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |4 +- configure.ac |2 +- debian/changelog | 70 ++--- 3 files changed, 63 insertions(+), 13 deletions(-) diff --git a/NEWS b/NEWS index c043c3b..e1fbd13 100644 --- a/NEWS +++ b/NEWS

Re: [ovs-dev] [PATCH] NEWS: Correct some items incorrectly stating they arrived in 1.9.0.

2013-02-04 Thread Justin Pettit
On Feb 4, 2013, at 2:47 PM, Ben Pfaff wrote: > On Mon, Feb 04, 2013 at 02:20:58PM -0800, Justin Pettit wrote: >> A few items were listed as arriving in 1.9.0, but they actually were new >> to 1.10.0. >> >> Signed-off-by: Justin Pettit > > I don't have any comments on the rearrangement, but I h

[ovs-dev] [PATCH] NEW: Rearrange announcements related to 1.10 and 1.9.

2013-02-04 Thread Justin Pettit
Suggested-by: Ben Pfaff Signed-off-by: Justin Pettit --- NEWS | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/NEWS b/NEWS index 3a4030f..e1fbd13 100644 --- a/NEWS +++ b/NEWS @@ -5,8 +5,6 @@ v1.10.0 - xx xxx or adapt to nati

[ovs-dev] [PATCH 2/3] bond: Remove stable bond mode.

2013-02-04 Thread Ethan Jackson
Stable bond mode, along with autopath, were trying to implement functionality close to what we get from the bundle action. Unfortunately, they are quite clunky, and generally less useful than bundle, so they're being removed. Signed-off-by: Ethan Jackson --- NEWS |1 +

[ovs-dev] [PATCH 3/3] nicira-ext: Remove the autopath action.

2013-02-04 Thread Ethan Jackson
The autopath action was attempting to achieve functionality similar to the bundle action, but was significantly clunkier, more difficult to understand, more difficult to use, and less reliable. This patch removes it. Signed-off-by: Ethan Jackson --- FAQ |3 -- NEWS

[ovs-dev] [PATCH 1/3] bond: Pseudo-randomly choose initial slave.

2013-02-04 Thread Ethan Jackson
Traditionally, (unless balancing was turned off), the bonding code chose the active slave for all flows which hadn't previously been allocated to another. This worked fine in theory because traffic would eventually be balanced away if there was congestion. Instead of the historical approach, this

Re: [ovs-dev] [PATCH 01/16] User-Space MPLS actions and matches

2013-02-04 Thread Simon Horman
On Tue, Feb 05, 2013 at 09:00:35AM +0900, Simon Horman wrote: > On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote: > > On Fri, Jan 25, 2013 at 04:22:07PM +0900, Simon Horman wrote: > > > This patch implements use-space datapath and non-datapath code > > > to match and use the datapath API s

[ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-04 Thread Ben Pfaff
Until now, the optional OVS_USERSPACE_ATTR_USERDATA attribute had to be exactly 64 bits long, if it was present. However, 64 bits is not enough space to associate as much information with a flow as would be convenient for some userspace features now under development. This commit generalizes the

Re: [ovs-dev] [PATCH 01/16] User-Space MPLS actions and matches

2013-02-04 Thread Simon Horman
On Mon, Feb 04, 2013 at 10:09:20AM -0800, Ben Pfaff wrote: > On Fri, Jan 25, 2013 at 04:22:07PM +0900, Simon Horman wrote: > > This patch implements use-space datapath and non-datapath code > > to match and use the datapath API set out in Leo Alterman's patch > > "user-space datapath: Add basic MPL

Re: [ovs-dev] [PATCH] NEWS: Mention experimental support for newer versions of OpenFlow.

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 02:42:08PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] NEWS: Correct some items incorrectly stating they arrived in 1.9.0.

2013-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 02:20:58PM -0800, Justin Pettit wrote: > A few items were listed as arriving in 1.9.0, but they actually were new > to 1.10.0. > > Signed-off-by: Justin Pettit I don't have any comments on the rearrangement, but I have some suggestions for improvement overall. I guess th

[ovs-dev] [PATCH] NEWS: Mention experimental support for newer versions of OpenFlow.

2013-02-04 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index b2b307c..7995762 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,9 @@ post-v1.9.0 - Many "ovs-vsctl" database commands now accept an --if-exists option. Please

[ovs-dev] [PATCH] NEWS: Correct some items incorrectly stating they arrived in 1.9.0.

2013-02-04 Thread Justin Pettit
A few items were listed as arriving in 1.9.0, but they actually were new to 1.10.0. Signed-off-by: Justin Pettit --- NEWS | 42 ++ 1 files changed, 22 insertions(+), 20 deletions(-) diff --git a/NEWS b/NEWS index 1164962..b2b307c 100644 --- a/NEWS +++ b

[ovs-dev] [PATCH] NEWS: Correct some items incorrectly stating they arrived in 1.9.0.

2013-02-04 Thread Justin Pettit
A few items were listed as arriving in 1.9.0, but they actually were new to 1.10.0. Signed-off-by: Justin Pettit --- NEWS | 42 ++ 1 files changed, 22 insertions(+), 20 deletions(-) diff --git a/NEWS b/NEWS index 1164962..b2b307c 100644 --- a/NEWS +++ b

Re: [ovs-dev] [PATCH] FAQ: Add an entry describing the different ways to dump flows.

2013-02-04 Thread Justin Pettit
On Nov 1, 2012, at 1:03 PM, Ben Pfaff wrote: > On Thu, Nov 01, 2012 at 10:06:55AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > This is really good (thank you!), but I think it can be improved. > First, I don't think it's a good idea to emphasize a kernel/user split > here. T

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-04 Thread Ethan Jackson
> Yes, I'd like to help here. Can you shoot me any ideas you may have? > I've been looking at this in my free time today. Tomorrow I should be > able to dedicate most of the day to it. Ok sounds good. Thanks for taking this on. So at a high level, conceptually what we need to do is fairly straig

Re: [ovs-dev] [PATCH v2 2/2] tests: Add test for self-modifying learn action.

2013-02-04 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Jan 31, 2013 at 4:28 PM, Ben Pfaff wrote: > CC: Paul Ingram > Signed-off-by: Ben Pfaff > --- > tests/learn.at | 35 +++ > 1 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/tests/learn.at b/tests/learn.at > inde

Re: [ovs-dev] [PATCH v2 1/2] netdev-dummy: Correctly maintain port statistics.

2013-02-04 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Jan 31, 2013 at 4:28 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/netdev-dummy.c | 18 +- > 1 files changed, 17 insertions(+), 1 deletions(-) > > diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c > index f81b68e..234d7bc 10064

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-04 Thread Kyle Mestery (kmestery)
On Feb 4, 2013, at 2:59 PM, Ethan Jackson wrote: >> I figured this out. It looks like the flow based tunneling changes no longer >> propagate the destination UDP port down to VXLAN, which requires it. Because >> of this, the VXLAN vport code in the kernel is returning an error. I'll go >> ahead

Re: [ovs-dev] [PATCH] vswitchd: Require "target" column to be unique in OVS database.

2013-02-04 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Feb 1, 2013 at 2:51 PM, Ben Pfaff wrote: > Commit cc7ecee48 (vswitchd: Add unique indexes for some columns.) says, > in part: > > With this commit, the database server itself rejects attempts to add > Port or Interface records with duplicate names or Contr

Re: [ovs-dev] VXLAN ports not working with latest master

2013-02-04 Thread Ethan Jackson
> I figured this out. It looks like the flow based tunneling changes no longer > propagate the destination UDP port down to VXLAN, which requires it. Because > of this, the VXLAN vport code in the kernel is returning an error. I'll go > ahead and fix these up now. Yep I noticed this last Friday

Re: [ovs-dev] [PATCH] python/ovs/db/types: Fix English grammar for enums with one member.

2013-02-04 Thread Ben Pfaff
I guess there could be no literals, it just wouldn't be very useful. Of course, that's presumably why I left out the "one literal" case also. Thanks for the other suggestions but I think the code as-is is fairly readable so I think I'll stick with it. I'll apply this to master soon. On Fri, Feb

Re: [ovs-dev] [PATCH] FAQ: Add question and answer about PPP.

2013-02-04 Thread Ben Pfaff
On Sun, Feb 03, 2013 at 03:40:15AM +, Kyle Mestery (kmestery) wrote: > On Feb 2, 2013, at 10:53 AM, Ben Pfaff wrote: > > We've had this question a few times lately. > > > > Signed-off-by: Ben Pfaff > > > Looks good to me Ben. Thanks Kyle, I applied this to master.