Dear My Friend
Nice day, Hyun Young is a leading professional freight forwarder
and logistics provider who focus on the shipment from South China to all
the world. Hyun Young started freight forwarding operation at Shenzhen in
2004. Based at Shenzhen, our ambition have pushed us forward
This adds support for the OpenFlow 1.1+ copy_ttl_in action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The imple
Actions may provide information to allow further decoding of
a flow.
For example:
In the case of MPLS, L3 and L4 information may not initially be decoded
from the frame as the ethernet type of the frame is an MPLS type and no
information is known about the type of the inner frame.
However, the t
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.15
* Use OVS_ACTION
Use the innermost dl_type when decoding L3 and L4 data from a packet.
Signed-off-by: Simon Horman
---
v2.15
* No change
v2.14
* No change
v2.13
* No change
v2.12
* Use flow_innermost_dl_type helper
v2.11
* First post
---
lib/packets.c |4 ++--
1 file changed, 2 insertions(+), 2 deletio
Allow a flow to be visible in two forms, an outer flow and an inner flow.
This may occur if the actions allow further decoding of a packet to
provide a more fine-grained match. In this case the first-pass
coarse-grained match will hit the outer-flow and the second-pass
fined-grained match will hit
This is to make the code consistent with the proposed MPLS changes
and avoid cluttering the top of the NL_ATTR_FOR_EACH_UNSAFE loop.
Signed-off-by: Simon Horman
---
v2.15
* First post
---
lib/dpif-netdev.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dpif-ne
The ethernet type of an encapsulated frame may be obtained from
actions. If so it should be used to correct decoding of L3 and L4
packet data.
Signed-off-by: Simon Horman
---
v2.15
* No change
v2.14
* No change
v2.13
* As suggested by Jarno Rajahalme
- Initialise encap_eth_type as 0 in ovs_
Allow repeated extraction of flow from packets
Split the L3 and above portion of ovs_flow_extract() out into
ovs_flow_extract_l3_onwards() and call ovs_flow_extract_l3_onwards()
from ovs_flow_extract().
This is to allow re-extraction of L3 and higher information using
an ethernet type supplied by
This adds support for the OpenFlow 1.1+ copy_ttl_out action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The hand
If the actions of a flow allow further decoding of L3 and L4 data to
provide a richer match then use this richer match.
For example:
In the case of MPLS, L3 and L4 information may not initially be decoded
from the frame as the ethernet type of the frame is an MPLS type and no
information is known
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action.
And also adds an NX dec_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.15
* Rebase
v2.14
* No change
v2.13
* No change
v2.12
Hi,
This series implements basic MPLS actions and matches based on work by
Ravi K, Leo Alterman and Yamahata-san.
The main limitation of this implementation is that it only
supports manipulating the outer-most MPLS label.
Key differences between the v2.13 and v2.15:
* Addressed review by Ben Pfa
The ethernet type of an encapsulated frame may be obtained from
actions. If so it should be used to allow a richer conversion
of a flow to nlattrs.
Signed-off-by: Simon Horman
---
v2.15
* No change
v2.14
* No change
v2.13
* No change
v2.12
* No change
v2.11
* First post
---
datapath/datapa
This adds support for the OpenFlow 1.1+ set_mpls_ttl action.
And also adds an NX set_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.15
* No change
v2.14
* No change
v2.13
* No change
v2.
This is the user-space datapath component of this change
Allow a flow to be visible in two forms, an outer flow and an inner flow.
This may occur if the actions allow further decoding of a packet to
provide a more fine-grained match. In this case the first-pass
coarse-grained match will hit the ou
Allow copy_ttl_in to function in the case where:
a) The outer header is MPLS;
b) The next-outer header is IP and;
c) The resulting nw ttl will be different from its existing value
In this circumstance a set ipv4 action will be used to adjust the TTL
but the dl_type of the match will be ETH_P_MPLS_
Use the innermost dl_type when decoding L3 and L4 data from a packet.
Signed-off-by: Simon Horman
---
v2.15
* No change
v2.14
* No change
v2.13
* No change
v2.12
* Use flow_innermost_dl_type helper
v2.11
* First post
---
lib/odp-util.c |6 --
1 file changed, 4 insertions(+), 2 dele
On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote:
> On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > > index 5e32965..b421753 1006
On Wed, Jan 16, 2013 at 07:04:06PM -0800, Jesse Gross wrote:
> On Wed, Jan 16, 2013 at 4:27 PM, Simon Horman wrote:
> > On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> >> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> >> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horma
Hi Ben,
Thanks a lot for your quick reply, that provider much information for us
and we can do our work accordingly.
2013/1/17 Ben Pfaff
> On Thu, Jan 17, 2013 at 10:18:14AM +0800, ?? wrote:
> > Q1: Can we contribute our modification for implementing OpenFlow spec
> > 1.1+ message logic w
On Wed, Jan 16, 2013 at 4:31 PM, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
>> > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
>> > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
>> >
>> > For the PUSH/POP actions I think we also have the sa
On Wed, Jan 16, 2013 at 4:27 PM, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
>> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
>> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
>> >> diff --git a/include/linux/openvswitch.h b/include/lin
On Wed, Jan 16, 2013 at 1:54 PM, Pravin B Shelar wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index ed69af8..4ed40e2 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> +static struct nlattr *reserve_sfa_size(struct sw_flow_actions **sfa, int
> attr_len)
> +{
> +
On Thu, Jan 17, 2013 at 10:18:14AM +0800, ?? wrote:
> Q1: Can we contribute our modification for implementing OpenFlow spec
> 1.1+ message logic without the corresponding dpif logic? because we are
> developping hardware switch, we will not developping features that support
> dpif, let's take
Hi list,
Our company (a switch silicon company) is now developping a hardsware
OpenFlow switch, we love OVS architechure and have ported it succesfully.
Because OpenFlow standard is in still under development and OVS is under
development too, we are now focusing implementing OpenFlow spec 1.1+
On Wed, Jan 16, 2013 at 04:31:31PM -0800, Ben Pfaff wrote:
> On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
> > > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
> > > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
> > >
> > > For the PUSH/POP actions I think we als
On Wed, Jan 16, 2013 at 01:59:21PM -0800, Ben Pfaff wrote:
> On Tue, Jan 15, 2013 at 01:20:57PM +0900, Simon Horman wrote:
> > Optimise OpenFlow flow expiry by placing expirable flows on a list.
> > This optimises scanning of flows for expiry in two ways:
> >
> > * Empirically list traversal appea
On Wed, Jan 16, 2013 at 3:59 PM, Justin Pettit wrote:
> Commit 78a2d59c (dpif-linux.c: Let the kernel pick a port number if one
> not requested.) changed the logic for port assignment, but didn't
> properly handle some error conditions. An attempt to add a tunnel port
> that already exists would
On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
> > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
> > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
> >
> > For the PUSH/POP actions I think we also have the same issue with
> > inserting in the middle of the list an
On Wed, Jan 16, 2013 at 03:49:00PM -0800, Ben Pfaff wrote:
> On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> > On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > >> diff --git a/include/linux/openvswitch.h b/inc
On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> >> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> >> index 5e32965..b421753 100644
> >> --
On Wed, Jan 16, 2013 at 03:59:23PM -0800, Justin Pettit wrote:
> Commit 78a2d59c (dpif-linux.c: Let the kernel pick a port number if one
> not requested.) changed the logic for port assignment, but didn't
> properly handle some error conditions. An attempt to add a tunnel port
> that already exist
On Wed, Jan 16, 2013 at 02:24:56PM -0800, Ethan Jackson wrote:
> I might consider putting hash_3words() near hash_2words() in the
> header file. Mostly just for consistency sake.
I put the prototypes nearby at the top of the file, but hash_3words()
generated enough code that it didn't look worthw
On Fri, Dec 14, 2012 at 04:33:17PM -0800, Ben Pfaff wrote:
> murmurhash includes an xor with the number of bytes hashed in its finishing
> step. Until now, we've only had murmurhash for full words, but an upcoming
> commit adds murmurhash for bytes, so the finishing function will need to
> take a
Thanks for all the reviews. I applied your comments from patch 1 (in
obvious fashion) and will soon push this to master.
On Tue, Jan 15, 2013 at 11:27:58AM -0800, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> On Wed, Nov 7, 2012 at 10:48 AM, Ben Pfaff wrote:
> > In general, with a few spe
Commit 78a2d59c (dpif-linux.c: Let the kernel pick a port number if one
not requested.) changed the logic for port assignment, but didn't
properly handle some error conditions. An attempt to add a tunnel port
that already exists would lead to a segfault. This commit fixes the
logic to stop proces
On Wed, Jan 16, 2013 at 11:24:42AM -0800, Jesse Gross wrote:
> On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> > On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> >> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> >> index 5e32965..b421753 100644
> >> --
On Tue, Jan 15, 2013 at 01:39:43PM -0800, Ethan Jackson wrote:
> I've folded this incremental in.
>
> ---
> FAQ | 12 +++-
> NEWS |1 +
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/FAQ b/FAQ
> index 6d14fc8..b9f655b 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -172,1
On Mon, Jan 14, 2013 at 07:50:16PM -0800, Ethan Jackson wrote:
> This commit moves responsibility for implementing patch ports from
> the datapath to ofproto-dpif. There are two main reasons to do
> this.
>
> The first is a matter of design: ofproto-dpif both has more
> information than the data
On Mon, Jan 14, 2013 at 07:50:15PM -0800, Ethan Jackson wrote:
> As a matter of convenience, this patch refreshes the statistics
> when ovs-appctl dpif/dump-flows is called. Hopefully this will
> prevent users from being confused because statistics they were
> expecting to see haven't made it from
On Mon, Jan 14, 2013 at 07:50:14PM -0800, Ethan Jackson wrote:
> Before this patch, the "need_revalidate" flag and the
> "revalidate_set" tag_set where maintained separately for each
> ofproto. This won't work in future patches when a flow table
> change in one ofproto can require revalidation in
On Jan 15, 2013, at 4:01 PM, Gurucharan Shetty wrote:
> If I run the following 3 commands, vswitchd segfaults.
> ovs-vsctl add-br br1
> ovs-vsctl add-port br1 gre1 -- set interface gre1 type=gre
> options:remote_ip=192.168.1.1
> ovs-vsctl add-port br1 gre2 -- set interface gre2 type=gre
> options
Acked-by: Ethan Jackson
On Tue, Jan 15, 2013 at 9:49 PM, Ben Pfaff wrote:
> On Tue, Jan 15, 2013 at 01:16:13PM -0800, Ethan Jackson wrote:
>> Is there any reason we couldn't simply convert these tests to use the
>> ADD_OF_PORTS macro?
>
> No. Somehow this macro had passed me by.
>
> Revised ver
I might consider putting hash_3words() near hash_2words() in the
header file. Mostly just for consistency sake.
In hash_3words(), you're finishing with a byte count of 8 instead 12.
I may be misinterpreting what that value is for though.
Acked-by: Ethan Jackson
On Fri, Dec 14, 2012 at 4:33 PM
On Tue, Jan 15, 2013 at 01:20:57PM +0900, Simon Horman wrote:
> Optimise OpenFlow flow expiry by placing expirable flows on a list.
> This optimises scanning of flows for expiry in two ways:
>
> * Empirically list traversal appears faster than the code it replaces.
>
> With 1,000,000 flows pres
Fixed according to comments from Jesse,
v1-v2:
- Fixed sample action.
- Fixed set ipv4-tunnel.
- Converted tunnel flags to netlink flags.
- Fixed dump-flow.
--8<--cut here-->8--
Following patch breaks down single ipv4_tunnel netlink attribute in
Thanks for comments.
I posted patch according to comments except refactoring
netlink-parsing. I will post separate patch for that.
--Pravin.
On Tue, Jan 15, 2013 at 10:38 AM, Jesse Gross wrote:
> On Fri, Jan 11, 2013 at 5:23 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/datapath.c b/datap
On Tue, Jan 15, 2013 at 06:39:24PM -0800, Gurucharan Shetty wrote:
> v1-v2:
> - Save ofports only if we are upgrading from a pre-1.10 branch.
> - Change commit message.
Thanks, looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
On Tue, Jan 15, 2013 at 06:39:23PM -0800, Gurucharan Shetty wrote:
> v1-v2: Changed commit message and added the --if-exists option to ovs-vsctl.
Thanks, looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Jan 15, 2013 at 04:57:27PM -0800, Gurucharan Shetty wrote:
> On Tue, Jan 15, 2013 at 1:24 PM, Ben Pfaff wrote:
> > A few ovs-vsctl commands have accepted --if-exists options for some time,
> > to make it possible to execute them in cases where it doesn't really
> > matter if the records th
On Wed, Jan 16, 2013 at 09:54:02AM -0800, Ben Pfaff wrote:
> On Tue, Jan 15, 2013 at 12:23:46PM -0800, Pavithra Ramesh wrote:
> > Following patch removes restriction on the listening socket name that gets
> > configured as bridge controller. Currently, we only connect to sockets in a
> > specific d
To expand on my answer: You will have to change it to use ovs-vsctl.
On Wed, Jan 16, 2013 at 07:32:08PM +, Henkel, Michael wrote:
> Nope, this gives me an "operation not supported" when starting the
> container... lxc seems to use the brctl utility for adding a veth to a
> bridge...
>
> ---
On Tue, Jan 15, 2013 at 11:05 PM, Ben Pfaff wrote:
> On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>> index 5e32965..b421753 100644
>> --- a/include/linux/openvswitch.h
>> +++ b/include/linux/openvswitch.h
>>
Dear My Friend
Nice day, Hyun Young is a leading professional freight forwarder
and logistics provider who focus on the shipment from South China to all
the world. Hyun Young started freight forwarding operation at Shenzhen in
2004. Based at Shenzhen, our ambition have pushed us forward
On Tue, Jan 15, 2013 at 12:23:46PM -0800, Pavithra Ramesh wrote:
> Following patch removes restriction on the listening socket name that gets
> configured as bridge controller. Currently, we only connect to sockets in a
> specific directory with the name of the bridge. This patch removes the
> rest
On Wed, Jan 16, 2013 at 09:57:52AM -0500, Ed Maste wrote:
> Commit f431bf7d78f3212d32bb3d122f783c5c796a1576 added new method
> get_tunnel_config to netdev_class but did not update netdev-bsd.
>
> Signed-off-by: Ed Maste
Applied to master. I'm sorry that I missed this in review.
Signed-off-by: Ben Pfaff
---
tests/library.at |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/library.at b/tests/library.at
index 3334d23..4afd913 100644
--- a/tests/library.at
+++ b/tests/library.at
@@ -126,7 +126,8 @@ dnl for other platforms, so we skip the t
On Wed, Jan 16, 2013 at 11:12:09AM +, James Page wrote:
> From aa28e8bfb646a54ba91e3545f3c0b9db39eddb7f Mon Sep 17 00:00:00 2001
> From: James Page
> Date: Wed, 16 Jan 2013 10:52:59 +
> Subject: [PATCH] python: Workaround UNIX socket path length limits
> To: dev@openvswitch.org
>
> UNIX s
On Wed, Jan 16, 2013 at 3:19 AM, James Page wrote:
> From cce3dd47ae7d9b1e15c79c82a68bee8f24e18c36 Mon Sep 17 00:00:00 2001
> From: James Page
> Date: Mon, 14 Jan 2013 12:23:58 +
> Subject: [PATCH] datapath: support Linux 3.8 kernel
> To: dev@openvswitch.org
>
> Add Linux 3.8 kernel to the ra
Signed-off-by: Ben Pfaff
---
tests/library.at | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/tests/library.at b/tests/library.at
index 4afd913..b0fe3c9 100644
--- a/tests/library.at
+++ b/tests/library.at
@@ -114,7 +114,7 @@ m4_foreach(
AT_CHEC
Presumably we can test for this Linux feature just by seeing whether the
directory is there.
Another goal is to shorten the code because I intend to make another copy
of it in an upcoming commit, to add a similar test for Python.
Signed-off-by: Ben Pfaff
---
tests/library.at | 12 +---
On Wed, Jan 16, 2013 at 3:29 AM, James Page wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Hi Ben
>
> On 15/01/13 05:53, Ben Pfaff wrote:
Also is there a timescale around shipping ovs 1.9?
>> We had a brief internal discussion about this today. We recommend
>> version 1.9 to
Commit f431bf7d78f3212d32bb3d122f783c5c796a1576 added new method
get_tunnel_config to netdev_class but did not update netdev-bsd.
Signed-off-by: Ed Maste
---
lib/netdev-bsd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 9094d04..538f91a 100644
-
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Ben
On 15/01/13 05:53, Ben Pfaff wrote:
>>> Also is there a timescale around shipping ovs 1.9?
> We had a brief internal discussion about this today. We recommend
> version 1.9 to anyone planning a release on the basis of what Open
> vSwitch h
>From cce3dd47ae7d9b1e15c79c82a68bee8f24e18c36 Mon Sep 17 00:00:00 2001
From: James Page
Date: Mon, 14 Jan 2013 12:23:58 +
Subject: [PATCH] datapath: support Linux 3.8 kernel
To: dev@openvswitch.org
Add Linux 3.8 kernel to the range of supported kernel versions.
Signed-off-by: James Page
--
>From aa28e8bfb646a54ba91e3545f3c0b9db39eddb7f Mon Sep 17 00:00:00 2001
From: James Page
Date: Wed, 16 Jan 2013 10:52:59 +
Subject: [PATCH] python: Workaround UNIX socket path length limits
To: dev@openvswitch.org
UNIX socket paths have a limit in terms of length. On Linux
this is 103 charac
On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
> On Tue, Jan 08, 2013 at 02:46:02PM +0900, Simon Horman wrote:
> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> > index 5e32965..b421753 100644
> > --- a/include/linux/openvswitch.h
> > +++ b/include/linux/openv
68 matches
Mail list logo
