On Jul 30, 2012, at 7:36 PM, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 05:25:23PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Thanks, looks good.
Thanks. I pushed this to master, branch-1.8, and branch-1.7. I'll release 1.7
soon.
--Justin
On Mon, Jul 30, 2012 at 09:54:32PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:04AM +0900, Simon Horman wrote:
> > In the case of Open Flow 1.2, which is currently the only
> > time that OXM is be used, there is a 4 byte header before
> > the match which needs to be taken into account w
On Mon, Jul 30, 2012 at 09:46:50PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:03AM +0900, Simon Horman wrote:
> > There are capabilities which are present in one, two and three
> > of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
> > capabilities that are present in al
On Mon, Jul 30, 2012 at 09:43:17PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:01AM +0900, Simon Horman wrote:
> > Add action bits for Open Flow 1.2, these are not the same as Open Flow 1.1.
> >
> > Signed-off-by: Simon Horman
> >
>
> ...
>
> > @@ -2420,10 +2437,13 @@ ofputil_decod
On Mon, Jul 30, 2012 at 09:32:09PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:02:59AM +0900, Simon Horman wrote:
> > Use an enum for ofp_version in ofp-util and ofp-msg.
> > This in conjunction with the use of switch() statements
> > allows the compiler to warn when a new ofp_version isn'
On Mon, Jul 30, 2012 at 09:41:05PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> > diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> > index a943b4e..b62d944 100644
> > --- a/lib/ofp-util.c
> > +++ b/lib/ofp-util.c
> > @@ -2418,7 +2418,16 @@ ofputil_decode_s
On Mon, Jul 30, 2012 at 09:38:40PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 09:36:53PM -0700, Ben Pfaff wrote:
> > On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> > > In Open Flow 1.0 switch_features has a capabilities field.
> > > However, in Open Flow 1.1, 1.2 and 1.3 thi
On Mon, Jul 30, 2012 at 09:36:53PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> > In Open Flow 1.0 switch_features has a capabilities field.
> > However, in Open Flow 1.1, 1.2 and 1.3 this field is reserved.
> > Thus it should not be read on decode and i
On Mon, Jul 30, 2012 at 11:03:04AM +0900, Simon Horman wrote:
> In the case of Open Flow 1.2, which is currently the only
> time that OXM is be used, there is a 4 byte header before
> the match which needs to be taken into account when calculating
> the pad length. This complicates nx_match pull an
On Mon, Jul 30, 2012 at 11:03:03AM +0900, Simon Horman wrote:
> There are capabilities which are present in one, two and three
> of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
> capabilities that are present in all three Open Flow versions and
> add ofputil_capabilities_mask() to
On Mon, Jul 30, 2012 at 11:03:02AM +0900, Simon Horman wrote:
> Reduce scope of per-protocol variables in ofputil_encode_flow_mod()
>
> These variables are only needed in one of the cases covered by the switch
> statement and will increase in number as more cases (protocols) are
> supported.
>
>
On Mon, Jul 30, 2012 at 11:03:01AM +0900, Simon Horman wrote:
> Add action bits for Open Flow 1.2, these are not the same as Open Flow 1.1.
>
> Signed-off-by: Simon Horman
>
...
> @@ -2420,10 +2437,13 @@ ofputil_decode_switch_features(const struct
> ofp_header *oh,
> }
> swi
On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index a943b4e..b62d944 100644
> --- a/lib/ofp-util.c
> +++ b/lib/ofp-util.c
> @@ -2418,7 +2418,16 @@ ofputil_decode_switch_features(const struct ofp_header
> *oh,
> if (osf->capa
On Mon, Jul 30, 2012 at 09:36:53PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> > In Open Flow 1.0 switch_features has a capabilities field.
> > However, in Open Flow 1.1, 1.2 and 1.3 this field is reserved.
> > Thus it should not be read on decode and i
On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> In Open Flow 1.0 switch_features has a capabilities field.
> However, in Open Flow 1.1, 1.2 and 1.3 this field is reserved.
> Thus it should not be read on decode and it seems most appropriate
> to set as zero on encode.
>
> This patc
On Mon, Jul 30, 2012 at 11:02:59AM +0900, Simon Horman wrote:
> Use an enum for ofp_version in ofp-util and ofp-msg.
> This in conjunction with the use of switch() statements
> allows the compiler to warn when a new ofp_version isn't handled.
>
> Signed-off-by: Simon Horman
>
> ---
>
> Anecdota
On Tue, Jul 24, 2012 at 10:28:23PM -0700, Ben Pfaff wrote:
> On Wed, Jul 25, 2012 at 12:29:15PM +0900, Simon Horman wrote:
> > On Thu, Jul 19, 2012 at 11:28:51PM -0700, Ben Pfaff wrote:
> > > Signed-off-by: Ben Pfaff
> >
> > Reviewed-by: Simon Horman
>
> Thanks!
>
> This series is fully review
On Jul 30, 2012, at 7:35 PM, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 06:45:51PM -0700, Justin Pettit wrote:
>>
>> Thanks. Based on your suggestion in the previous patch to use
>> UINT16_MAX instead of 0, I've updated this patch accordingly.
>
> I don't want 65535 to be a part of the documen
On Mon, Jul 30, 2012 at 11:10:23PM -0400, Ed Maste wrote:
> On 30 July 2012 20:16, Ben Pfaff wrote:
> > On Mon, Jul 30, 2012 at 07:23:48PM -0400, Ed Maste wrote:
> >> The FreeBSD version of xargs does not run the utility argument on empty
> >> input, while GNU xargs runs it at least once, even wit
On 30 July 2012 20:16, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 07:23:48PM -0400, Ed Maste wrote:
>> The FreeBSD version of xargs does not run the utility argument on empty
>> input, while GNU xargs runs it at least once, even with empty input. As
>> a result on FreeBSD VSCTL_CHECK_FIND returne
On Mon, Jul 30, 2012 at 03:18:18PM -0700, Ben Pfaff wrote:
> Debian bug #681880.
> CC: 681...@bugs.debian.org
> Reported-by: Bastian Blank
Reviewed-by: Simon Horman
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 30, 2012 at 03:18:17PM -0700, Ben Pfaff wrote:
> open() with O_CREAT|O_EXCL yields EEXIST if the name passed in is a
> symlink, but we would like "ovsdb-tool create /etc/openvswitch/conf.db" to
> work if /etc/openvswitch/conf.db is a symlink to elsewhere in the file
> system. This comm
On Mon, Jul 30, 2012 at 03:18:16PM -0700, Ben Pfaff wrote:
> open() with O_CREAT|O_EXCL yields EEXIST if the file being opened is a
> symlink. lockfile_try_lock() interpreted that error code to mean that
> some other process had created the lock file in the meantime, so it went
> around its loop a
On Mon, Jul 30, 2012 at 05:25:23PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Thanks, looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 30, 2012 at 06:45:51PM -0700, Justin Pettit wrote:
> On Jul 30, 2012, at 5:05 PM, Ben Pfaff wrote:
>
> > On Sat, Jul 28, 2012 at 11:54:10AM -0700, Justin Pettit wrote:
> >> The datapath port number influences the OpenFlow port number in
> >> ovs-vswitchd. The new "port_no" option for
On Mon, Jul 30, 2012 at 06:16:05PM -0700, Justin Pettit wrote:
> On Jul 30, 2012, at 5:42 PM, Justin Pettit wrote:
>
> > Thanks. I've appended an incremental.
>
> I realized after I sent the incremental, there was a bug. Here's an
> incremental incremental.
Thanks, a glance at the incremental
On Mon, Jul 30, 2012 at 06:39:46PM -0700, Ansis Atteka wrote:
> "git am" says:
>
> Applying: lockfile: Fix hang locking through a dangling symlink.
> Applying: ovsdb: Make "ovsdb-tool create" work through a dangling symlink.
> Applying: debian: Move database from /etc/openvswitch to
> /var/lib/ope
On Jul 30, 2012, at 5:05 PM, Ben Pfaff wrote:
> On Sat, Jul 28, 2012 at 11:54:10AM -0700, Justin Pettit wrote:
>> The datapath port number influences the OpenFlow port number in
>> ovs-vswitchd. The new "port_no" option for the "add-if" command allows
>> the user to request a specific datapath p
Oh forgot to mention. We should probably remove the FLOW_WC_SEQ build
assertions from a lot of these functions as they no longer need to
change when new fields are added.
Ethan
On Mon, Jul 30, 2012 at 6:42 PM, Ethan Jackson wrote:
> Looks good thanks.
>
> Ethan
>
> On Fri, Jul 20, 2012 at 4:25
Looks good thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Now that "struct flow" and "struct flow_wildcards" have the same simple
> and uniform structure, it's easy to handle common operations by just
> iterating over the bits inside them.
>
> Signed-off-by: Ben Pfaff
> ---
>
On Mon, Jul 30, 2012 at 6:30 PM, Ansis Atteka wrote:
>
>
> On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote:
>
>> Here's a series that takes the "bug 681880" series from last week
>> a step further, both fixing a bug that Bastian Blank pointed out
>> (regarding compaction) and making the impleme
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote:
> Here's a series that takes the "bug 681880" series from last week
> a step further, both fixing a bug that Bastian Blank pointed out
> (regarding compaction) and making the implementation safer.
>
> Ansis already reviewed the first three patches
On Jul 30, 2012, at 5:42 PM, Justin Pettit wrote:
> Thanks. I've appended an incremental.
I realized after I sent the incremental, there was a bug. Here's an
incremental incremental.
--Justin
-=-=-=-=-=-=-=-=-=-
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -449,7 +449,7 @@ dpif_linux_
Makes sense, looks good.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> It's only used in a not-very-useful assertion in some test code. In
> general, exact-match flows make very little sense anymore, and they're
> basically on their way out.
>
> Signed-off-by: Ben Pfaff
> ---
> li
Good riddance to FLOW_SIG_SIZE. Looks good to me.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Since we know these bytes are always 0 in both structures, we can use
> faster functions that only work with full words.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/flow.c |6 +-
>
Looks good.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/flow.h |2 +-
> lib/ofp-util.c |1 +
> tests/test-bundle.c |1 +
> tests/test-classifier.c |1 +
> tests/test-multipath.c |1 +
> 5 files ch
Looks good, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/classifier.c|8 ++---
> lib/flow.c | 27 ++
> lib/flow.h | 27 ++
> lib/meta-flow.c | 90
> +++
On Jul 30, 2012, at 4:02 PM, Ben Pfaff wrote:
> On Sat, Jul 28, 2012 at 11:54:09AM -0700, Justin Pettit wrote:
>> The datapath allows requesting a specific port number for a port, but
>> the dpif interface didn't expose it. This commit adds that support.
>>
>> Signed-off-by: Justin Pettit
>
>
Looks good thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/classifier.c| 12 ++--
> lib/flow.c | 29 +
> lib/flow.h | 14 +++---
> lib/meta-flow.c
Signed-off-by: Justin Pettit
---
NEWS |2 +-
debian/changelog |3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 34fa0ea..9f7b98e 100644
--- a/NEWS
+++ b/NEWS
@@ -46,7 +46,7 @@ v1.8.0 - xx xxx
instead the local timezone, by def
> * (This is useful only for testing, obviously, and the packet isn't really
> - * valid. It hasn't got any checksums filled in, for one, and lots of fields
> - * are just zeroed.) */
> + * valid. There are lots of fields that are just zeroed. */
I think you either need to compute the l4 checks
On Mon, Jul 30, 2012 at 08:08:03PM -0400, Ed Maste wrote:
> Signed-off-by: Ed Maste
Heh, it's really funny to run XenServer tests on FreeBSD at all. But
we run them on other non-XenServer platforms, so, anyway, applied.
Thanks,
Ben.
___
dev mailing l
Makes sense.
I will make the change.
thanx!
mehak
On Mon, Jul 30, 2012 at 5:06 PM, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 05:03:38PM -0700, Mehak Mahajan wrote:
> > Signed-off-by: Mehak Mahajan
> > ---
> > include/openflow/openflow-1.0.h |3 ++-
> > 1 files changed, 2 insertions(+), 1
On Mon, Jul 30, 2012 at 07:23:48PM -0400, Ed Maste wrote:
> The FreeBSD version of xargs does not run the utility argument on empty
> input, while GNU xargs runs it at least once, even with empty input. As
> a result on FreeBSD VSCTL_CHECK_FIND returned no output for an empty
> bridge list while o
Looks good, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/classifier.c| 14 +++---
> lib/flow.c | 29 +
> lib/flow.h | 14 +++---
> lib/meta-flow.c
On Mon, Jul 30, 2012 at 07:06:03PM -0400, Ed Maste wrote:
> FreeBSD sed doesn't support \b, at least in normal mode. Since the
> string we're matching comes at the end of the line anyway just use $
> instead.
>
> Signed-off-by: Ed Maste
Applied, thanks.
_
Signed-off-by: Ed Maste
---
xenserver/opt_xensource_libexec_interface-reconfigure |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xenserver/opt_xensource_libexec_interface-reconfigure
b/xenserver/opt_xensource_libexec_interface-reconfigure
index 6c6de9f..72bd5e4 100755
--
On Mon, Jul 30, 2012 at 05:03:38PM -0700, Mehak Mahajan wrote:
> Signed-off-by: Mehak Mahajan
> ---
> include/openflow/openflow-1.0.h |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/openflow/openflow-1.0.h b/include/openflow/openflow-1.0.h
> index d71b007.
On Sat, Jul 28, 2012 at 11:54:10AM -0700, Justin Pettit wrote:
> The datapath port number influences the OpenFlow port number in
> ovs-vswitchd. The new "port_no" option for the "add-if" command allows
> the user to request a specific datapath port number.
>
> Feature #12642
>
> Signed-off-by: J
Signed-off-by: Mehak Mahajan
---
include/openflow/openflow-1.0.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/openflow/openflow-1.0.h b/include/openflow/openflow-1.0.h
index d71b007..97380fa 100644
--- a/include/openflow/openflow-1.0.h
+++ b/include/openflow/
The FreeBSD version of xargs does not run the utility argument on empty
input, while GNU xargs runs it at least once, even with empty input. As
a result on FreeBSD VSCTL_CHECK_FIND returned no output for an empty
bridge list while on Linux it returned a single blank line. Add a new
VSCTL_CHECK_FI
FreeBSD sed doesn't support \b, at least in normal mode. Since the
string we're matching comes at the end of the line anyway just use $
instead.
Signed-off-by: Ed Maste
---
tests/ofproto-dpif.at |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests
On Sat, Jul 28, 2012 at 11:54:09AM -0700, Justin Pettit wrote:
> The datapath allows requesting a specific port number for a port, but
> the dpif interface didn't expose it. This commit adds that support.
>
> Signed-off-by: Justin Pettit
One oddity is that dpif_port_add() uses 0 as an out-of-ba
OVS provides a utility to create IP packets for the purpose of testing
using ovs-appctl netdev-dummy/receive. These packets created by
flow_compose() earlier did not have the IP checksum in them. With this
commit, the checksum with be added to these test IP packets.
Signed-off-by: Mehak Mahajan
On Jul 30, 2012, at 3:46 PM, Ben Pfaff wrote:
> On Fri, Jul 27, 2012 at 10:12:04PM -0700, Justin Pettit wrote:
>> Previously, the force-reload-kmod command would stop forwarding, stop
>> the database, restart the database, and then restart forwarding. If the
>> database is large, it can take a w
On Fri, Jul 27, 2012 at 10:12:04PM -0700, Justin Pettit wrote:
> Previously, the force-reload-kmod command would stop forwarding, stop
> the database, restart the database, and then restart forwarding. If the
> database is large, it can take a while to be read (we've seen as much as
> 10 seconds),
On Mon, Jul 30, 2012 at 09:42:10PM +, Ed Maste wrote:
> I currently have 8 failing unit tests on FreeBSD:
> testsuite: 186 188 474 1045 1054 1055 1056 1057 failed
>
> Here are some notes on each of them. I have fixes / workarounds for all
> but the first two and will send patches shortly.
Al
On Mon, Jul 30, 2012 at 07:52:42PM +, Ed Maste wrote:
> On FreeBSD I'm seeing an intermittent failure in a number of the
> vconn unit tests - e.g. 186 tcp vconn - refuse connection. The test
> code:
>
> 139 static void
> 140 test_refuse_connection(int argc OVS_UNUSED, char *argv[])
> 141 {
On Mon, Jul 30, 2012 at 08:34:52PM +, Ed Maste wrote:
> FreeBSD's wc outputs leading whitespace before the count, so use test(1)
> for numeric equality instead of AC_CHECK string match.
>
> Signed-off-by: Ed Maste
Applied to master, thanks.
(I should have known about this difference, I've r
Cabestan. Layout Doble
Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu
lista de contactos.
Si no ves correctamente las imágenes, pulsa [
http://email.globalbono.com/E30072012155636.cfm?WL=811&WS=208833_8707685&WA=307
] aquí
[ http://email.globalbono.com/Go/index.cfm
Looks good, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/classifier.c | 10 +-
> lib/flow.c | 41 -
> lib/flow.h | 13 +++--
> lib/meta-flow.c | 11 +++
On Mon, Jul 30, 2012 at 06:14:23PM +, Ed Maste wrote:
> FreeBSD requires that setsockopt(..., IP_TOS, ...) be passed an int
> value. Linux accepts either int or char types (and has since at least
> kernel 2.6.12) so just use int type unconditionally.
>
> Signed-off-by: Ed Maste
Applied to m
Please read attached private message from Brian Buschek
Hello My Good Friend.docx
Description: application/vnd.openxmlformats-officedocument.wordprocessingml.document
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 27, 2012 at 11:39:47PM +0200, Bastian Blank wrote:
> On Fri, Jul 27, 2012 at 10:21:10AM -0700, Ben Pfaff wrote:
> > On Fri, Jul 27, 2012 at 10:28:08AM +0200, Bastian Blank wrote:
> > > I was unclear. You should first use realpath(3) on the database filename
> > > and calculate the lock
Signed-off-by: Ben Pfaff
---
ovsdb/file.c |7 +--
ovsdb/ovsdb-tool.c| 22 ++
tests/ovsdb-server.at | 15 ++-
tests/ovsdb-tool.at | 17 -
4 files changed, 49 insertions(+), 12 deletions(-)
diff --git a/ovsdb/file.c b/ovs
As the database is being transitioned from /etc to /var, there is a symlink
from the old to the new location for the database and a symlink for its
lockfile. This works OK, but it would be more user-friendly to still work
correctly in case the symlink for the lockfile isn't there (since its
existe
It will acquire its first user in an upcoming commit.
Signed-off-by: Ben Pfaff
---
lib/util.c | 85 +
lib/util.h |3 ++
tests/file_name.at | 97
tests/test-util.c | 13
Debian bug #681880.
CC: 681...@bugs.debian.org
Reported-by: Bastian Blank
Signed-off-by: Ben Pfaff
---
REPORTING-BUGS |2 +-
debian/automake.mk |1 +
debian/openvswitch-switch.dirs |1 +
debian/openvswitch-switch.postinst | 15 +++
de
This will allow passing arguments in for an upcoming test.
Signed-off-by: Ben Pfaff
---
tests/library.at | 15 ++--
tests/test-util.c | 90 +---
2 files changed, 68 insertions(+), 37 deletions(-)
diff --git a/tests/library.at b/tests/libr
Working through symlinks is undesirable when one can avoid it.
The Debian packaging still sets up the symlinks for compatibility with
existing software that expects the database to be in /etc/openvswitch.
Signed-off-by: Ben Pfaff
---
debian/rules |4 ++--
1 files changed, 2 insertions(+), 2
The default is unchanged, /etc/openvswitch/conf.db.
This makes it possible to transition each Open vSwitch packaging from
/etc/openvswitch/conf.db to /var/lib/openvswitch/conf.db independently.
Signed-off-by: Ben Pfaff
---
Makefile.am|1 +
configure.a
open() with O_CREAT|O_EXCL yields EEXIST if the name passed in is a
symlink, but we would like "ovsdb-tool create /etc/openvswitch/conf.db" to
work if /etc/openvswitch/conf.db is a symlink to elsewhere in the file
system. This commit fixes the problem. It introduces a theoretical race,
but no one
open() with O_CREAT|O_EXCL yields EEXIST if the file being opened is a
symlink. lockfile_try_lock() interpreted that error code to mean that
some other process had created the lock file in the meantime, so it went
around its loop again, which found out the same thing, which led to a hang.
This co
Here's a series that takes the "bug 681880" series from last week
a step further, both fixing a bug that Bastian Blank pointed out
(regarding compaction) and making the implementation safer.
Ansis already reviewed the first three patches. They are already
uploaded to Debian but I haven't committe
In flow_wildcards_combine(), does it make sense to move the new line
above the eth_addr_bitands() so it's with the similar code? Totally
aesthetic, so it doesn't matter much. Same in flow_wildcards_hash().
Looks like a big win to me, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wr
Looks like a win to me, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> It might have been a useful optimization at one point to have FWW_*
> correspond in OFPFW10_* where possible, but it doesn't seem worthwhile for
> only 3 corresponding values. It also makes the code somewh
Dear Sir or Madam,
We write to inform you that we are now taking bookings for one day charters in
Mallorca and Ibiza for our Luxury motor Yacht Lady Tatiana of London.
If you have any clients that are looking for one day or longer charters in
Mallorca or Ibiza for a fully professionally crew
Looks good to me.
I had a thought but I don't feel strongly about it. What if we made a
new hook for ofproto implementations:
enum ofperr (*validate_actions)(const struct ofpact ofpacts[], size_t
ofpacts_len, const struct flow *, int max_ports).
In the ofproto-dpif implementation this would sim
I currently have 8 failing unit tests on FreeBSD:
testsuite: 186 188 474 1045 1054 1055 1056 1057 failed
Here are some notes on each of them. I have fixes / workarounds for all
but the first two and will send patches shortly.
186, 188
This is the issue in my recent post 'FreeBSD vconn refuse-co
Looks good, thanks.
Ethan
On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote:
> This allows port numbers in actions and elsewhere in OpenFlow messages to
> be checked at a higher level.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif.c | 16 +++-
> ofproto/ofproto-pro
Hey Ben,
Looks good to me.
thanx!
mehak
On Fri, Jul 27, 2012 at 1:23 PM, Ben Pfaff wrote:
> Would someone review this please? It should not be hard.
>
> Thanks,
>
> Ben.
>
> On Sat, Jul 21, 2012 at 09:56:28AM -0700, Ben Pfaff wrote:
> > Rob Sherwood reported a bug in OVS treatment of ofp10_ma
FreeBSD's wc outputs leading whitespace before the count, so use test(1)
for numeric equality instead of AC_CHECK string match.
Signed-off-by: Ed Maste
---
tests/ovsdb-server.at |8
tests/ovsdb-tool.at |9 +++--
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git
Hello
I have to resend this mail to you because I have sent it to you several
times without respond. You Have Been Left An Inheritance Under A Will.
Contact Email: barr.giacocarbon...@yahoo.es Tel:+34632220425
___
dev mailing list
dev@openvswitch.or
On FreeBSD I'm seeing an intermittent failure in a number of the
vconn unit tests - e.g. 186 tcp vconn - refuse connection. The test
code:
139 static void
140 test_refuse_connection(int argc OVS_UNUSED, char *argv[])
141 {
142 const char *type = argv[1];
143 int expected_error;
144
Hi dear
i am Jennifer Mabiza i am from Sudan but presently living in Dakar Senegal .i
just want to let you know that i will be so interested to be your friend if you
don't mind , anyway all i know is that we can share so many things in common
though it depends on how you view it as i know that
FreeBSD requires that setsockopt(..., IP_TOS, ...) be passed an int
value. Linux accepts either int or char types (and has since at least
kernel 2.6.12) so just use int type unconditionally.
Signed-off-by: Ed Maste
---
lib/socket-util.c |6 --
1 file changed, 4 insertions(+), 2 deletion
Ed, I've had a couple of bounces of the following form emailing you.
I don't really know what to do about it so I'm forwarding it back to
the list in the hope that you'll see it.
Thanks,
Ben.
- Forwarded message from Mail Delivery Subsystem
-
Date: Mon, 30 Jul 2012 16:58:07 +
From
On Mon, Jul 30, 2012 at 03:42:22PM +, Ed Maste wrote:
> I'm working through a handful of unit test failures in the FreeBSD port
> and the first issue I've come across is set_dscp failing - as it turns
> out FreeBSD requires an int value for the setsockopt() call, not a char.
>
> Looking at the
I'm working through a handful of unit test failures in the FreeBSD port
and the first issue I've come across is set_dscp failing - as it turns
out FreeBSD requires an int value for the setsockopt() call, not a char.
Looking at the Linux ip(7) man page I see the statement "TOS is a byte,"
but all o
Bonjour,
Je me nomme Monsieur Georges Olivier Tanoh ,je suis citoyen ivoirien marié
père de 3 enfants , je travaillais dans les finances précisément au trésor de
mon pays la cote d’ivoire . Je me permets de m’adresser à vous compte tenu de
la crise politico militaire qui s’est vu par la chu
90 matches
Mail list logo
