On Mon, Jul 30, 2012 at 09:46:50PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 11:03:03AM +0900, Simon Horman wrote:
> > There are capabilities which are present in one, two and three
> > of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
> > capabilities that are present in all three Open Flow versions and
> > add ofputil_capabilities_mask() to return the mask of capabilities
> > for each version.
> >
> > This does not cover OFPUTIL_C_STP and OFPUTIL_C_GROUP_STATS, which
> > both use capability bit 3 and are treated as special cases in
> > ofputil_encode_switch_features() and ofputil_decode_switch_features().
> >
> > Signed-off-by: Simon Horman <ho...@verge.net.au>
>
> Thanks.
>
> I changed uint8_t to enum ofp_version here:
Thanks, sorry for missing that.
>
> > +static uint32_t
> > +ofputil_capabilities_mask(uint8_t ofp_version)
> > +{
> > + /* Handle capabilities whose bit is unique for all Open Flow versions
> > */
> > + switch (ofp_version) {
>
> and queued this up.
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
