> * (This is useful only for testing, obviously, and the packet isn't really
> - * valid. It hasn't got any checksums filled in, for one, and lots of fields
> - * are just zeroed.) */
> + * valid. There are lots of fields that are just zeroed. */
I think you either need to compute the l4 checksums or leave the comment.
Ethan
> void
> flow_compose(struct ofpbuf *b, const struct flow *flow)
> {
> @@ -1067,6 +1067,7 @@ flow_compose(struct ofpbuf *b, const struct flow *flow)
>
> ip->ip_tot_len = htons((uint8_t *) b->data + b->size
> - (uint8_t *) b->l3);
> + ip->ip_csum = csum(ip, IP_IHL(ip->ip_ihl_ver) * 4);
> } else if (flow->dl_type == htons(ETH_TYPE_IPV6)) {
> /* XXX */
> } else if (flow->dl_type == htons(ETH_TYPE_ARP)) {
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
