On 23 July 2012 20:08, Isaku Yamahata wrote:
...
> If desired, I'm willing to include Joe's metadata patch into this series.
I'm happy to rebase my code against this branch, check it works and
finish up tidying/testing if there's no rush. I've made a few
modifications since my last post, but have
On Mon, Jul 23, 2012 at 03:16:32PM +0900, Simon Horman wrote:
> In the case of Open Flow 1.2, which is currently the only
> time that OXM is be used, there is a 4 byte header before
> the match which needs to be taken into account when calculating
> the pad length. This complicates nx_match pull an
On Mon, Jul 23, 2012 at 09:58:19AM -0700, Ben Pfaff wrote:
> ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
> This meant that "make install" with the -j option could try to install
> ovs-vsctl two times in parallel, a race that occasionally caused a build
> failure, e.g.:
>
On Fri, Jul 20, 2012 at 09:24:01AM -0700, Ben Pfaff wrote:
> A Debian package is expected to remove all its configuration files (which
> includes all files in /etc) when it is purged, but the
> openvswitch-controller package wasn't doing that. This fixes the problem.
>
> Debian bug #682187.
> CC:
On Mon, Jul 23, 2012 at 09:26:49AM -0700, Ben Pfaff wrote:
> On Mon, Jul 23, 2012 at 04:58:09PM +0900, Simon Horman wrote:
> > On Sun, Jul 22, 2012 at 11:48:52PM -0700, Ben Pfaff wrote:
> > > This is an alternative proposal to the OXM VLAN patches that
> > > Simon sent earlier beginning here:
> > >
On Mon, Jul 23, 2012 at 12:46 AM, Dan Carpenter
wrote:
> If there is no OVS_SAMPLE_ATTR_ACTIONS set then "acts_list" is NULL and
> it leads to a NULL dereference when we call nla_len(acts_list). This
> is a static checker fix, not something I have seen in testing.
>
> Signed-off-by: Dan Carpenter
Thanks. I pushed this fix to master and branch-1.[87654].
On Mon, Jul 23, 2012 at 12:34:33PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Mon, Jul 23, 2012 at 9:58 AM, Ben Pfaff wrote:
> > ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
> > This me
Looks good, thanks.
Ethan
On Mon, Jul 23, 2012 at 9:58 AM, Ben Pfaff wrote:
> ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
> This meant that "make install" with the -j option could try to install
> ovs-vsctl two times in parallel, a race that occasionally caused a buil
Thanks, I pushed this.
On Mon, Jul 23, 2012 at 10:39:27AM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Jul 23, 2012, at 10:31 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > vswitchd/vswitch.xml |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-
Looks good.
--Justin
On Jul 23, 2012, at 10:31 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/vswitch.xml |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index 688f715..e6ea844 100644
> --- a/vswit
Signed-off-by: Ben Pfaff
---
vswitchd/vswitch.xml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 688f715..e6ea844 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -2124,7 +2124,7 @@
The ev
On Mon, Jul 23, 2012 at 12:51:45AM -0700, Justin Pettit wrote:
> On Jul 19, 2012, at 11:19 AM, Ben Pfaff wrote:
>
> > OK, I wrote one. I'm glad I did since the patch I posted didn't
> > work. Here's a fixed version for final review.
>
> I think you need the incremental I've added at the end of
Your message dated Mon, 23 Jul 2012 17:02:47 +
with message-id
and subject line Bug#682384: fixed in openvswitch 1.4.2+git20120612-6
has caused the Debian Bug report #682384,
regarding odd s390 build failure for openvswitch
to be marked as done.
This means that you claim that the problem has
On Sun, Jul 22, 2012 at 12:07:53PM +0200, Bastian Blank wrote:
> And a quick check reveals that ovs-vsctl is installed two times. It is
> included in bin_PROGRAMS and bin_SCRIPTS. They are evalutated in two
> different make targets and may run parallel.
Thanks for spotting the problem. I uploaded
Accepted:
openvswitch-brcompat_1.4.2+git20120612-6_i386.deb
to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-6_i386.deb
openvswitch-common_1.4.2+git20120612-6_i386.deb
to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-6_i386.deb
openvswitch-controller_1.4.2+git20120612-6
openvswitch_1.4.2+git20120612-6_i386.changes uploaded successfully to localhost
along with the files:
openvswitch_1.4.2+git20120612-6.dsc
openvswitch_1.4.2+git20120612-6.debian.tar.gz
openvswitch-common_1.4.2+git20120612-6_i386.deb
openvswitch-switch_1.4.2+git20120612-6_i386.deb
openvswit
ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
This meant that "make install" with the -j option could try to install
ovs-vsctl two times in parallel, a race that occasionally caused a build
failure, e.g.:
http://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=s390&
On Mon, Jul 23, 2012 at 12:35:54AM -0700, Justin Pettit wrote:
> Also use consistent capitalization for "DSCP".
>
> Signed-off-by: Justin Pettit
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 23, 2012 at 12:35:53AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Look good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 23, 2012 at 04:58:09PM +0900, Simon Horman wrote:
> On Sun, Jul 22, 2012 at 11:48:52PM -0700, Ben Pfaff wrote:
> > This is an alternative proposal to the OXM VLAN patches that
> > Simon sent earlier beginning here:
> > http://openvswitch.org/pipermail/dev/2012-July/019329.html
> >
On Mon, Jul 23, 2012 at 02:57:24PM +0900, Isaku Yamahata wrote:
> On Fri, Jul 20, 2012 at 04:25:25PM -0700, Ben Pfaff wrote:
> > diff --git a/lib/flow.c b/lib/flow.c
> > index a5076bb..7b50b0b 100644
> > --- a/lib/flow.c
> > +++ b/lib/flow.c
>
> ...snip...
>
> > +/* Initializes 'dst' as the bit-w
On Sun, Jul 22, 2012 at 09:35:39PM -0700, Ben Pfaff wrote:
> > What concerns me is how complex xlate_actions() would be with Write-Actions.
> > Anyway we can re-consider it when I (or someone else) attack Write-Actions.
> > It is internal representation, not exposed API/ABI.
>
> I had the idea tha
Signed-off-by: Isaku Yamahata
---
v3
- change for OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
- changed for ofp_instruction
---
lib/ofp-actions.c | 22 ++
lib/ofp-actions.h |2 +
lib/ofp-parse.c | 112
3 files changed
Signed-off-by: Isaku Yamahata
---
v3
- modified for OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
- changed for ofp_instruction
---
lib/ofp-actions.c | 71 +++-
1 files changed, 58 insertions(+), 13 deletions(-)
diff --git a/lib/ofp-actio
When goto-table instruction results in table miss, generate packet-in event
Signed-off-by: Isaku Yamahata
---
v3
- changed for OFPACT_GOTO_ABLE
v2
- minor change to compile
---
ofproto/ofproto-dpif.c | 30 +-
1 files changed, 21 insertions(+), 9 deletions(-)
diff
Those actions correspond to instructions, Clear-Actions, Write-Actions and
Goto-Table.
Since Write-Metadata is addressed by other patch series, so it isn't
introduced.
Signed-off-by: Isaku Yamahata
---
v3:
- introduce OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
- changed for ofp_instru
Signed-off-by: Isaku Yamahata
---
v3
- manual rebase
v2
- no change
---
ofproto/ofproto-dpif.c | 280 ++--
1 files changed, 150 insertions(+), 130 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 8a63a44..8b857f3 100644
Signed-off-by: Isaku Yamahata
---
v3
- changed for OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
- changed for ofp_instruction
---
lib/ofp-actions.c | 66 +++-
lib/ofp-util.c| 26 +
2 files changed, 75 insertions(
Signed-off-by: Isaku Yamahata
---
v3
- manual rebase
v2
- changed for ofp_instruction
Conflicts:
ofproto/ofproto-dpif.c
---
lib/ofp-actions.c |3 +--
ofproto/ofproto-dpif.c | 11 +++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/ofp-actions.c b/l
Signed-off-by: Isaku Yamahata
---
v3
- no change
v2
- no chnage
---
ofproto/ofproto-dpif.c | 31 ---
1 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index c73b2e4..3e9c744 100644
--- a/ofproto/ofproto-
This order is used by parser to check if the instruction is given
in this order.
Signed-off-by: Isaku Yamahata
---
v3
- newly introduced
---
lib/ofp-actions.h | 29 +++--
1 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/lib/ofp-actions.h b/lib/ofp-action
Signed-off-by: Isaku Yamahata
---
v3
- changed for OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
- changed for ofp_instruction
---
lib/ofp-actions.c | 40 ++--
1 files changed, 34 insertions(+), 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp
They will be used by other files like ofp-parser.c.
Signed-off-by: Isaku Yamahata
---
v3
- no change
v2
- newly introduced
---
lib/ofp-actions.c | 33 -
lib/ofp-actions.h | 35 +++
2 files changed, 35 insertions(+), 33 deletion
Signed-off-by: Isaku Yamahata
---
v3
- newly instrocuded
---
lib/ofp-actions.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h
index 10ab301..b92e160 100644
--- a/lib/ofp-actions.h
+++ b/lib/ofp-actions.h
@@ -513,7 +513,7 @@ void ofp
This patch adds instruction OF11 apply-actions/goto-table supports.
Okay, I re-write the patch series by introducing
OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}.
I did only compile-tested for now. If this approach is okay, I'll completes
the patch series and post it.
If desired, I'm willing
From: Dan Carpenter
Date: Mon, 23 Jul 2012 10:46:28 +0300
> If there is no OVS_SAMPLE_ATTR_ACTIONS set then "acts_list" is NULL and
> it leads to a NULL dereference when we call nla_len(acts_list). This
> is a static checker fix, not something I have seen in testing.
>
> Signed-off-by: Dan Carp
On Sun, Jul 22, 2012 at 11:48:52PM -0700, Ben Pfaff wrote:
> This is an alternative proposal to the OXM VLAN patches that
> Simon sent earlier beginning here:
> http://openvswitch.org/pipermail/dev/2012-July/019329.html
>
> Instead of trying to make single metaflow fields look like both
> OF
On Jul 19, 2012, at 11:19 AM, Ben Pfaff wrote:
> OK, I wrote one. I'm glad I did since the patch I posted didn't
> work. Here's a fixed version for final review.
I think you need the incremental I've added at the end of the message, but
otherwise it looks good to me.
--Justin
diff --git a/u
If there is no OVS_SAMPLE_ATTR_ACTIONS set then "acts_list" is NULL and
it leads to a NULL dereference when we call nla_len(acts_list). This
is a static checker fix, not something I have seen in testing.
Signed-off-by: Dan Carpenter
---
This applies to Linus's tree.
diff --git a/net/openvswitch
Also use consistent capitalization for "DSCP".
Signed-off-by: Justin Pettit
---
NEWS |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 58cc4fd..cc52322 100644
--- a/NEWS
+++ b/NEWS
@@ -49,7 +49,7 @@ v1.7.0 - xx xxx
- kernel modules are renamed
Signed-off-by: Justin Pettit
---
lib/socket-util.c |2 +-
lib/stream-provider.h |4 ++--
python/ovs/stream.py |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/socket-util.c b/lib/socket-util.c
index 5fe9f98..2c5e6cc 100644
--- a/lib/socket-util.c
+++ b/li
41 matches
Mail list logo
