On Jul 19, 2012, at 11:19 AM, Ben Pfaff wrote: > OK, I wrote one. I'm glad I did since the patch I posted didn't > work. Here's a fixed version for final review.
I think you need the incremental I've added at the end of the message, but otherwise it looks good to me. --Justin diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index ab479d9..2d5c504 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -1754,13 +1754,13 @@ fte_version_format(const struct fte *fte, int index, struct ds *s) cls_rule_format(&fte->rule, s); if (version->cookie != htonll(0)) { - printf(" cookie=0x%"PRIx64, ntohll(version->cookie)); + ds_put_format(s, " cookie=0x%"PRIx64, ntohll(version->cookie)); } if (version->idle_timeout != OFP_FLOW_PERMANENT) { - printf(" idle_timeout=%"PRIu16, version->idle_timeout); + ds_put_format(s, " idle_timeout=%"PRIu16, version->idle_timeout); } if (version->hard_timeout != OFP_FLOW_PERMANENT) { - printf(" hard_timeout=%"PRIu16, version->hard_timeout); + ds_put_format(s, " hard_timeout=%"PRIu16, version->hard_timeout); } ds_put_char(s, ' '); _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev