On Thu, Jul 12, 2012 at 09:48:34PM -0700, Ben Pfaff wrote:
> On Fri, Jul 13, 2012 at 01:46:39PM +0900, Simon Horman wrote:
> > On Thu, Jul 12, 2012 at 09:17:11PM -0700, Ben Pfaff wrote:
> > > Debian kernel maintainer Bastian Blank writes, at
> > > http://bugs.debian.org/680537:
> > >
> > >The
On Fri, Jul 13, 2012 at 01:46:39PM +0900, Simon Horman wrote:
> On Thu, Jul 12, 2012 at 09:17:11PM -0700, Ben Pfaff wrote:
> > Debian kernel maintainer Bastian Blank writes, at
> > http://bugs.debian.org/680537:
> >
> >The netfilter rules are a shared resource. There is no synchronization,
> >
On Thu, Jul 12, 2012 at 09:17:11PM -0700, Ben Pfaff wrote:
> Debian kernel maintainer Bastian Blank writes, at
> http://bugs.debian.org/680537:
>
>The netfilter rules are a shared resource. There is no synchronization,
>so the admin have the last word. As kernel maintainer, I see it simila
Debian kernel maintainer Bastian Blank writes, at
http://bugs.debian.org/680537:
The netfilter rules are a shared resource. There is no synchronization,
so the admin have the last word. As kernel maintainer, I see it similar
to a configuration file, so §10.7 policy applies.
The purpos
On Fri, Jul 13, 2012 at 02:48:49PM +1200, Joe Stringer wrote:
> On 13 July 2012 12:02, Ben Pfaff wrote:
> > Suppose you fix that; it should not be hard (just remove an "else"
> > keyword, I think). Then, second, the semantics implemented here will
> > surprise users, because if ofpacts are transl
On 13 July 2012 12:02, Ben Pfaff wrote:
> First, ofpacts_pull_openflow11_instructions() ignores
> OFPIT_WRITE_METADATA if OFPIT_APPLY_ACTIONS is specified. OF1.1 says,
> in contrast, that anything in OFPIT_APPLY_ACTIONS should be processed
> first, and then OFPIT_WRITE_METADATA. Both, in other w
On Thu, Jul 12, 2012 at 05:06:03PM -0700, Ben Pfaff wrote:
> Would you mind respinning this patch series?
Sure will do.
--
yamahata
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jul 12, 2012 at 08:58:20AM -0700, Ben Pfaff wrote:
> On Thu, Jul 12, 2012 at 09:12:10AM +0900, Simon Horman wrote:
> > One thing that I do have a problem with is the correct treatment of the CFI
> > bit in the value and mask when decoded from an OXMi VLAN_VID match. So far
> > I have come
On Thu, Jun 28, 2012 at 08:30:42PM +0900, Isaku Yamahata wrote:
> This patch eliminates the following warning.
> > ofproto/ofproto-dpif.c: In function 'do_xlate_actions':
> > ofproto/ofproto-dpif.c:5282:17: warning: 'ofp_port' may be used
> > uninitialized in this function [-Wuninitialized]
> > of
On Thu, Jul 12, 2012 at 10:55:21AM +1200, Joe Stringer wrote:
> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
> write to the metadata field. Internally it is represented using
> ofpact_metadata.
>
> We introduce NXAST_WRITE_METADATA to handle writing to the metadata
On Thu, Jul 12, 2012 at 06:24:17PM +0100, Zoltan Kiss wrote:
> The value represented by the macro would stay exactly the same, just become
> obvious.
>
> Signed-off-by: Zoltan Kiss
Applied to master, thanks.
___
dev mailing list
dev@openvswitch.org
ht
On Thu, Jul 12, 2012 at 04:30:13PM -0700, Ansis Atteka wrote:
> On Thu, Jul 12, 2012 at 4:05 PM, Ben Pfaff wrote:
>
> > The implementation of "ofctl/block" used a nested poll loop, with an inner
> > call to unixctl_server_run(). This poll loop always ran inside an outer
> > call to unixctl_serve
On Thu, Jul 12, 2012 at 4:05 PM, Ben Pfaff wrote:
> The implementation of "ofctl/block" used a nested poll loop, with an inner
> call to unixctl_server_run(). This poll loop always ran inside an outer
> call to unixctl_server_run(), since that's the context within which unixctl
> command impleme
On Thu, Jul 12, 2012 at 12:25 AM, Tadaaki Nagao
wrote:
> Recently released CentOS 6.3 (and probably also RHEL 6.3, I assume)
> backported skb_frag_page() and others to their 2.6.32-based kernel,
> which caused build failure of Open vSwitch kernel modules.
>
> Signed-off-by: Tadaaki Nagao
Applied
The implementation of "ofctl/block" used a nested poll loop, with an inner
call to unixctl_server_run(). This poll loop always ran inside an outer
call to unixctl_server_run(), since that's the context within which unixctl
command implementations run. That means that, if a unixctl connection got
Signed-off-by: Ben Pfaff
---
tests/ofproto.at | 27 ---
1 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 804965b..815eb87 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -849,17 +849,38 @@ echo adds=$adds d
On Thu, Jul 12, 2012 at 08:07:08PM +0200, Giuseppe Lettieri wrote:
> On 10/07/2012 18:08, Ben Pfaff wrote:
> >On Tue, Jul 10, 2012 at 09:23:05AM -0400, Ed Maste wrote:
> It isn't clear to me though why the Linux userspace mode does not behave
> the same way though. I had a (very) brief loo
On Thu, Jul 12, 2012 at 01:03:09PM -0700, Justin Pettit wrote:
> On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
>
> > + * 3. Whenever a change to a flow table entry matches some outstanding
> > monitor
> > + *request's criteria and flags, the switch sends a notification to the
> > + *contro
On Wed, Jul 11, 2012 at 9:53 AM, Arun Sharma wrote:
>
> +if len(filters):
> +filter = ",".join(filters)
> +else:
> +filter = None
> +
>
Pythonic to do
if filters:
otherwise LGTM, thanks!
-Reid
___
dev mailing list
dev@open
On Thu, Jul 12, 2012 at 02:46:37PM -0500, Ethan Jackson wrote:
> There's some trailing whitespace in this patch.
Oops, fixex.
> s/consisten/consistent/
Fixed too, thanks.
> Thanks for adding unit tests. Does it make sense to add one that
> sorts by multiple fields specified on the command line
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> + * 3. Whenever a change to a flow table entry matches some outstanding
> monitor
> + *request's criteria and flags, the switch sends a notification to the
> + *controller as an additional NXST_FLOW_MONITOR replies with xid 0.
I think "an" s
Thank you, I pushed this to master.
On Thu, Jul 12, 2012 at 12:46:36PM -0700, Pravin Shelar wrote:
> Looks good.
>
> Thanks,
> Pravin.
>
> On Thu, Jul 12, 2012 at 11:27 AM, Ben Pfaff wrote:
> > Fixes a wild pointer write when nx_put_match() expands the ofpbuf.
> >
> > The change to the OFPST_FL
There's some trailing whitespace in this patch.
s/consisten/consistent/
Thanks for adding unit tests. Does it make sense to add one that
sorts by multiple fields specified on the command line? Perhaps adding
a sort by in_port to the test which does tp_src would give us slightly
better coverage.
Looks good.
Thanks,
Pravin.
On Thu, Jul 12, 2012 at 11:27 AM, Ben Pfaff wrote:
> Fixes a wild pointer write when nx_put_match() expands the ofpbuf.
>
> The change to the OFPST_FLOW case isn't strictly a bug fix, it just makes
> the code for that case more closely resemble the NXST_FLOW case.
>
>
Commit 0c449c5683a improved action error logging for one case, but we might
as well do it for the other case too.
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-ac
Looks good, thanks.
Ethan
On Tue, Jul 3, 2012 at 2:48 PM, Ben Pfaff wrote:
> I want to use this code in another function in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.c | 123
> +++--
> 1 files changed, 68 insertio
Looks good, thanks.
Ethan
On Tue, Jul 3, 2012 at 2:48 PM, Ben Pfaff wrote:
> The logic in do_dump_flows__() went to some trouble to open an OpenFlow
> connection and set the correct protocol, but then it allowed
> dump_stats_transaction() to create and use a completely different OpenFlow
> conne
Fixes a wild pointer write when nx_put_match() expands the ofpbuf.
The change to the OFPST_FLOW case isn't strictly a bug fix, it just makes
the code for that case more closely resemble the NXST_FLOW case.
Bug #12403.
Bug #12460.
Bug #12461.
Reported-by: Timothy Chen
Reported-by: Natasha Gude
R
On 10/07/2012 18:08, Ben Pfaff wrote:
On Tue, Jul 10, 2012 at 09:23:05AM -0400, Ed Maste wrote:
It isn't clear to me though why the Linux userspace mode does not behave
the same way though. I had a (very) brief look at the way PF_PACKET is
handled in Linux and it seemed like the packet would st
On Thu, Jul 05, 2012 at 07:13:55PM -0700, trinh tri wrote:
> Dear Mr Luiz Ozaki and Mr Ben Pfaff!
>
> Thank you vey much for you reply. I used flow-capture to capture flow
> information. And the configure is like this:
> /usr/bin/flow-capture -z0 -V5 -n 288 -N 0 -S1 -w /var/netflow/flows -E2G
>
The value represented by the macro would stay exactly the same, just become
obvious.
Signed-off-by: Zoltan Kiss
---
lib/odp-util.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/odp-util.h b/lib/odp-util.h
index f902b76..16f2b15 100644
--- a/lib/odp-util.h
+++ b/l
On Mon, Jul 09, 2012 at 01:23:21PM -0700, Justin Pettit wrote:
> On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
>
> > -op->ofpacts_len = rule->ofpacts_len;
> > +op->ofpacts_len = op->ofpacts_len;
>
> Did you mean to do this? The previous way looks correct to me, and
> this
On Sat, Jul 07, 2012 at 03:25:28PM -0700, Justin Pettit wrote:
> On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
>
> > @@ -873,7 +875,8 @@ struct rconn_packet_counter *
> > rconn_packet_counter_create(void)
> > {
> > struct rconn_packet_counter *c = xmalloc(sizeof *c);
> > -c->n = 0;
> > +
On Sat, Jul 07, 2012 at 03:04:18PM -0700, Justin Pettit wrote:
> On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
>
> > +/* Returns true if 'rule' exactly matches 'criteria' or are more specific
> > than
>
> s/are/is/
>
> > + * Equivalently, the truth table for whether a field matches is:
> > + *
>
On Sat, Jul 07, 2012 at 11:49:45AM -0700, Justin Pettit wrote:
>
> On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
>
> > An upcoming commit will add support for flow table monitoring by
> > controllers. One feature of this upcoming support is that a controller's
> > own changes to the flow table ca
OK, so resubmit it with a commit log that says it makes the value
clearer. I'm not submitting it with a reference to a webpage that says
(uint16_t)-1 is wrong, because it isn't wrong.
On Thu, Jul 12, 2012 at 05:13:47PM +0100, Zoltan Kiss wrote:
> That's true, my intention was to make the value cl
On Thu, Jul 05, 2012 at 05:15:17PM +0900, Simon Horman wrote:
> These functions do not appear to be used any more.
>
> Signed-off-by: Simon Horman
Applied to master, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/lis
That's true, my intention was to make the value clearer. Simply writing
UINT16_MAX is easier than "(uint16_t) -1" which equals "-1 + (UINT16_MAX
+ 1)" as you also mentioned.
On 12/07/12 14:46, Ben Pfaff wrote:
On Thu, Jul 12, 2012 at 01:31:49PM +0100, Zoltan Kiss wrote:
The value represented
On Wed, Jul 11, 2012 at 10:36:20AM +0200, Giuseppe Lettieri wrote:
> > Do you want to add an INSTALL.FreeBSD or similar file at top level?
> > Feel free to copy any applicable text from INSTALL.Linux. Or, if you
> > think it's better, please feel free to edit INSTALL.Linux to include
> > FreeBSD i
Thanks for the review. I applied this to master.
On Thu, Jul 12, 2012 at 08:55:05AM -0700, Gurucharan Shetty wrote:
> Looks good to me.
>
> On Thu, Jul 12, 2012 at 8:43 AM, Ben Pfaff wrote:
>
> > Reported-by: Kris zhang
> > Signed-off-by: Ben Pfaff
> > ---
> > AUTHORS |
On Thu, Jul 12, 2012 at 09:12:10AM +0900, Simon Horman wrote:
> One thing that I do have a problem with is the correct treatment of the CFI
> bit in the value and mask when decoded from an OXMi VLAN_VID match. So far
> I have come up with four possible solutions.
>
> 1. Require it to always be se
Looks good to me.
On Thu, Jul 12, 2012 at 8:43 AM, Ben Pfaff wrote:
> Reported-by: Kris zhang
> Signed-off-by: Ben Pfaff
> ---
> AUTHORS |1 +
> utilities/ovs-vsctl.8.in |8 +++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/AUTHORS b/AUTHORS
Reported-by: Kris zhang
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
utilities/ovs-vsctl.8.in |8 +++-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 2c1a48c..bdc827c 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -128,6 +128,7 @@ Kevin M
Thanks, I pushed this to master.
On Thu, Jul 12, 2012 at 08:24:46AM -0700, Gurucharan Shetty wrote:
> Looks good to me.
>
> On Thu, Jul 12, 2012 at 8:08 AM, Ben Pfaff wrote:
>
> > The previous text was ambiguous.
> >
> > Reported-by: Konstantin Khorenko
> > CC: Jesse Gross
> > Signed-off-by:
Looks good to me.
On Thu, Jul 12, 2012 at 8:08 AM, Ben Pfaff wrote:
> The previous text was ambiguous.
>
> Reported-by: Konstantin Khorenko
> CC: Jesse Gross
> Signed-off-by: Ben Pfaff
> ---
> AUTHORS |1 +
> FAQ | 16 ++--
> 2 files changed, 11 insertions(+), 6 deletio
The previous text was ambiguous.
Reported-by: Konstantin Khorenko
CC: Jesse Gross
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
FAQ | 16 ++--
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 1ed820c..2c1a48c 100644
--- a/AUTHORS
+++ b/
On Thu, Jul 12, 2012 at 01:31:49PM +0100, Zoltan Kiss wrote:
> The value represented by the macro would stay exactly the same.
> See this article about this topic:
>
> http://embeddedgurus.com/barr-code/2011/06/is-uint16_t-1-portable-c-code/
This article is wrong. (uint16_t) -1 is guaranteed to
The value represented by the macro would stay exactly the same.
See this article about this topic:
http://embeddedgurus.com/barr-code/2011/06/is-uint16_t-1-portable-c-code/
Signed-off-by: Zoltan Kiss
---
lib/odp-util.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/li
Option --ovs is added for ovs-bugtool command to collect
only OpenvSwitch relevant information. To perform
filtering in plugins, a new xml attribute filters="ovs" (optional)
would be required in element 'command','files','directory' in
openvswitch.xml. Value of 'filters' attribute will be compared
Indeed, my fault, I've hit make on the wrong branch.
On 11/07/12 19:29, Jesse Gross wrote:
On Wed, Jul 11, 2012 at 11:03 AM, Zoltan Kiss wrote:
This is just a small cosmetic change to express what that value means.
Signed-off-by: Zoltan Kiss
Your patch doesn't compile because OVSP_NONE is
Reworked and its present in v3. Also updated ovs-bugtool manual file.
Comments inline.
From: Reid Price
Date: Wed, 11 Jul 2012 12:00:02 -0700
To: Arun Sharma
Cc:
Subject: Re: [ovs-dev] [PATCH v2] ovs-bugtool: Added --ovs option to get
only ovs related information
Thanks for the fixes! A
Recently released CentOS 6.3 (and probably also RHEL 6.3, I assume)
backported skb_frag_page() and others to their 2.6.32-based kernel,
which caused build failure of Open vSwitch kernel modules.
Signed-off-by: Tadaaki Nagao
---
acinclude.m4 |1 +
datapath/linu
Hi,
I noticed that recently released CentOS 6.3 (and probably also RHEL
6.3, I assume) backported skb_frag_page() to their 2.6.32-based
kernel, which prevented Open vSwitch kernel modules from building.
I'll send a patch I made to aid this build issue.
I'd really appreciate it if you kindly take
On Tue, Jun 26, 2012 at 05:02:22PM -0700, ravi kerur wrote:
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 7b86f80..319033c 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
...
> @@ -5125,6 +5132,76 @@ compose_dec_ttl(struct action_xlate_ctx *ctx)
> }
>
54 matches
Mail list logo
