On Thu, Jul 12, 2012 at 02:46:37PM -0500, Ethan Jackson wrote: > There's some trailing whitespace in this patch.
Oops, fixex. > s/consisten/consistent/ Fixed too, thanks. > Thanks for adding unit tests. Does it make sense to add one that > sorts by multiple fields specified on the command line? Perhaps adding > a sort by in_port to the test which does tp_src would give us slightly > better coverage. I can't take credit for the unit tests. Arun wrote them. I did add a bit to them. > Is there any particular reason not to always sort based on priority > even if neither sort nor rsort are specified? I suppose it's slightly > less efficient, but I'm not sure that matters in particular. I think > it would cleanup the code every so slightly because we wouldn't have > to special case n_criteria = 0. I like having a mode where we get a raw dump of what the switch sent. You might be right that sorting on priority is the right default, and that some option like --sort=none would be needed to disable sorting. We can talk about that, if you like. I'll push this series in a bit. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
