On Thu, Jul 12, 2012 at 09:12:10AM +0900, Simon Horman wrote: > One thing that I do have a problem with is the correct treatment of the CFI > bit in the value and mask when decoded from an OXMi VLAN_VID match. So far > I have come up with four possible solutions. > > 1. Require it to always be set except in the case of OFPVID12_NONE > 2. Require it to always be clear except in the case of OFPVID12_PRESENT > - I believe that this is how things need to be handled internally > 3. Ignore the CFI bit except in the case of OFPVID12_NONE and > OFPVID12_PRESENT. > 4. Honour the CFI bit.
You raise a good question. I think that option #4 is most flexible. It would allow a controller, for example, to match bits 0-11 against all-zeros and wildcard bit 12 (the CFI bit), which would presumably match both packets without a VLAN tag and packets with a VLAN tag for VLAN 0. I didn't understand your comment on option #2, but I didn't think about it for too long. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
