On Thu, Jun 14, 2012 at 08:51:48AM +0900, Simon Horman wrote:
> these patches are based on the 20 Open Flow 1.1 patches that you sent
> about a day ago now.
>
> They are all compile tested only. I did have some of the messages working
> to a limited extent yesterday, prior to rebasing on your patc
On Thu, Jun 14, 2012 at 08:51:53AM +0900, Simon Horman wrote:
> Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod()
>
> Note that ofputil_protocol_from_ofp_version() needs to be made
> Open Flow 1.1 aware.
>
> Signed-off-by: Simon Horman
This seems ugly but I don't hav
On Thu, Jun 14, 2012 at 08:51:52AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
s/oputil/ofputil/
I'd be happier to have a more generic function: one that accepted a
"protocol" parameter and used the correct match type based on the
protocol. Not a big deal to factor that in later, t
> Also introduces a couple of test failures. The first is trivially fixable:
>
> # -*- compilation -*-
> 128. ofp-errors.at:81: testing decoding OFPBIC_* experimenter errors ...
> ../../tests/ofp-errors.at:83: ovs-ofctl ofp-print '02010014 00030005
> 010200081
On Wed, Jun 13, 2012 at 10:58:56PM -0700, Ben Pfaff wrote:
> On Thu, Jun 14, 2012 at 08:51:49AM +0900, Simon Horman wrote:
> > Add OFPUTIL_P_OF12, NXPIF_OPENFLOW12 and NXFF_OPENFLOW12 for Open Flow 1.2
> >
> > OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
> > OFPUTIL_P_OF12
On Thu, Jun 14, 2012 at 08:51:49AM +0900, Simon Horman wrote:
> Add OFPUTIL_P_OF12, NXPIF_OPENFLOW12 and NXFF_OPENFLOW12 for Open Flow 1.2
>
> OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
> OFPUTIL_P_OF12 supports the use of table ids in modify flow messages.
>
> Signed-of
On Wed, Jun 13, 2012 at 06:12:17PM -0700, Ethan Jackson wrote:
> String to string maps are used all over the Open vSwitch database.
> Before this patch, they were implemented in the idl as parallel
> string arrays. This strategy has proven a bit cumbersome. With
> this patch, string to strong map
On Wed, Jun 13, 2012 at 8:38 PM, Jesse Gross wrote:
> On Thu, Jun 14, 2012 at 9:37 AM, Ben Pfaff wrote:
>> On Wed, Jun 13, 2012 at 09:55:36PM +0900, Jesse Gross wrote:
>>> If we go with what you have now, I'm fairly confident that we will
>>> regret it in the future. The kernel code used to mor
I did when I wrote it originally a couple of weeks ago, but I haven't
recently. I'll try it again before merging.
Ethan
On Wed, Jun 13, 2012 at 9:30 PM, Ben Pfaff wrote:
> On Wed, Jun 13, 2012 at 06:12:15PM -0700, Ethan Jackson wrote:
>> Before this patch, the VLAN splinter memory management op
On Wed, Jun 13, 2012 at 9:24 PM, ravi kerur wrote:
> On Wed, Jun 13, 2012 at 7:58 PM, Jesse Gross wrote:
>> On Thu, Jun 14, 2012 at 4:51 AM, ravi kerur wrote:
>>> Ok got it. At least I am sensing that OVS will/should be optimized for
>>> both core and edge cases. I have taken care of comments fr
On Wed, Jun 13, 2012 at 06:12:16PM -0700, Ethan Jackson wrote:
> A smap is a string to string hash map. It has a cleaner interface
> than shash's which were traditionally used for the same purpose.
> This patch implements the data structure, and changes netdev and
> its providers to use it.
>
> S
On Wed, Jun 13, 2012 at 06:12:15PM -0700, Ethan Jackson wrote:
> Before this patch, the VLAN splinter memory management operated on
> blocks of memory instead of ovsrec_ports. This strategy is
> problematic in future patches when more than simply calling
> 'free()' needs to be done to destroy spli
On Wed, Jun 13, 2012 at 8:21 PM, Jesse Gross wrote:
> On Thu, Jun 14, 2012 at 9:25 AM, Pravin Shelar wrote:
>> On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
>>> I spent a fair amount of time thinking about this today and concluded that
>>> neither option is very attractive as is.
>>>
>>>
On Wed, Jun 13, 2012 at 7:58 PM, Jesse Gross wrote:
> On Thu, Jun 14, 2012 at 4:51 AM, ravi kerur wrote:
>> Ok got it. At least I am sensing that OVS will/should be optimized for
>> both core and edge cases. I have taken care of comments from Pravin
>> and I think we are waiting for Ben's input o
On Thu, Jun 14, 2012 at 9:37 AM, Ben Pfaff wrote:
> On Wed, Jun 13, 2012 at 09:55:36PM +0900, Jesse Gross wrote:
>> If we go with what you have now, I'm fairly confident that we will
>> regret it in the future. The kernel code used to more directly
>> implement various features and prior to ups
With this change there is no need to restart the DB or OVS on configuring a
different value for the manager or controller connection respectively. On
detecting a change in the dscp value on the socket, the previous socket is
closed and a new socket is created and connection is established with the
On Thu, Jun 14, 2012 at 9:25 AM, Pravin Shelar wrote:
> On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
>> I spent a fair amount of time thinking about this today and concluded that
>> neither option is very attractive as is.
>>
>> If we go with what you have now, I'm fairly confident that w
On Thu, Jun 14, 2012 at 4:51 AM, ravi kerur wrote:
> Ok got it. At least I am sensing that OVS will/should be optimized for
> both core and edge cases. I have taken care of comments from Pravin
> and I think we are waiting for Ben's input on ttl handling?
It's not a question of optimization. If
On Thu, Jun 14, 2012 at 09:58:08AM +0900, Simon Horman wrote:
> On Tue, Jun 12, 2012 at 12:32:16AM -0700, Ben Pfaff wrote:
> > OpenFlow actions have always been somewhat awkward to handle.
> > Moreover, over time we've started creating actions that require more
> > complicated parsing. When we mai
String to string maps are used all over the Open vSwitch database.
Before this patch, they were implemented in the idl as parallel
string arrays. This strategy has proven a bit cumbersome. With
this patch, string to strong maps are implemented using the smap
library.
Signed-off-by: Ethan Jackson
Before this patch, the VLAN splinter memory management operated on
blocks of memory instead of ovsrec_ports. This strategy is
problematic in future patches when more than simply calling
'free()' needs to be done to destroy splinter ports. This patch
solves the problem by keeping track of entire o
On Tue, Jun 12, 2012 at 12:32:16AM -0700, Ben Pfaff wrote:
> OpenFlow actions have always been somewhat awkward to handle.
> Moreover, over time we've started creating actions that require more
> complicated parsing. When we maintain those actions internally in
> their wire format, we end up parsi
On Thu, Jun 14, 2012 at 08:51:53AM +0900, Simon Horman wrote:
> Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod()
>
> Note that ofputil_protocol_from_ofp_version() needs to be made
> Open Flow 1.1 aware.
>
> Signed-off-by: Simon Horman
> ---
> lib/ofp-print.c | 10 ++
On Thu, Jun 14, 2012 at 08:52:07AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
> ---
> lib/ofp-util.c | 56 +---
> 1 file changed, 45 insertions(+), 11 deletions(-)
>
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index 2bc0af0..
On Wed, Jun 13, 2012 at 09:55:36PM +0900, Jesse Gross wrote:
> If we go with what you have now, I'm fairly confident that we will
> regret it in the future. The kernel code used to more directly
> implement various features and prior to upstreaming we broke many
> of them down. I'm happy with
On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
> On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
>
>> Thanks Pravin for the review comments. Inline
>>
>> On Tue, Jun 12, 2012 at 5:31 PM, Pravin Shelar wrote:
>>> Hi Ravi,
>>>
>>> I see following issues with datapath mpls support:
>>>
>>> Ac
On Wed, Jun 13, 2012 at 04:53:47PM -0700, Ben Pfaff wrote:
> On Wed, Jun 13, 2012 at 05:54:38PM +0900, Simon Horman wrote:
> > Add OFPUTIL_P_OF12, NXPIF_OPENFLOW12 and NXFF_OPENFLOW12 for Open Flow 1.2
> >
> > OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
> > OFPUTIL_P_OF12 s
On Wed, Jun 13, 2012 at 05:54:38PM +0900, Simon Horman wrote:
> Add OFPUTIL_P_OF12, NXPIF_OPENFLOW12 and NXFF_OPENFLOW12 for Open Flow 1.2
>
> OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
> OFPUTIL_P_OF12 supports the use of table ids in modify flow messages.
Right, that's
OFPG11_ANY may be used as the out_gropu for ofp11_flow_mod and
ofp11_flow_stats_request.
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.1.h | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/include/openflow/openflow-1.1.h b/include/openflow/open
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 760ec85..e3d6703 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1537,6 +1537,17 @@ ofputil_make_flow_mod_table_id(bool flow_mod_table_id)
Add OFPUTIL_P_OF12, NXPIF_OPENFLOW12 and NXFF_OPENFLOW12 for Open Flow 1.2
OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
OFPUTIL_P_OF12 supports the use of table ids in modify flow messages.
Signed-off-by: Simon Horman
---
include/openflow/nicira-ext.h | 10 ++
li
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 56 +---
1 file changed, 45 insertions(+), 11 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 2bc0af0..1fc6dc6 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -2408,6 +2408,24
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 82 ++
1 file changed, 59 insertions(+), 23 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 1b31b8a..2bc0af0 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1596,6 +1596,
This may be used by both ofputil_decode_flow_mod() and
ofputil_decode_packet_in()
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 43 ++-
lib/ofp-util.h | 5 +
2 files changed, 43 insertions(+), 5 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-u
Open Flow 1.2, like Open Flow 1.1, has OFPC11_GROUP_STATS.
All other Open Flow 1.2 capabilities are handled by
ofputil_capabilities_mask() which is used by both
ofputil_decode_switch_features() and ofputil_encode_switch_features().
No update to ofputil_encode_switch_features() is required
to supp
There are capabilities which are present in one, two and three
of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
capabilities that are prsent in all three Open Flow versions and
add ofputil_capabilities_mask() to return the mask of capabilities
for each version.
This does not cover
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index c6294aa..880e92b 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3124,7 +3124,7 @@ ofputil_encode_port_mod(const struct ofputil_port_mod *p
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 880e92b..d0e1b9a 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -820,6 +820,8 @@ static const struct ofputil_msg_type ofputil_msg_types[
* OFPUTIL_C_ARP_MATCH_IP is not present in Open Flow 1.2.
* OFPUTIL_C_PORT_BLOCKED is new in Open Flow 1.2.
Otherwise the Open Flow 1.2 capabilities are the same as those of
Open Flow 1.1.
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 1 +
lib/ofp-util.h | 9 +++--
2 files changed, 8 i
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 8d8c525..4a4822c 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -810,6 +810,18 @@ static const struct ofputil_msg_type ofp
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 332f2ca..c6294aa 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1953,6 +1953,23 @@ ofputil_encode_flow_stats_request(const struct
ofpu
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 4a4822c..332f2ca 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -2313,6 +2313,23 @@ ofputil_encode_flow_removed(const struct
ofputil_fl
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 28
1 file changed, 28 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 7628417..84bee2d 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1714,6 +1714,34 @@ ofputil_encode_flow_mod(const struct ofpu
This is just a hack to change the way that ofputil_pull_ofp11_match() works
to what I believe to be a more correct version before adding feature
changes to the same function.
This change should either be dropped or rolled into Ben Pfaff's patch
that adds ofputil_pull_ofp11_match().
---
lib/ofp-ut
Reduce scope of per-protocol variables in ofputil_encode_flow_mod()
These variables are only needed in one of the cases covered by the switch
statement and will increase in number as more cases (protocols) are
supported.
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 14 +-
1 file
Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod()
Note that ofputil_protocol_from_ofp_version() needs to be made
Open Flow 1.1 aware.
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/lib/ofp-print.c b/lib
Hi Ben,
these patches are based on the 20 Open Flow 1.1 patches that you sent
about a day ago now.
They are all compile tested only. I did have some of the messages working
to a limited extent yesterday, prior to rebasing on your patches and with
some local hacks in place - notably to use Open FL
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 4cf4734..87b2978 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -1370,6 +1370,9 @@ ofp_to_string__(const struct ofp_header *oh,
case OFP11_VER
On Thu, Jun 07, 2012 at 06:04:44PM -0700, Mehak Mahajan wrote:
> With this change there is no need to restart the DB or OVS on configuring a
> different value for the manager or controller connection respectively. On
> detecting a change in the dscp value on the socket, the previous socket is
> clo
With this change there is no need to restart the DB or OVS on configuring a
different value for the manager or controller connection respectively. On
detecting a change in the dscp value on the socket, the previous socket is
closed and a new socket is created and connection is established with the
Hello,
how are you doing today? i hope all is well.
My name is blessing., In search of a man who understand the meaning of love as
Trust and faith in each other rather than one who sees love as the only way of
fun, but a matured Man with Nice Vision of what the world is all about, and
after read
Would you mind changing "const" to "constant" in the commit message?
On reading it I had thought you were removing a const pointer.
Looks good thanks,
Ethan
On Wed, Jun 13, 2012 at 1:53 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto.c | 3 ---
> 1 files changed, 0 i
Bonjour à vous
Je m'adresse ainsi à vous, pour l'urgence de la situation. Aussi serai-je brève
et directe en raison de mon état de santé.
Je vous écris dans le but d’obtenir votre collaboration sincère et votre
implication personnelle pour la réalisation d'une affaire urgente. Je sollicite
votre
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index dee2cbc..b0b5afb 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -117,7 +117,6 @@ struct ofoperation {
struct hmap_n
Looks good, thanks.
Ethan
On Wed, Jun 13, 2012 at 1:26 PM, Ben Pfaff wrote:
> Otherwise if you run "check-valgrind" in a tree where you've never run
> "check", you get some test failures because some data files don't get
> generated before the tests run.
>
> Signed-off-by: Ben Pfaff
> ---
> te
Otherwise if you run "check-valgrind" in a tree where you've never run
"check", you get some test failures because some data files don't get
generated before the tests run.
Signed-off-by: Ben Pfaff
---
tests/automake.mk |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/t
Looks good, thanks.
Ethan
On Tue, May 22, 2012 at 5:19 PM, Ben Pfaff wrote:
> This code will have another user in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/daemon.c | 27 ++-
> lib/daemon.h | 1 +
> 2 files changed, 23 insertions(+), 5 deletions(
Looks good, thanks.
Ethan
On Tue, May 22, 2012 at 5:19 PM, Ben Pfaff wrote:
> This function will be useful in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/daemon.c | 33 +++--
> lib/daemon.h | 2 ++
> 2 files changed, 29 insertions(+), 6 deletio
Looks good, thanks.
Ethan
On Tue, May 22, 2012 at 5:19 PM, Ben Pfaff wrote:
> This will be more useful later when we introduces "worker" subprocesses.
> I don't have any current plans to introduce threading, but I can't
> think of a disadvantage to wording this in a general manner.
>
> Signed-of
> + retval = recvmsg(sock, &msg, 0);
> + } while (retval < 0 && errno == EINTR);
> + if (retval <= 0) {
> + return retval < 0 ? -errno : 0;
> + }
> +
> + for (p = CMSG_FIRSTHDR(&msg); p; p = CMSG_NXTHDR(&msg, p)) {
> + if (p->cmsg_level != SOL_SOCKET || p->cmsg_type
Ok got it. At least I am sensing that OVS will/should be optimized for
both core and edge cases. I have taken care of comments from Pravin
and I think we are waiting for Ben's input on ttl handling?
There are additional things that needs to be addressed as well
1. offload code review, it's curren
On Thu, Jun 14, 2012 at 1:32 AM, ravi kerur wrote:
> On Wed, Jun 13, 2012 at 8:49 AM, Jesse Gross wrote:
>> On Thu, Jun 14, 2012 at 12:04 AM, ravi kerur wrote:
>>> On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
> On Tue, Jun 12, 201
On Wed, Jun 13, 2012 at 8:49 AM, Jesse Gross wrote:
> On Thu, Jun 14, 2012 at 12:04 AM, ravi kerur wrote:
>> On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
>>> On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
On Tue, Jun 12, 2012 at 5:31 PM, Pravin Shelar wrote:
> TTL actions:
>>>
Yes kernel flow_extract finds the tag when kernel module is loaded and
works fine. Its only with userspace + vlan.
On Wed, Jun 13, 2012 at 8:22 AM, Jesse Gross wrote:
> On Wed, Jun 13, 2012 at 6:49 AM, ravi kerur wrote:
>> I am facing an issue in flow matching for incoming vlan packets in ovs
>>
Thanks, I pushed this all over.
On Tue, Jun 12, 2012 at 04:53:57PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Tue, Jun 12, 2012 at 4:45 PM, Ben Pfaff wrote:
> > Found by valgrind.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/vlog.c | 9 -
> > 1 files cha
On Thu, Jun 14, 2012 at 12:04 AM, ravi kerur wrote:
> On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
>> On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
>>> On Tue, Jun 12, 2012 at 5:31 PM, Pravin Shelar wrote:
TTL actions:
As Jesse has mentioned before there could be one Set acti
On Wed, Jun 13, 2012 at 6:49 AM, ravi kerur wrote:
> I am facing an issue in flow matching for incoming vlan packets in ovs
> userspace. In lib/flow.c and flow_extract function, eth->eth_type(line
> no 363) is eth_type_ip. From logs, I see
>
> Jun 12 14:43:43 rkerur-thinkpad-t500 ovs-vswitchd:
> i
Inline
On Wed, Jun 13, 2012 at 5:55 AM, Jesse Gross wrote:
> On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
>
>> Thanks Pravin for the review comments. Inline
>>
>> On Tue, Jun 12, 2012 at 5:31 PM, Pravin Shelar wrote:
>>> Hi Ravi,
>>>
>>> I see following issues with datapath mpls support:
>
On Wed, Jun 13, 2012 at 11:39 PM, Luiz Ozaki wrote:
> On 5/25/12 5:31 PM, Jesse Gross wrote:
>>
>> On Fri, May 25, 2012 at 11:59 AM, Luiz Ozaki
>> wrote:
>>>
>>> On 5/25/12 11:05 AM, Jesse Gross wrote:
No, the caller will perform that check. rpl_skb_gso_segment() is a
compatibility
On 5/25/12 5:31 PM, Jesse Gross wrote:
On Fri, May 25, 2012 at 11:59 AM, Luiz Ozaki wrote:
On 5/25/12 11:05 AM, Jesse Gross wrote:
No, the caller will perform that check. rpl_skb_gso_segment() is a
compatibility replacement for skb_gso_segment() on older kernels. It needs
to return a pointer,
On Jun 13, 2012, at 12:12 PM, ravi kerur wrote:
> Thanks Pravin for the review comments. Inline
>
> On Tue, Jun 12, 2012 at 5:31 PM, Pravin Shelar wrote:
>> Hi Ravi,
>>
>> I see following issues with datapath mpls support:
>>
>> Actions:
>> I do not see skb->csum updated when mpls action is
On Tue, Jun 12, 2012 at 12:32:24AM -0700, Ben Pfaff wrote:
> A work in progress. Doesn't build.
>
> I'm not really sure I want separate OFPUTIL_ constants for OF1.0 and OF1.1
> versions of each message. It's something I'm trying out as I write the
> code.
>
> Signed-off-by: Ben Pfaff
> ---
[s
72 matches
Mail list logo
