Re: [ovs-dev] [PATCH] util: New function set_program_name_version().

2012-04-05 Thread Ben Pfaff
On Sun, Apr 01, 2012 at 04:04:40PM -0700, Ethan Jackson wrote: > With this function, users of the Open vSwitch libraries which > should not have the same version as Open vSwitch can manually set a > version number. > > Signed-off-by: Ethan Jackson Did you really send this on April 1? ___

[ovs-dev] [PATCH] util: New function set_program_name_version().

2012-04-05 Thread Ethan Jackson
With this function, users of the Open vSwitch libraries which should not have the same version as Open vSwitch can manually set a version number. Signed-off-by: Ethan Jackson --- lib/util.c | 22 ++ lib/util.h |8 ++-- 2 files changed, 24 insertions(+), 6 deletions(

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Simon Horman
On Thu, Apr 05, 2012 at 07:11:36PM -0700, Jesse Gross wrote: > On Thu, Apr 5, 2012 at 7:05 PM, Simon Horman wrote: > > On Thu, Apr 05, 2012 at 06:47:23PM -0700, Jesse Gross wrote: > >> On Thu, Apr 5, 2012 at 5:35 PM, Simon Horman wrote: > >> > On Thu, Apr 05, 2012 at 05:00:12PM -0700, Jesse Gross

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Jesse Gross
On Thu, Apr 5, 2012 at 7:05 PM, Simon Horman wrote: > On Thu, Apr 05, 2012 at 06:47:23PM -0700, Jesse Gross wrote: >> On Thu, Apr 5, 2012 at 5:35 PM, Simon Horman wrote: >> > On Thu, Apr 05, 2012 at 05:00:12PM -0700, Jesse Gross wrote: >> >> On Wed, Apr 4, 2012 at 6:08 PM, Simon Horman wrote: >>

Re: [ovs-dev] [PATCH 2/3] [RFC] datapath: tunnelling: Pass l4_offset to update_header callback

2012-04-05 Thread Simon Horman
On Thu, Apr 05, 2012 at 05:34:21PM -0700, Jesse Gross wrote: > On Tue, Apr 3, 2012 at 10:14 PM, Simon Horman wrote: > > The STT protocol's header includes a field for the offset > > to the start of the l4 header. It seems that this > > is the value of the transport_offset of the original SKB and >

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Simon Horman
On Thu, Apr 05, 2012 at 06:47:23PM -0700, Jesse Gross wrote: > On Thu, Apr 5, 2012 at 5:35 PM, Simon Horman wrote: > > On Thu, Apr 05, 2012 at 05:00:12PM -0700, Jesse Gross wrote: > >> On Wed, Apr 4, 2012 at 6:08 PM, Simon Horman wrote: > >> > diff --git a/include/linux/tcp.h b/include/linux/tcp.

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Jesse Gross
On Thu, Apr 5, 2012 at 5:35 PM, Simon Horman wrote: > On Thu, Apr 05, 2012 at 05:00:12PM -0700, Jesse Gross wrote: >> On Wed, Apr 4, 2012 at 6:08 PM, Simon Horman wrote: >> > diff --git a/include/linux/tcp.h b/include/linux/tcp.h >> > index 3c7ffdb..36e794b 100644 >> > --- a/include/linux/tcp.h >

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ethan Jackson
Thanks, this looks good to me. > +            if (rmp->mpid == cfm->mpid) { > +               cfm_fault |= CFM_FAULT_LOOPBACK; > +                VLOG_WARN_RL(&rl,"%s: received CCM with local MPID" > +                             " %"PRIu64, cfm->name, rmp->mpid); > +            } The indentatio

[ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Mehak Mahajan
The CFM packets that are out of sequence or contain invalid cfm_interval were previously not ignored. The behavior is changed with this patch to not process those CFM frames. Signed-off-by: Mehak Mahajan --- lib/cfm.c| 61 ++--- lib/cfm.h

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Simon Horman
On Thu, Apr 05, 2012 at 05:00:12PM -0700, Jesse Gross wrote: > On Wed, Apr 4, 2012 at 6:08 PM, Simon Horman wrote: > > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > > index 3c7ffdb..36e794b 100644 > > --- a/include/linux/tcp.h > > +++ b/include/linux/tcp.h > > @@ -472,6 +472,11 @@ struc

Re: [ovs-dev] [PATCH 2/3] [RFC] datapath: tunnelling: Pass l4_offset to update_header callback

2012-04-05 Thread Jesse Gross
On Tue, Apr 3, 2012 at 10:14 PM, Simon Horman wrote: > The STT protocol's header includes a field for the offset > to the start of the l4 header. It seems that this > is the value of the transport_offset of the original SKB and > making that value available to the update_header callback avoids > S

Re: [ovs-dev] [PATCH 1/3] [RFC] datapath: tunneling: Allow vlan_tci to be passed to ovs_tnl_rcv()

2012-04-05 Thread Jesse Gross
On Tue, Apr 3, 2012 at 10:14 PM, Simon Horman wrote: > The STT protocol allows a VLAN TCI to be passed as part of the > STT header.  It seems appropriate to pass this TCI to ovs_tnl_rcv() > and for other tunneling protocols to pass 0 to retain their existing > behaviour. > > Signed-off-by: Simon H

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Mehak Mahajan
Hey, Thank Ben and Ethan for your comments. I have taken care of them. We are now setting all possible faults when we get the heartbeat message. thanx! mehak On Thu, Apr 5, 2012 at 4:00 PM, Ethan Jackson wrote: > > -rmp->recv = true; > > -if (!fault) { > > +

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Jesse Gross
On Wed, Apr 4, 2012 at 6:08 PM, Simon Horman wrote: > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index 3c7ffdb..36e794b 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -472,6 +472,11 @@ struct tcp_sock { >         * contains related tcp_cookie_transactions fields.

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ethan Jackson
> -            rmp->recv = true; > -            if (!fault) { > +            if (!cfm_fault && !ccm_rdi) { >                 rmp->num_health_ccm++; >             } > +            if (!cfm_fault) { > +                rmp->recv = true; > +            } > +            cfm->recv_fault |= cfm_fault; I

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 03:41:45PM -0700, Ethan Jackson wrote: > > That sounds even better, because the CFM object would signal RDI > > immediately without waiting for the next fault check. > > No actually this data only changes on fault checks. Ah, you're right, of course. __

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ethan Jackson
> No actually this data only changes on fault checks. i.e. it's only written to the database on fault checks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ethan Jackson
> That sounds even better, because the CFM object would signal RDI > immediately without waiting for the next fault check. No actually this data only changes on fault checks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 03:32:50PM -0700, Ethan Jackson wrote: > > It looks like rdi gets updated on every CCM packet receive, so that if > > we receive a CCM without RDI after one with it between fault checks, > > cfm_run() won't report the RDI.  I wonder whether we should actually > > only reset

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ethan Jackson
> It looks like rdi gets updated on every CCM packet receive, so that if > we receive a CCM without RDI after one with it between fault checks, > cfm_run() won't report the RDI.  I wonder whether we should actually > only reset rdi to false in cfm_run() and only set it to true, never to > false, in

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 03:12:21PM -0700, Mehak Mahajan wrote: > The CFM packets that are out of sequence or contain invalid cfm_interval were > previously not ignored. The behavior is changed with this patch to not > process those CFM frames. > > Signed-off-by: Mehak Mahajan I guess Ethan ought

[ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-05 Thread Mehak Mahajan
The CFM packets that are out of sequence or contain invalid cfm_interval were previously not ignored. The behavior is changed with this patch to not process those CFM frames. Signed-off-by: Mehak Mahajan --- lib/cfm.c| 21 ++--- lib/cfm.h|4 +++- vsw

Re: [ovs-dev] [PATCH] datapath: tunnelling: capwap: UDP_ENCAP_CAPWAP is an abitrary value

2012-04-05 Thread Jesse Gross
On Tue, Apr 3, 2012 at 10:06 PM, Simon Horman wrote: > It seems to me that as the value of UDP_ENCAP_CAPWAP is hardcoded > it would be more appropriate to describe it as arbitrary than > random. > > Signed-off-by: Simon Horman Applied, thanks. ___ dev

Re: [ovs-dev] [PATCH v2] bugtool - Collect version information for all running Open vSwitch daemons.

2012-04-05 Thread Ben Pfaff
On Wed, Apr 04, 2012 at 02:19:18PM -0700, Ben Pfaff wrote: > On Wed, Apr 04, 2012 at 01:23:19PM -0700, Arun Sharma wrote: > > This is an improvement in {ovs|xen}-bugtool archive output to determine the > > version which was running for all the OVS daemons. It is implemented as a > > plugin which in

Re: [ovs-dev] [PATCH] Granular link health statistics for cfm.

2012-04-05 Thread Ben Pfaff
On Wed, Apr 04, 2012 at 06:46:20PM -0700, Mehak Mahajan wrote: > The changes display the cfm_health of an interface. The cfm_health > is an exponential weighted moving average of the health of all > remote_mpids. The value can vary from 0 to 100, 100 being very healthy > and 0 being unhealthy. >

Re: [ovs-dev] [PATCH 1/2] datapath: Do not send success message when OVS_VPORT_CMD_SET command fails

2012-04-05 Thread Jesse Gross
On Wed, Apr 4, 2012 at 10:44 AM, Ansis Atteka wrote: > On Mon, Mar 26, 2012 at 11:21 AM, Jesse Gross wrote: >> >> On Fri, Mar 23, 2012 at 6:04 PM, Ansis Atteka wrote: >> > diff --git a/datapath/datapath.c b/datapath/datapath.c >> > index d64fc32..daf7b69 100644 >> > --- a/datapath/datapath.c >>

[ovs-dev] (no subject)

2012-04-05 Thread Mr.Vincent Cheng Hoi
Good day, I am Mr.Vincent Cheng Hoi Chuen, GBS, JP Chairman of the Hong Kong and Shanghai Banking Corporation Limited. I have a business proposal of USD $22,500,000.00. Your earliest response to this letter will be appreciated. Best Regards, Mr.Vincent Cheng Hoi.

Re: [ovs-dev] [ovs-discuss] Problem with KVM Creating Bridge

2012-04-05 Thread Ansis Atteka
On Wed, Apr 4, 2012 at 10:45 PM, Jon wrote: > Hello, > > Thanks for the reply. > > Here are the logs from that day, > Apr 03 08:56:31|1|vlog|INFO|opened log file > /var/log/openvswitch/ovs-brcompatd.log > Apr 03 11:51:10|2|brcompatd|WARN|ovs-vsctl exited (exit status 1) > Apr 03 11:51:10

Re: [ovs-dev] [PATCH] [RFC] [linux kernel patch] Add TCP encap_rcv hook

2012-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 10:08:42AM +0900, Simon Horman wrote: > On Wed, Apr 04, 2012 at 09:10:52AM -0700, Ben Pfaff wrote: > > On Wed, Apr 04, 2012 at 02:15:00PM +0900, Simon Horman wrote: > > > This hook is based on a hook of the same name provided by UDP. It > > > provides > > > a way for to re

Re: [ovs-dev] How does the datapath flowtable works, datapath learns from vswitchd or utilize the flow table in the kernel?

2012-04-05 Thread Jesse Gross
On Wed, Apr 4, 2012 at 9:35 AM, LIU Binghan wrote: > Thanks for your reply, but  how does the userspace make the decision about > flow table clear?  As far as I know, OVS use this function u64 > ovs_flow_used_time()  to calculate the time flow is used, and then submit to > userspace in statistics

Re: [ovs-dev] How dpif-linux query the flow table, and where it maintain the flow table?

2012-04-05 Thread Ben Pfaff
[add original poster] On Thu, Apr 05, 2012 at 07:45:15AM -0700, Ben Pfaff wrote: > On Thu, Apr 05, 2012 at 02:32:55PM +0200, LIU Binghan wrote: > > After datapath provided flow key to dpif-linux through netlink, how > > dpif-linux queries the flow table? > > More specificlly, how does the flow_get

Re: [ovs-dev] How dpif-linux query the flow table, and where it maintain the flow table?

2012-04-05 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 02:32:55PM +0200, LIU Binghan wrote: > After datapath provided flow key to dpif-linux through netlink, how > dpif-linux queries the flow table? > More specificlly, how does the flow_get function get the 'reply' which > contains the action. I am getting stuck here. Why are y

[ovs-dev] How dpif-linux query the flow table, and where it maintain the flow table?

2012-04-05 Thread LIU Binghan
Hi all, I am new for openvswitch world, I am confused about some code. After datapath provided flow key to dpif-linux through netlink, how dpif-linux queries the flow table? More specificlly, how does the flow_get function get the 'reply' which contains the action. I am getting stuck here. dpif