> It looks like rdi gets updated on every CCM packet receive, so that if > we receive a CCM without RDI after one with it between fault checks, > cfm_run() won't report the RDI. I wonder whether we should actually > only reset rdi to false in cfm_run() and only set it to true, never to > false, in cfm_process_heartbeat()?
Actually come to think of it, I don't thing we need the rmp->rdi bit anymore at all. We can simply set the RDI flag in recv_fault during cfm_process_heartbeat() that would get the behavior we desire. The key would be to set the RDI flag in recv_fault only after we've said rmp->recv = true because packets with the RDI flag should be counted as received. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
