Thanks, this looks good to me.
> + if (rmp->mpid == cfm->mpid) {
> + cfm_fault |= CFM_FAULT_LOOPBACK;
> + VLOG_WARN_RL(&rl,"%s: received CCM with local MPID"
> + " %"PRIu64, cfm->name, rmp->mpid);
> + }
The indentation here is incorrect. cfm_fault |= should be one space over.
> + <column name="cfm_fault_status" key="interval">
> + Indicates a CFM fault was triggered due to the reception of a CCM
> + frame having an invalid interval.
> + </column>
> +
> + <column name="cfm_fault_status" key="sequence">
> + Indicates a CFM fault was triggered because the CFM module received
> + a CCM frame with a sequence number that it was not expecting.
> + </column>
Above could you please line up the first and second lines of the
column documentation?
Otherwise looks good to me, no need to resend the patch just for those
changes. You should probably wait for Ben to have a look at it as
well since he had comments on the original patch.
Thanks,
Ethan
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
