On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote:
[snip]
> I don't think experimenter stats are actually different in 1.1 and
> 1.2, although the sections are worded differently.
It seems to me that ofp11_experimenter_stats_header might look like this:
struct ofp11_experimenter_stats_h
On Wed, Mar 28, 2012 at 4:30 PM, Chris Browning wrote:
> First, the kernel module does not support matching on multiple VLAN tags. I
> can ignore this issue for the split horizon layer 2 for the Internet and just
> match on mac address to push_vlan actions mappings, but for joining LAN's
> where I
On Wed, Mar 28, 2012 at 05:12:21PM -0700, Ben Pfaff wrote:
> Thanks Simon.
>
> On Thu, Mar 29, 2012 at 09:04:30AM +0900, Simon Horman wrote:
> > On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote:
> > > I don't think that the ofp12_match structure will really be useful in
> > > this form.
On Wed, Mar 28, 2012 at 05:20:30PM -0700, Ben Pfaff wrote:
> On Thu, Mar 29, 2012 at 09:18:57AM +0900, Simon Horman wrote:
> > On Thu, Mar 29, 2012 at 09:06:36AM +0900, Simon Horman wrote:
> > > On Wed, Mar 28, 2012 at 12:21:18PM -0700, Ben Pfaff wrote:
> > > > On Wed, Mar 28, 2012 at 09:44:16AM +0
On Thu, Mar 29, 2012 at 09:18:57AM +0900, Simon Horman wrote:
> On Thu, Mar 29, 2012 at 09:06:36AM +0900, Simon Horman wrote:
> > On Wed, Mar 28, 2012 at 12:21:18PM -0700, Ben Pfaff wrote:
> > > On Wed, Mar 28, 2012 at 09:44:16AM +0900, Simon Horman wrote:
> > > > Signed-off-by: Simon Horman
> > >
On Thu, Mar 29, 2012 at 09:06:36AM +0900, Simon Horman wrote:
> On Wed, Mar 28, 2012 at 12:21:18PM -0700, Ben Pfaff wrote:
> > On Wed, Mar 28, 2012 at 09:44:16AM +0900, Simon Horman wrote:
> > > Signed-off-by: Simon Horman
> >
> > The comment here is wrong, since it talks about OXM but OXM was
>
Thanks Simon.
On Thu, Mar 29, 2012 at 09:04:30AM +0900, Simon Horman wrote:
> On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote:
> > I don't think that the ofp12_match structure will really be useful in
> > this form. If we just defined an "ofp_match_header" that just
> > contains length
On Wed, Mar 28, 2012 at 12:21:18PM -0700, Ben Pfaff wrote:
> On Wed, Mar 28, 2012 at 09:44:16AM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> The comment here is wrong, since it talks about OXM but OXM was
> introduced in OpenFlow 1.2:
> > +/* The match type indicates the match s
On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote:
> On Wed, Mar 28, 2012 at 09:44:17AM +0900, Simon Horman wrote:
> > This is a first pass at adding include/openflow/openflow-1.2.h to
> > include enum and struct definitions for Open Flow 1.2 that
> > are not already covered by Open Flow 1.
Hi,
I am a Network Engineer/C Developer for a small Telco in New Zealand. We are
very pro Linux based solutions to problems most telco's would normally throw
lots of cash at big brands for.
The specific problem that started me looking to openvswitch for is this:
We get customers delivered to us
Thanks, pushed to master and branch-1.[56]. Not needed for earlier
branches.
On Wed, Mar 28, 2012 at 03:02:06PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Wed, Mar 28, 2012 at 14:58, Ben Pfaff wrote:
> > This could cause a slow but steady memory leak in ovs-vswitchd.
>
On Wed, Mar 28, 2012 at 09:59:23AM -0700, Ben Pfaff wrote:
> On Wed, Mar 28, 2012 at 09:44:15AM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> I'd rather not add ofp10_aggregate_stats_request because it is
> identical to ofp_flow_stats_request with a different name. Would you
> m
On Mar 28, 2012, at 4:18 PM, Ethan Jackson wrote:
>> Could you share with us how you use to debug it? a small example would be
>> sufficient.
>
> I don't have any particular insight in this area beyond trying it. If
> it doesn't work, think about it and figure out why. It's just a
> standard C
Looks good, thanks.
Ethan
On Wed, Mar 28, 2012 at 14:58, Ben Pfaff wrote:
> This could cause a slow but steady memory leak in ovs-vswitchd.
>
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ovsdb-idl.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git
valgrind's memory leak detector considers a pointer to the head of a memory
block to be "definitely" a pointer to that memory block but a pointer to
the interior of a memory block only "possibly" a pointer to that memory
block. Open vSwitch hmap_node and list data structures can go anywhere
inside
When ovsdb-server exits gracefully it frees all the memory that it owns,
which keeps valgrind from warning about "possibly lost" blocks.
Signed-off-by: Ben Pfaff
---
tests/ofproto.at |1 +
tests/ovs-monitor-ipsec.at |2 ++
tests/ovs-vsctl.at |1 +
tests/ovs-xapi-syn
valgrind reports a memory leak and a parameter error in glibc's
timer_create() in almost every program execution. I don't know a way to
avoid them.
Signed-off-by: Ben Pfaff
---
tests/automake.mk |3 ++-
tests/glibc.supp | 16
2 files changed, 18 insertions(+), 1 deletion
All of these leaks are in normally short-lived programs, so none of them
is very important.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-data.c |3 ++-
ovsdb/ovsdb-client.c |9 +
ovsdb/ovsdb-tool.c|4
utilities/ovs-ofctl.c |3 +++
utilities/ovs-vsctl.c |3 +++
This could cause a slow but steady memory leak in ovs-vswitchd.
Found by valgrind.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 19ae16f..5ad3f5c 100644
--- a/lib/ovsdb-idl.c
+++ b/
Only the first patch fixes anything that could really cause problems
(and I'm not certain about that). The rest fix minor issues and
suppress valgrind complaints. With the entire series, I get no
valgrind complaints whatsoever with valgrind with --leak-check=full
(without --show-reachable=yes) on
> Could you share with us how you use to debug it? a small example would be
> sufficient.
I don't have any particular insight in this area beyond trying it. If
it doesn't work, think about it and figure out why. It's just a
standard C program, so GDB and what-not works. There aren't really
any
On Wed, Mar 28, 2012 at 09:44:14AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
Applied. Thank you!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Mar 28, 2012 at 09:44:17AM +0900, Simon Horman wrote:
> This is a first pass at adding include/openflow/openflow-1.2.h to
> include enum and struct definitions for Open Flow 1.2 that
> are not already covered by Open Flow 1.1.
>
> Signed-off-by: Simon Horman
There are still some "uint_t"
On Wed, Mar 28, 2012 at 09:44:16AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
The comment here is wrong, since it talks about OXM but OXM was
introduced in OpenFlow 1.2:
> +/* The match type indicates the match structure (set of fields that compose
> the
> + * match) in use. The ma
Thanks Ethan, for such a quick reply.
Could you share with us how you use to debug it? a small example would be
sufficient.
As it has 2 modules, 1 User (ovs-vswitchd, ofproto ..) 2. Kernel (datapath).
If I changed some code in datapath and I want to see its reflection on user
level. what will be
I would recommend doing the following in order:
1) Use git to clone the source code available at openvswitch.org
2) Read the available documentation. In particular read the README,
DESIGN, INSTALL.Linux, CodyingStyle, and SubmittingPatches files.
3) Following the instructions to build and install
Hi Everyone,
I am Chandra, and looking to contribute as well. Perhaps we can work
together in the initial phase until we ramp up.
Could someone please give us some pointers on how to start. Any
pointers/blogs would be of good help.
Thanks
Chandra
On Wed, Mar 28, 2012 at 11:12 AM, hitesh wadekar
Hello All,
I am Hitesh Wadekar. I am looking forward to contribute to this
http://openvswitch.org/development/openflow-1-x-plan/ .
I am confused where to start. It will be great for me, If someone can
share the process for creating development envionment for OVS as well as
what debugging tool sh
On Wed, Mar 28, 2012 at 09:44:15AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
I'd rather not add ofp10_aggregate_stats_request because it is
identical to ofp_flow_stats_request with a different name. Would you
mind removing it?
Otherwise this looks good.
__
29 matches
Mail list logo
