On Thu, Feb 02, 2012 at 10:00:28PM -0800, Ethan Jackson wrote:
> The 'tp_addr' field name is inappropriate because its not an
> address, it's the transport port. Therefore tp is sufficient.
>
> Signed-off-by: Ethan Jackson
My intention in inventing the dl_, nw_, and tp_ prefixes in struct flow
w
The 'tp_addr' field name is inappropriate because its not an
address, it's the transport port. Therefore tp is sufficient.
Signed-off-by: Ethan Jackson
---
lib/flow.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index 9f83b2c..28637e7 1006
On Feb 2, 2012, at 8:47 PM, Jesse Gross wrote:
> On Tue, Jan 31, 2012 at 10:34 AM, kmestery wrote:
>> I'm curious what the current state of the VXLAN patches for Open vSwitch is.
>> I saw an email from Justin on 1-24-2012 indicating the patches are being
>> reworked at this time. I've gone ahead
I've added the following to NEWS:
- CFM module CCM broadcasts can now be tagged with an 802.1p priority.
I'll merge this now.
Ethan
On Thu, Feb 2, 2012 at 16:15, Ben Pfaff wrote:
> On Thu, Feb 02, 2012 at 04:03:07PM -0800, Ethan Jackson wrote:
>> Bug #9015.
>> Signed-off-by: Ethan Jackson
On Thu, Feb 2, 2012 at 6:58 AM, Pravin B Shelar wrote:
> Use flex array to increase maximum number of vports. Now maximum
> number of vports are limited by flex-array limit (261K for 64-bit)
> per bridge.
>
> Signed-off-by: Pravin B Shelar
>
> Bug #2462
I haven't fully looked through this yet bu
On Thu, Feb 2, 2012 at 6:58 AM, Pravin B Shelar wrote:
> cleanups:
> - removes flex_array_shrink() as there is no caller.
> - add flex_array_init()
> - Add few 'const's.
>
> Signed-off-by: Pravin B Shelar
Since we're going to propose these changes for upstream and we're
goin
On Tue, Jan 31, 2012 at 10:34 AM, kmestery wrote:
> I'm curious what the current state of the VXLAN patches for Open vSwitch is.
> I saw an email from Justin on 1-24-2012 indicating the patches are being
> reworked at this time. I've gone ahead and forward ported the patches from
> last fall wh
Ethan already covered the code part, but just a couple of questions on the
documentation:
> +Bitwise matches on transport ports are rarely useful in isolation, but
> +a group of them can be used to reduce the number of flows required to
> +match on a range of transport ports. For example, suppos
On Thu, Feb 02, 2012 at 04:55:08PM -0800, Ethan Jackson wrote:
> Here's a version without the command line vlog support.
Looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I've merged this.
Ethan
On Thu, Feb 2, 2012 at 16:02, Ben Pfaff wrote:
> On Thu, Feb 02, 2012 at 03:58:16PM -0800, Ethan Jackson wrote:
>> Sounds like a good idea to me. I applied the following incremental.
>
> Looks good to me, thanks.
___
de
Here's a version without the command line vlog support.
---
diff --git a/lib/stp.c b/lib/stp.c
index ba27306..06ac001 100644
--- a/lib/stp.c
+++ b/lib/stp.c
@@ -1068,6 +1068,8 @@ stp_set_port_state(struct stp_port *p, enum stp_state
state)
static void
stp_topology_change_detection(struct stp *s
Thank you for the reviews. I pushed this to master, with the
improvement you pointed out in patch 2.
On Thu, Feb 02, 2012 at 12:46:56PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Jan 27, 2012 at 17:18, Ben Pfaff wrote:
> > Bug #8827.
> > Signed-off-by: Ben Pfaff
> > ---
>
It's not actually a behavioral change, because we have the invariant
that if FWW_NW_PROTO is set then flow->nw_proto is always 0. But it
still *looks* wrong, so I moved the tests for the various IPPROTO_*
values into the "if (!(wc & FWW_NW_PROTO))" block.
Thanks,
Ben.
On Wed, Feb 01, 2012 at 06
I got tired of trying to follow them properly myself.
Signed-off-by: Ben Pfaff
---
INSTALL.XenServer | 53 +---
rhel/automake.mk | 10 ++--
xenserver/automake.mk |9 +++-
xense
Good idea. I made that change and pushed this to master.
On Wed, Feb 01, 2012 at 05:35:38PM -0800, Ethan Jackson wrote:
> Doesn't matter at all, but seems like we'd want to use the range
> 49152–65535 as that's the IANA recommendation for this sort of thing.
>
> Looks good,
> Ethan
>
> On Mon,
Thank you. I pushed this to master.
On Wed, Feb 01, 2012 at 05:19:27PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Jan 27, 2012 at 12:50, Ben Pfaff wrote:
> > This eliminates a kluge that was duplicated in three different daemons.
> >
> > Signed-off-by: Ben Pfaff
> > ---
>
Thank you for the reviews. I pushed this to master.
On Wed, Feb 01, 2012 at 06:13:20PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Jan 27, 2012 at 12:49, Ben Pfaff wrote:
> > Suggestion #9347.
> > Suggested-by: Alan Shieh
> > Signed-off-by: Ben Pfaff
> > ---
> > NEWS
On Thu, Feb 02, 2012 at 11:42:50AM -0800, Justin Pettit wrote:
>
> On Feb 1, 2012, at 5:19 PM, Ben Pfaff wrote:
>
> > On Wed, Feb 01, 2012 at 04:57:35PM -0800, Justin Pettit wrote:
> >> On Feb 1, 2012, at 2:58 PM, Ben Pfaff wrote:
> >>
> >>> +xvu = row.external_ids.get("xs-vif-uuid")
On Thu, Feb 02, 2012 at 04:03:07PM -0800, Ethan Jackson wrote:
> Bug #9015.
> Signed-off-by: Ethan Jackson
Should we add a NEWS item?
s/goverened/governed/ in the documentation.
Otherwise this looks good to me.
___
dev mailing list
dev@openvswitch.org
Bug #9015.
Signed-off-by: Ethan Jackson
---
lib/cfm.c|7 +--
lib/cfm.h|1 +
vswitchd/bridge.c|2 ++
vswitchd/vswitch.xml |9 +
4 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index d62d4e2..537eeaa 10064
On Thu, Feb 02, 2012 at 03:58:16PM -0800, Ethan Jackson wrote:
> Sounds like a good idea to me. I applied the following incremental.
Looks good to me, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sounds like a good idea to me. I applied the following incremental.
diff --git a/lib/cfm.c b/lib/cfm.c
index b6994fc..d62d4e2 100644
--- a/lib/cfm.c
+++ b/lib/cfm.c
@@ -599,9 +599,10 @@ cfm_print_details(struct ds *ds, const struct cfm *cfm)
struct remote_mp *rmp;
ds_put_format(ds, "-
Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:57:49PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote:
> > We try to have such a size check every protocol structure.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> >
Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:57:22PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote:
> > I think that this was just an oversight.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > tests/automake.m
Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:56:54PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote:
> > Some commands weren't mentioned. The "invalid_ttl" option to "monitor"
> > was missing.
> >
> > Signed-
Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:56:21PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote:
> > ---
> > vswitchd/vswitch.xml | 40 +++-
> > 1 files changed, 23 i
Looks good,
Ethan
On Fri, Jan 27, 2012 at 17:18, Ben Pfaff wrote:
> Bug #8827.
> Signed-off-by: Ben Pfaff
> ---
> NEWS | 3 ++
> include/openflow/nicira-ext.h | 10 -
> lib/classifier.c | 77 +++
> lib/classif
On Feb 1, 2012, at 5:19 PM, Ben Pfaff wrote:
> On Wed, Feb 01, 2012 at 04:57:35PM -0800, Justin Pettit wrote:
>> On Feb 1, 2012, at 2:58 PM, Ben Pfaff wrote:
>>
>>> +xvu = row.external_ids.get("xs-vif-uuid")
>>> +if xvu:
>>> +iface_id = (new_iface_ids.get(
Use flex array to increase maximum number of vports. Now maximum
number of vports are limited by flex-array limit (261K for 64-bit)
per bridge.
Signed-off-by: Pravin B Shelar
Bug #2462
---
datapath/actions.c |2 +-
datapath/datapath.c| 44 --
Following patch adds memory barriers, using RCU APIs, so
that upper layers can use flex array in RCU context
without flex-array pre-allocation.
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/flex_array.c | 17 ++---
datapath/linux/compat/include/linux/flex_a
cleanups:
- removes flex_array_shrink() as there is no caller.
- add flex_array_init()
- Add few 'const's.
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/flex_array.c | 114 --
datapath/linux/compat/include/linux/flex_array.h |
31 matches
Mail list logo
