Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:57:49PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:50, Ben Pfaff <b...@nicira.com> wrote:
> > We try to have such a size check every protocol structure.
> >
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> > include/openflow/nicira-ext.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> > index 6921803..62180a7 100644
> > --- a/include/openflow/nicira-ext.h
> > +++ b/include/openflow/nicira-ext.h
> > @@ -276,6 +276,7 @@ struct nx_role_request {
> > struct nicira_header nxh;
> > ovs_be32 role; /* One of NX_ROLE_*. */
> > };
> > +OFP_ASSERT(sizeof(struct nx_role_request) == 20);
> >
> > enum nx_role {
> > NX_ROLE_OTHER, /* Default role, full access. */
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
