Thank you for the review. I'll push this soon.
On Wed, Feb 01, 2012 at 05:56:21PM -0800, Ethan Jackson wrote: > Looks good, > > Ethan > > On Thu, Jan 26, 2012 at 15:50, Ben Pfaff <b...@nicira.com> wrote: > > --- > > vswitchd/vswitch.xml | 40 +++++++++++++++++++++++----------------- > > 1 files changed, 23 insertions(+), 17 deletions(-) > > > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > > index 8c506e4..4b99b99 100644 > > --- a/vswitchd/vswitch.xml > > +++ b/vswitchd/vswitch.xml > > @@ -2338,23 +2338,29 @@ > > > > <group title="OpenFlow Rate Limiting"> > > <column name="controller_rate_limit"> > > - <p>The maximum rate at which packets in unknown flows will be > > - forwarded to the OpenFlow controller, in packets per second. This > > - feature prevents a single bridge from overwhelming the controller. > > - If not specified, the default is implementation-specific.</p> > > - <p>In addition, when a high rate triggers rate-limiting, Open > > - vSwitch queues controller packets for each port and transmits > > - them to the controller at the configured rate. The number of > > - queued packets is limited by > > - the <ref column="controller_burst_limit"/> value. The packet > > - queue is shared fairly among the ports on a bridge.</p><p>Open > > - vSwitch maintains two such packet rate-limiters per bridge. > > - One of these applies to packets sent up to the controller > > - because they do not correspond to any flow. The other applies > > - to packets sent up to the controller by request through flow > > - actions. When both rate-limiters are filled with packets, the > > - actual rate that packets are sent to the controller is up to > > - twice the specified rate.</p> > > + <p> > > + The maximum rate at which the switch will forward packets to the > > + OpenFlow controller, in packets per second. This feature > > prevents a > > + single bridge from overwhelming the controller. If not > > specified, > > + the default is implementation-specific. > > + </p> > > + > > + <p> > > + In addition, when a high rate triggers rate-limiting, Open > > vSwitch > > + queues controller packets for each port and transmits them to the > > + controller at the configured rate. The <ref > > + column="controller_burst_limit"/> value limits the number of > > queued > > + packets. Ports on a bridge share the packet queue fairly. > > + </p> > > + > > + <p> > > + Open vSwitch maintains two such packet rate-limiters per bridge: > > one > > + for packets sent up to the controller because they do not > > correspond > > + to any flow, and the other for packets sent up to the controller > > by > > + request through flow actions. When both rate-limiters are filled > > with > > + packets, the actual rate that packets are sent to the controller > > is > > + up to twice the specified rate. > > + </p> > > </column> > > > > <column name="controller_burst_limit"> > > -- > > 1.7.2.5 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
