v1-v2:
- Fixed memleak.
- Removed extra blank lines.
- Removed flag, offset-stats and linkname from vport.
- inlined skb_clear_rxhash()
--8<--cut here-->8--
Following patch deletes OVS compatibility code related to old
On Fri, Nov 11, 2011 at 5:18 PM, Ben Pfaff wrote:
> On Fri, Nov 11, 2011 at 03:50:56PM -0800, Ben Pfaff wrote:
>> On Fri, Nov 11, 2011 at 03:48:25PM -0800, Jesse Gross wrote:
>> > On Fri, Nov 11, 2011 at 3:43 PM, Ben Pfaff wrote:
>> > > On Fri, Nov 11, 2011 at 03:38:51PM -0800, Jesse Gross wrote:
On Fri, Nov 11, 2011 at 03:50:56PM -0800, Ben Pfaff wrote:
> On Fri, Nov 11, 2011 at 03:48:25PM -0800, Jesse Gross wrote:
> > On Fri, Nov 11, 2011 at 3:43 PM, Ben Pfaff wrote:
> > > On Fri, Nov 11, 2011 at 03:38:51PM -0800, Jesse Gross wrote:
> > >> On Fri, Nov 11, 2011 at 3:13 PM, Ben Pfaff wrot
On Fri, Nov 11, 2011 at 2:26 PM, Ben Pfaff wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 9786c37..96dd716 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> int flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp,
> const struct nlattr *attr)
[.
Followng patch fixes bug in pop_vlan code by setting network and
transport header offsets after untagging vlan.
pop_vlan is updated to make it in sync with newer kernel.
Signed-off-by: Pravin B Shelar
---
acinclude.m4 |2 +
datapath/actions.c
On Fri, Nov 11, 2011 at 2:54 PM, Jesse Gross wrote:
> On Fri, Nov 11, 2011 at 2:41 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/actions.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Jesse Gross
>
Thanks,
Pushed to master.
_
On Fri, Nov 11, 2011 at 03:48:25PM -0800, Jesse Gross wrote:
> On Fri, Nov 11, 2011 at 3:43 PM, Ben Pfaff wrote:
> > On Fri, Nov 11, 2011 at 03:38:51PM -0800, Jesse Gross wrote:
> >> On Fri, Nov 11, 2011 at 3:13 PM, Ben Pfaff wrote:
> >> > I guess that this will need reconsideration after the "en
On Fri, Nov 11, 2011 at 3:43 PM, Ben Pfaff wrote:
> On Fri, Nov 11, 2011 at 03:38:51PM -0800, Jesse Gross wrote:
>> On Fri, Nov 11, 2011 at 3:13 PM, Ben Pfaff wrote:
>> > I guess that this will need reconsideration after the "encap" series,
>> > so I guess there's no point in a detailed response
On Fri, Nov 11, 2011 at 2:26 PM, Ben Pfaff wrote:
> It's useful to be able to track sets of attributes by using their values as
> bit indexes. That's easier if the values are all in the range of a basic
> C integer type.
>
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
__
On Fri, Nov 11, 2011 at 2:26 PM, Ben Pfaff wrote:
> This seems clearer to me. It should not cause any behavioral change.
>
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listin
On Fri, Nov 11, 2011 at 03:38:51PM -0800, Jesse Gross wrote:
> On Fri, Nov 11, 2011 at 3:13 PM, Ben Pfaff wrote:
> > I guess that this will need reconsideration after the "encap" series,
> > so I guess there's no point in a detailed response right now--let me
> > know if you disagree.
>
> I agree
On Thu, Nov 10, 2011 at 05:26:17PM -0800, Ansis Atteka wrote:
> On Tue, Nov 1, 2011 at 11:18 AM, Ben Pfaff wrote:
>
> > On Mon, Oct 31, 2011 at 04:38:51PM -0700, Ansis Atteka wrote:
> > > This tool will be a replacement for the current ovs-vlan-test
> > > utility. Besides from connectivity issues
On Fri, Nov 11, 2011 at 3:13 PM, Ben Pfaff wrote:
> I guess that this will need reconsideration after the "encap" series,
> so I guess there's no point in a detailed response right now--let me
> know if you disagree.
I agree that most of this patch has been overcome by events. I think
there are
On Thu, Nov 10, 2011 at 06:51:39PM -0800, Justin Pettit wrote:
> On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
>
> > @@ -4810,6 +4821,7 @@ is_admissible(struct ofproto_dpif *ofproto, const
> > struct flow *flow,
> > {
>
> The comment for is_admissable() seems out of date. It refers to
> "in_po
I guess that this will need reconsideration after the "encap" series,
so I guess there's no point in a detailed response right now--let me
know if you disagree.
On Wed, Nov 02, 2011 at 03:08:08PM -0700, Jesse Gross wrote:
> On Wed, Nov 2, 2011 at 10:36 AM, Ben Pfaff wrote:
> > On Tue, Nov 01, 201
Thanks, I pushed this.
On Fri, Nov 11, 2011 at 10:54:45AM -0800, Ansis Atteka wrote:
> Works for me. Thanks!
>
> On Tue, Nov 8, 2011 at 12:13 PM, Ben Pfaff wrote:
>
> > Otherwise we build it in the build directory by default, which breaks the
> > Debian package build (unless we're working from
On Fri, Nov 11, 2011 at 2:41 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/actions.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://
Thanks, I pushed this.
On Thu, Nov 10, 2011 at 10:24:48AM -0800, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Nov 10, 2011, at 9:09 AM, Ben Pfaff wrote:
>
> > Reported-by: Michael Mao
> > ---
> > utilities/ovs-ofctl.8.in |6 +++---
> > 1 files changed, 3 insertions(+), 3 deleti
Thanks, I pushed this.
On Thu, Nov 10, 2011 at 11:12:01AM -0800, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Wed, Nov 9, 2011 at 16:24, Ben Pfaff wrote:
> > I like how this removes over 20 lines of code and ends up more readable.
> > ---
> > ?lib/classifier.c | ? 30 +++-
On Wed, Nov 09, 2011 at 01:27:58PM -0800, Ben Pfaff wrote:
> On Wed, Nov 09, 2011 at 01:28:18PM -0800, Jesse Gross wrote:
> > On Wed, Nov 9, 2011 at 1:12 PM, Ben Pfaff wrote:
> > > On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
> > >> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
On Fri, Nov 11, 2011 at 02:41:37PM -0800, Pravin B Shelar wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index dc74a37..ac7187b 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> @@ -124,8 +124,8 @@ static int set_eth_addr(struct sk_buff *skb,
> if (unlikely(err))
Signed-off-by: Pravin B Shelar
---
datapath/actions.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/actions.c b/datapath/actions.c
index dc74a37..ac7187b 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -124,8 +124,8 @@ static int set_eth_addr(str
This series updates the datapath flow key code to use nested
attributes to support forward and backward compatibility over
time, and adds a document describing how such compatiblity may
be achieved.
Ben Pfaff (4):
datapath: Rearrange ovs_key_lens.
openvswitch.h: Change OVS_KEY_ATTR_TUN_ID from
When the datapath was converted to use Netlink attributes for describing
flow keys, I had a vague idea of how it could be smoothly extensible, but
I didn't actually implement extensibility or carefully think it through.
This commit adds a document that describes how flow keys can be extended
in a c
This is more conventional use of Netlink.
For upstreaming, 'u64 attrs' can be changed to u32 and the uses of 1ULL
can be changed to 1.
Signed-off-by: Ben Pfaff
---
datapath/flow.c | 477 ++-
lib/odp-util.c | 426 ++--
This seems clearer to me. It should not cause any behavioral change.
Signed-off-by: Ben Pfaff
---
datapath/flow.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index 152d9be..9786c37 100644
--- a/datapath/flow.c
+++ b/datapat
It's useful to be able to track sets of attributes by using their values as
bit indexes. That's easier if the values are all in the range of a basic
C integer type.
Signed-off-by: Ben Pfaff
---
include/linux/openvswitch.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
On Thu, Nov 10, 2011 at 7:14 PM, Pravin B Shelar wrote:
> OVS uses genl_mutex locking to protect datapath data-structures
> like flow-table, flow-actions. Following patch adds
> lockdep_genl_is_held() which is used for rcu annotation to prove
> locking.
>
> Signed-off-by: Pravin B Shelar
Applied
On Thu, Nov 10, 2011 at 7:14 PM, Pravin B Shelar wrote:
> Open vSwitch uses Generic Netlink interface for communication
> between userspace and kernel module. genl_notify() is used
> for sending notification of back to userspace.
>
> genl_notify() is analogous to rtnl_notify() but uses genl_sock
>
DO Sie einen Kredit? WENN JA KONTAKT heute Ihre URGENT KREDIT hier in
Südafrika EMAIL: mantinsloanf...@aol.com ERWARTET Ihre Antwort.
DO YOU NEED A LOAN? IF YES CONTACT US TODAY FOR YOUR URGENT LOAN HERE IN
SOUTH AFRICA EMAIL:mantinsloanf...@aol.com AWAITS YOUR REPLY.
_
Works for me. Thanks!
On Tue, Nov 8, 2011 at 12:13 PM, Ben Pfaff wrote:
> Otherwise we build it in the build directory by default, which breaks the
> Debian package build (unless we're working from a "make dist" created
> tarball since that has ovs-vswitchd.conf.db.5 in the srcdir as part of
> t
31 matches
Mail list logo
