On Wed, Nov 09, 2011 at 01:27:58PM -0800, Ben Pfaff wrote: > On Wed, Nov 09, 2011 at 01:28:18PM -0800, Jesse Gross wrote: > > On Wed, Nov 9, 2011 at 1:12 PM, Ben Pfaff <b...@nicira.com> wrote: > > > On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote: > > >> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff <b...@nicira.com> wrote: > > >> > Jesse and I spent some time pondering this face-to-face, so there's a > > >> > bunch of discussion that hasn't shown up on the mailing list. > > >> > > > >> > My understanding of what we concluded is: > > >> > > > >> > ?? ?? ?? ??- We will add a new "encap" flow key attribute that contains > > >> > ?? ?? ?? ?? ??nested attributes. ??An "encap" is used whenever > > >> > layering is > > >> > ?? ?? ?? ?? ??duplicated or jumps down (e.g. when a L2, L3, or L4 > > >> > header > > >> > ?? ?? ?? ?? ??is followed by an L2 header). > > >> > > > >> > ?? ?? ?? ??- The "set" action is explicitly defined to act on the > > >> > ?? ?? ?? ?? ??outermost instance of a header. > > >> > > > >> > ?? ?? ?? ??- We will abandon the pretense that "push" and "pop" can be > > >> > ?? ?? ?? ?? ??generic and introduce explicit "push_vlan" and "pop_vlan" > > >> > ?? ?? ?? ?? ??actions. > > > [...] > > >> A couple of unimportant notes: > > >> ??* Some of the flow lines are really long. > > > > > > OK, I did s/,/, /g and reflowed. > > > > > >> ??* The vlan example uses 0x800 instead of 0x0800 like in other places. > > > > > > OK, changed. > > > > > >> ??* I would explicitly specify that duplicate tags are not allowed and > > >> that ordering is not significant. > > > > > > OK, added. > > > > > > Incremental follows, then a full copy. > > > > Looks great, thanks. > > OK, now I'll make it into a real commit that actually implements this > stuff.
That's the "encap" series I just posted. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
