There will be a caller added soon.
---
lib/netdev-linux.c | 28
lib/netdev-linux.h |8
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 05b830c..409f8b9 100644
--- a/lib/netdev-linux.c
+++ b/li
Whenever a port is added to the datapath, LRO is automatically disabled.
In the future, we may want to enable LRO in some circumstances, so have
userspace disable LRO through the ethtool ioctls.
Feature #6810
Signed-off-by: Justin Pettit
---
datapath/linux/.gitignore |
On Wed, Aug 17, 2011 at 3:04 PM, Neil McKee wrote:
>
> On Aug 17, 2011, at 2:30 PM, Ben Pfaff wrote:
>
>> On Wed, Aug 17, 2011 at 02:18:52PM -0700, Neil McKee wrote:
>>>
>>> On Aug 17, 2011, at 12:25 PM, Ben Pfaff wrote:
>>>
On Wed, Aug 17, 2011 at 11:51:05AM -0700, Pravin Shelar wrote:
>
This is still more or less untested.
---
include/openflow/nicira-ext.h | 193 ++-
lib/automake.mk |2 +
lib/learn.c | 585 +
lib/learn.h | 40 +++
lib/ofp-parse.c |5 +
l
---
ofproto/ofproto.c | 116
1 files changed, 62 insertions(+), 54 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index a34db45..45dec07 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -97,10 +97,10 @@ struct ofopgro
Currently this only gets checked for incoming OpenFlow OFPT_FLOW_MOD
messages, so it's hard to imagine it being any kind of bottleneck, but the
NXAST_LEARN action that is soon to be added will be able to create flows
more quickly than we normally expect from a controller. (On the other
hand, ofpro
This will soon have a new user, but it's a worthwhile cleanup on its own.
---
lib/ofp-parse.c | 63 -
lib/ofp-util.c | 69 +++
lib/ofp-util.h |3 ++
3 files changed, 78 insertions(+), 57 d
This series adds a new "learn" action that controllers can use to
do more flexible learning than is possible by outputting to the
OFPP_NORMAL port. The final commit is still more or less untested;
I'm working on that now. I think that the rest are ready for
review.
Ben Pfaff (6):
ofp-util: New
---
ofproto/ofproto.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 45dec07..d35e1d8 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -136,7 +136,8 @@ static void ofproto_rule_send_removed(struct rule *,
uin
On Aug 17, 2011, at 2:30 PM, Ben Pfaff wrote:
> On Wed, Aug 17, 2011 at 02:18:52PM -0700, Neil McKee wrote:
>>
>> On Aug 17, 2011, at 12:25 PM, Ben Pfaff wrote:
>>
>>> On Wed, Aug 17, 2011 at 11:51:05AM -0700, Pravin Shelar wrote:
On Tue, Aug 16, 2011 at 11:17 PM, Jesse Gross wrote:
>
On Wed, Aug 17, 2011 at 02:18:52PM -0700, Neil McKee wrote:
>
> On Aug 17, 2011, at 12:25 PM, Ben Pfaff wrote:
>
> > On Wed, Aug 17, 2011 at 11:51:05AM -0700, Pravin Shelar wrote:
> >> On Tue, Aug 16, 2011 at 11:17 PM, Jesse Gross wrote:
> >>> The use of the checksum for actions surprised me a l
On Aug 17, 2011, at 12:25 PM, Ben Pfaff wrote:
> On Wed, Aug 17, 2011 at 11:51:05AM -0700, Pravin Shelar wrote:
>> On Tue, Aug 16, 2011 at 11:17 PM, Jesse Gross wrote:
>>> The use of the checksum for actions surprised me a little bit, as it
>>> is semantically equivalent to what we have today bu
Le 17/08/2011 03:37, Jesse Gross a écrit :
>
> This is the same as native vlan, right? If so, I think that is a
> better name as it is more common and PVID sounds like it should refer
> to private vlans.
Yes, also called default VLAN. Do I make the change just in comments or
also in the new col
Looks fine to me.
Ethan
On Wed, Aug 17, 2011 at 10:59, Ben Pfaff wrote:
> On Tue, Aug 16, 2011 at 05:41:46PM -0700, Ethan Jackson wrote:
>> I would be inclined to implement a "clz" function similar to what
>> log_2_floor() does in util. We could use it both for log_2_floor()
>> and ip_count_cid
On Wed, Aug 17, 2011 at 11:51:05AM -0700, Pravin Shelar wrote:
> On Tue, Aug 16, 2011 at 11:17 PM, Jesse Gross wrote:
> > The use of the checksum for actions surprised me a little bit, as it
> > is semantically equivalent to what we have today but perhaps not as
> > accurate. ?Ben made a couple of
On Tue, Aug 16, 2011 at 11:17 PM, Jesse Gross wrote:
> On Mon, Aug 15, 2011 at 8:34 PM, pravin shelar wrote:
>> This patch makes sampling support more generic/simple by adding
>> Datapath SAMPLING action. When sampling is turned on, a SAMPLING
>> action is added to all flows for given bridge.
On Wed, Aug 17, 2011 at 12:33:55AM +0200, Philippe Jung wrote:
> Also fixed a typo in INSTALL.Linux still referencing --with-l26
I committed this part and added you to AUTHORS too (so you can skip
that part of the feedback on your patch).
Thanks,
Ben.
On Wed, Aug 17, 2011 at 12:33:55AM +0200, Philippe Jung wrote:
> Please find a new version of the patch against master branch, non word
> wrapped, with updated doc. Also fixed a typo in INSTALL.Linux still
> referencing --with-l26
Thanks. This version applies well. I have some comments to add
Thanks!
I'll merge this.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 16, 2011 at 06:44:40PM -0700, Ethan Jackson wrote:
> Nifty patch. This has always been a pain point when implementing new
> actions. Glad to see it all generated now.
Thanks. (I was half-expecting the review to be "You stupid !@#)*(%,
stop abusing the preprocessor.")
___
On Tue, Aug 16, 2011 at 06:13:59PM -0700, Ethan Jackson wrote:
> I would be inclined to s/false/0 and s/true/1 in ofp-util.def. That
> would allow us to align it against NXAST_RESUBMIT_TABLE without going
> over 79 characters. Doesn't really matter though.
That's reasonable. I made that change.
On Tue, Aug 16, 2011 at 05:41:46PM -0700, Ethan Jackson wrote:
> I would be inclined to implement a "clz" function similar to what
> log_2_floor() does in util. We could use it both for log_2_floor()
> and ip_count_cidr_bits(). That way we would only have to deal with
> the ugly GNUC ifdefing in
On Tue, Aug 16, 2011 at 02:31:56PM -0700, Ethan Jackson wrote:
> The first patch of this series fixes a bug I noticed involving
> facet_account(). The second patch in the series would have fixed
> it as well. I wrote them as two patches in case we want to
> backport it to 1.2. I don't have a str
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 16, 2011 at 02:31:58PM -0700, Ethan Jackson wrote:
> It no longer has interesting users.
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 16, 2011 at 02:31:57PM -0700, Ethan Jackson wrote:
> The update_stats() function in ofproto was attributing more bytes
> to facets than they had actually accrued. This could potentially
> throw off bond load balancing.
Looks good, thanks.
__
[bringing Neil McKee into the conversation since he knows more about
this than me]
On Wed, Aug 17, 2011 at 02:17:03PM +0800, Jesse Gross wrote:
> The one piece that I'm the least sure of is how to handle stats. In
> my ideal world, we would drop the sample pool altogether and have
> userspace fig
27 matches
Mail list logo
