Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-05-17 Thread Armin Le Grand
On 17.05.2013 11:08, Pavel Janík wrote: Thus, all is fine, no unused/new/unexpected entry. From the C++ perspective it's questionable when this leads to extra-code in switch/case statements for an entry which seems to be there for UNO technical reasons to be warning-free. Those entries have no

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-05-17 Thread Pavel Janík
> Thus, all is fine, no unused/new/unexpected entry. From the C++ perspective > it's questionable when this leads to extra-code in switch/case statements for > an entry which seems to be there for UNO technical reasons to be > warning-free. Those entries have no informational content as it seems

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-05-17 Thread Armin Le Grand
Hi Pavel, On 17.05.2013 10:24, Armin Le Grand wrote: Hi Pavel, On 17.05.2013 07:37, Pavel Janík wrote: On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE c

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-05-17 Thread Armin Le Grand
Hi Pavel, On 17.05.2013 07:37, Pavel Janík wrote: On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\o

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-05-16 Thread Pavel Janík
On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: > > On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: > >> I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE >> come from? When you look at he UNO API file >> (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl)

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-04-19 Thread Pavel Janík
On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: > I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE > come from? When you look at he UNO API file > (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such > definition. Since the headers are genera

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-04-19 Thread Armin Le Grand
Hi Pavel, I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if

Re: WaE: LineJoint_MAKE_FIXED_SIZE

2013-04-19 Thread Pavel Janík
Who is the author of this code? Is it right to not handle the value in these switches? On Apr 10, 2013, at 10:19 PM, Pavel Janík wrote: > Hi, > > please have a look at this change: > > http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff > > LineJoint_MAKE_FIXED_SIZE is not handl

WaE: LineJoint_MAKE_FIXED_SIZE

2013-04-10 Thread Pavel Janík
Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík -