Re: PR's without adequate information

2020-09-17 Thread Matias N.
The automated check is not to replaced the commiter task of reading the description of course, it is to automate the mundane tasks of responding a trivial "please describe your PR". I'm not sure what you mean by checking the commit message, as there's no template for that. And as I said, let tr

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 10:02 AM Gregory Nutt wrote: > > > That's why we have committers. It's been said, but I'll repeat: As > > committers, I know it's mundane, but we really need to make sure the > commit > > and PR messages will be helpful to someone who looks at them in the > future. > > But

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
That's why we have committers. It's been said, but I'll repeat: As committers, I know it's mundane, but we really need to make sure the commit and PR messages will be helpful to someone who looks at them in the future. But it would help the committer by at least assuring that there is someth

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 9:26 AM Gregory Nutt wrote: > > > An alternative is to use a workflow. For example this action does > something in that line: > https://github.com/marketplace/actions/pull-request-ticket-check-action > > > I think including the a PR comment check in the PR checks is a grea

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
An alternative is to use a workflow. For example this action does something in that line: https://github.com/marketplace/actions/pull-request-ticket-check-action I think including the a PR comment check in the PR checks is a great idea if it is feasible:  If a section is blank, the check fa

Re: PR's without adequate information

2020-09-17 Thread Matias N.
An alternative is to use a workflow. For example this action does something in that line: https://github.com/marketplace/actions/pull-request-ticket-check-action Sep 17, 2020 09:51:38 Matias N. : > Thanks, I'll have a look. Manually adding text to a PR to prove yourself is > really not desirea

Re: PR's without adequate information

2020-09-17 Thread Fotis Panagiotopoulos
Have a look at this project. https://github.com/foosel/GitIssueBot It requires you to include a specific phrase in the description, proving that you have read the contribution guide. Στις Πέμ, 17 Σεπ 2020 στις 3:33 μ.μ., ο/η Matias N. έγραψε: > Regarding following the PR template: yes, I have s

Re: PR's without adequate information

2020-09-17 Thread Matias N.
Regarding following the PR template: yes, I have seen this several times. A few thoughts: * We can add one comment line to each PR description section in the template like . This can be annoying to the rest who don't need the reminder. * Add a CONTRIBUTING.md to the repo, it appears linked as s

RE: PR's without adequate information

2020-09-17 Thread Jerpelea, Alin
The problem as I see it is not for the PR only since we merged commits that have the same issues. Try "git log" in a console and you will see that most commits have only a title without a commit message and context. This may become a problem if in the future we want to understand why a commit