On Thu, Sep 17, 2020 at 9:26 AM Gregory Nutt <spudan...@gmail.com> wrote:
> > > An alternative is to use a workflow. For example this action does > something in that line: > https://github.com/marketplace/actions/pull-request-ticket-check-action > > > I think including the a PR comment check in the PR checks is a great > idea if it is feasible: If a section is blank, the check fails. > > That check would only mean that the contributor wrote something each > template. That does not mean that the comments are good, correct, or > usable. That's why we have committers. It's been said, but I'll repeat: As committers, I know it's mundane, but we really need to make sure the commit and PR messages will be helpful to someone who looks at them in the future. (Release Notes writers, someone debugging a regression in the future, etc.) It's just as important as looking at the technical changes. If the message is bad, we need to ask the contributor to fix it, and if language is a barrier, then as a community let's help the contributor and provide a better text. Comments are ignored in the PR templates as well. We used to have a > long, useless PR template with lots of comments. It was always igored.. > by everyone. So I do not think that adding any kind of comments will be > useful at all. Yes please don't bring back that horrible PR template!!! Summary/Impact//Testing is very good. We just need to make sure it contains something useful. Nathan
