Re: PR's without adequate information

2020-09-17 Thread Matias N.
The automated check is not to replaced the commiter task of reading the description of course, it is to automate the mundane tasks of responding a trivial "please describe your PR". I'm not sure what you mean by checking the commit message, as there's no template for that. And as I said, let tr

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 10:02 AM Gregory Nutt wrote: > > > That's why we have committers. It's been said, but I'll repeat: As > > committers, I know it's mundane, but we really need to make sure the > commit > > and PR messages will be helpful to someone who looks at them in the > future. > > But

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
That's why we have committers. It's been said, but I'll repeat: As committers, I know it's mundane, but we really need to make sure the commit and PR messages will be helpful to someone who looks at them in the future. But it would help the committer by at least assuring that there is someth

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 9:26 AM Gregory Nutt wrote: > > > An alternative is to use a workflow. For example this action does > something in that line: > https://github.com/marketplace/actions/pull-request-ticket-check-action > > > I think including the a PR comment check in the PR checks is a grea

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
An alternative is to use a workflow. For example this action does something in that line: https://github.com/marketplace/actions/pull-request-ticket-check-action I think including the a PR comment check in the PR checks is a great idea if it is feasible:  If a section is blank, the check fa

Re: PR's without adequate information

2020-09-17 Thread Matias N.
> This may become a problem if in the future we want to understand why a >>>> commit was added without going back and studying the PR message. >>>> >>>> To address this issue >>>> >>>> I tried to educate the authors so I started wor

Re: PR's without adequate information

2020-09-17 Thread Fotis Panagiotopoulos
me to the PR and educate ourselves so that we end with > a clean description for each PR and commit > > Where should I publish this document? > > Regards > Alin > > > -Original Message----- > From: David Sidrane > Sent: den 17 september 2020 11:59 > To: d

Re: PR's without adequate information

2020-09-17 Thread Matias N.
d commit > > Where should I publish this document? > > Regards > Alin > > > -Original Message- > From: David Sidrane > Sent: den 17 september 2020 11:59 > To: dev@nuttx.apache.org > Subject: PR's without adequate information > > PR's without a

RE: PR's without adequate information

2020-09-17 Thread Jerpelea, Alin
es so that we end with a clean description for each PR and commit Where should I publish this document? Regards Alin -Original Message- From: David Sidrane Sent: den 17 september 2020 11:59 To: dev@nuttx.apache.org Subject: PR's without adequate information PR's without

PR's without adequate information

2020-09-17 Thread David Sidrane
PR's without adequate information We are getting a slew of PR's without adequate information to consider merging them. Some of the Titles are incomplete or misleading. I am also concerned about bloat and the loss of one of NuttX major advantages: Scalability. I have no doubt, there