RE: Is the only option for using the network monitor....

2020-09-17 Thread David Sidrane
Hi Greg, Thank you responding. Then I will I will test it. -Original Message- From: Gregory Nutt [mailto:spudan...@gmail.com] Sent: Thursday, September 17, 2020 1:03 PM To: dev@nuttx.apache.org Subject: Re: Is the only option for using the network monitor On 9/17/2020 1:59 PM, David

Re: Is the only option for using the network monitor....

2020-09-17 Thread Anthony Merlino
David, I've been trying to figure out how you would do this on Linux. This seems to be the right answer. Done via a "lease" configuration for dhcpd, or via secondary static IP on the interface https://stackoverflow.com/questions/12727175/set-static-ip-if-not-obtained-from-dhcp-script For your pur

Re: Is the only option for using the network monitor....

2020-09-17 Thread Gregory Nutt
On 9/17/2020 1:59 PM, David Sidrane wrote: Is the only option for using the network monitor Hi, My goal is to have a run time option to use a static IP or DHCP. (Curretly it is compile time) If either are used I want to "auto up" the eth0. Once the interface comes up , if configured for

Is the only option for using the network monitor....

2020-09-17 Thread David Sidrane
Is the only option for using the network monitor Hi, My goal is to have a run time option to use a static IP or DHCP. (Curretly it is compile time) If either are used I want to "auto up" the eth0. Once the interface comes up , if configured for DHCP it should make start the DHCP request pro

Re: What gets patched onto previous releases?

2020-09-17 Thread Brennan Ashton
On Thu, Sep 17, 2020, 9:35 AM Anthony Merlino wrote: > Hi all, > > So I just ran into an issue on both 9.0 and 9.1 with SD card operations. > After digging for a bit, I found the issue was addressed here: > > > https://github.com/apache/incubator-nuttx/commit/e21dd687555180b41e845a2c0676fdc96fc95

What gets patched onto previous releases?

2020-09-17 Thread Anthony Merlino
Hi all, So I just ran into an issue on both 9.0 and 9.1 with SD card operations. After digging for a bit, I found the issue was addressed here: https://github.com/apache/incubator-nuttx/commit/e21dd687555180b41e845a2c0676fdc96fc952ed I completely understand that it takes work to patch and regres

Re: Help with Apache Github Invite

2020-09-17 Thread Nathan Hartman
Hi folks, Can we get this sorted out please: On Thu, Sep 17, 2020 at 10:25 AM Anthony Merlino wrote: > > FYI: I STILL do not have access to the Github organization. > > I have tried changing my email everywhere in apache to match my primary > email on Github. I've tried re-adding my Github accou

Re: Help with Apache Github Invite

2020-09-17 Thread Anthony Merlino
FYI: I STILL do not have access to the Github organization. I have tried changing my email everywhere in apache to match my primary email on Github. I've tried re-adding my Github account through the ASF portal multiple times. I've tried emailing us...@infra.apache.org and never even got a respons

Re: PR's without adequate information

2020-09-17 Thread Matias N.
The automated check is not to replaced the commiter task of reading the description of course, it is to automate the mundane tasks of responding a trivial "please describe your PR". I'm not sure what you mean by checking the commit message, as there's no template for that. And as I said, let tr

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 10:02 AM Gregory Nutt wrote: > > > That's why we have committers. It's been said, but I'll repeat: As > > committers, I know it's mundane, but we really need to make sure the > commit > > and PR messages will be helpful to someone who looks at them in the > future. > > But

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
That's why we have committers. It's been said, but I'll repeat: As committers, I know it's mundane, but we really need to make sure the commit and PR messages will be helpful to someone who looks at them in the future. But it would help the committer by at least assuring that there is someth

Re: PR's without adequate information

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 9:26 AM Gregory Nutt wrote: > > > An alternative is to use a workflow. For example this action does > something in that line: > https://github.com/marketplace/actions/pull-request-ticket-check-action > > > I think including the a PR comment check in the PR checks is a grea

Re: PR's without adequate information

2020-09-17 Thread Gregory Nutt
An alternative is to use a workflow. For example this action does something in that line: https://github.com/marketplace/actions/pull-request-ticket-check-action I think including the a PR comment check in the PR checks is a great idea if it is feasible:  If a section is blank, the check fa

Re: PR's without adequate information

2020-09-17 Thread Matias N.
An alternative is to use a workflow. For example this action does something in that line: https://github.com/marketplace/actions/pull-request-ticket-check-action Sep 17, 2020 09:51:38 Matias N. : > Thanks, I'll have a look. Manually adding text to a PR to prove yourself is > really not desirea

Re: PR's without adequate information

2020-09-17 Thread Fotis Panagiotopoulos
Have a look at this project. https://github.com/foosel/GitIssueBot It requires you to include a specific phrase in the description, proving that you have read the contribution guide. Στις Πέμ, 17 Σεπ 2020 στις 3:33 μ.μ., ο/η Matias N. έγραψε: > Regarding following the PR template: yes, I have s

Re: PR's without adequate information

2020-09-17 Thread Matias N.
Regarding following the PR template: yes, I have seen this several times. A few thoughts: * We can add one comment line to each PR description section in the template like . This can be annoying to the rest who don't need the reminder. * Add a CONTRIBUTING.md to the repo, it appears linked as s

RE: PR's without adequate information

2020-09-17 Thread Jerpelea, Alin
The problem as I see it is not for the PR only since we merged commits that have the same issues. Try "git log" in a console and you will see that most commits have only a title without a commit message and context. This may become a problem if in the future we want to understand why a commit

PR's without adequate information

2020-09-17 Thread David Sidrane
PR's without adequate information We are getting a slew of PR's without adequate information to consider merging them. Some of the Titles are incomplete or misleading. I am also concerned about bloat and the loss of one of NuttX major advantages: Scalability. I have no doubt, there is a great d