Re: Approvals for Critical Changes

2020-04-06 Thread Nathan Hartman
On Mon, Apr 6, 2020 at 8:23 PM Gregory Nutt wrote: > > > Just to clarify: > > > > I don't support that specific people should "own" a directory or > > section of code, > > Poor choice of words on my part. I seem to pick words that trigger the > wrong responses. I didn't take it the wrong way.

Re: Approvals for Critical Changes

2020-04-06 Thread Gregory Nutt
Just to clarify: I don't support that specific people should "own" a directory or section of code, Poor choice of words on my part.  I seem to pick words that trigger the wrong responses.  We are in agreement int the concept.  By "own", I meant in the sense that businesses use the term:  W

Re: Approvals for Critical Changes

2020-04-06 Thread Gregory Nutt
One thing we can do is automatically apply labels to pull requests via the CI system. So if something changes in certain folder gets a multiple reviewer label and a comment in the PR. Still a social solution, but I think it would nudge people into the right direction. I like the idea.

Re: Approvals for Critical Changes

2020-04-06 Thread Gregory Nutt
Just to clarify: I don't support that specific people should "own" a directory or section of code, Poor choice of words on my part.  I seem to pick words that trigger the wrong responses.  We are in agreement int the concept.  By "own", I meant in the sense that businesses use the term:  W

Re: Approvals for Critical Changes

2020-04-06 Thread Nathan Hartman
On Mon, Apr 6, 2020 at 4:47 PM Gregory Nutt wrote: > In the past, we talked about not all changes being equal and that > changes within some directories are more sensitive than changes to > others. We discussed the notion of an "owner" of each top level > directory that needed to approve any chan

Re: Approvals for Critical Changes

2020-04-06 Thread Brennan Ashton
One thing we can do is automatically apply labels to pull requests via the CI system. So if something changes in certain folder gets a multiple reviewer label and a comment in the PR. Still a social solution, but I think it would nudge people into the right direction. --Brennan On Mon, Apr 6, 20

Re: Approvals for Critical Changes

2020-04-06 Thread Gregory Nutt
The only project I know that does something similar (successfully) is subversion and it's by social convention. Social conventions would be the preferred way to handle this. But that requires some education for all committers to understand and support those conventions.  That can be diffic

Re: Approvals for Critical Changes

2020-04-06 Thread Adam Feuer
Justin, Thanks, that's cool to know. -adam On Mon, Apr 6, 2020 at 3:43 PM Justin Mclean wrote: > Hi, > > The only project I know that does something similar (successfully) is > subversion and it's by social convention. > > Please consider not using CODEOWNERS as people don’t own the parts of t

Re: Approvals for Critical Changes

2020-04-06 Thread Justin Mclean
Hi, The only project I know that does something similar (successfully) is subversion and it's by social convention. Please consider not using CODEOWNERS as people don’t own the parts of the code at the ASF. It can also cause long term issues and discourage contribution.Tjhere are other issues,

Re: Debugging Nuttx

2020-04-06 Thread Eduard Niesner
Here are the correct paths. The previous ones were a little bit confusing... - Ubuntu Bash under Windows 10: /mnt/d/Work/Development/Git/NuttxH7Ubuntu/Nuttx/arch/arm/src/chip/stm32_spi.c:635 - Cygwin: D:\Work\Development\Git\NuttxH7Cygwin\Nuttx\arch\arm\src/chip/stm32_spi.c:561 Edi On Tue, Apr 7,

Re: Debugging Nuttx

2020-04-06 Thread Eduard Niesner
Thank you, Alexander! I will try your script in the next few days. I used objdump to generate the debug information for the libnuttx.a and libapps.a and this is how the paths from the debug information look like: - Ubuntu Bash under Windows 10: /mnt/d/Work/Development/Git/NuttxH7Ubuntu/Nu

Re: Approvals for Critical Changes

2020-04-06 Thread Adam Feuer
Greg, Github appears to have Code Owners: "You can use a CODEOWNERS file to define individuals or teams that are responsible for code in a repository." "Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Code owners are not autom

Approvals for Critical Changes

2020-04-06 Thread Gregory Nutt
In the past, we talked about not all changes being equal and that changes within some directories are more sensitive than changes to others.  We discussed the notion of an "owner" of each top level directory that needed to approve any changes to those directories.  Nathan was the primary advoca

Re: Debugging Nuttx

2020-04-06 Thread Alexander Oryshchenko
Hi Eduard, Sure just go to nuttx directory and apply it: git apply 0001-Replace-Linux-symlinks-with-junction-on-WSL.diff I do it right after clone/checkout of Nuttx source -Alexander On Mon, Apr 6, 2020 at 5:39 PM Eduard Niesner wrote: > Hi Alexander, > > Can you share your script and some

Re: Debugging Nuttx

2020-04-06 Thread Eduard Niesner
Hi Alexander, Can you share your script and some instructions on how to use it? Thank you, Edi On Sun, Apr 5, 2020 at 11:19 PM Alexander Oryshchenko < a.oryshche...@gmail.com> wrote: > path -> patch, I lost characters sometimes :) > > вс, 5 апр. 2020 г., 23:17 Alexander Oryshchenko : > > > Hi,

Start of the NuttX 9.0 release cycle

2020-04-06 Thread Abdelatif Guettouche
Hi, As discussed in the previous thread [1], today is the start of the NuttX 9.0 release cycle. The release process is outlined in the link below. This is another chance for others to express their opinions, suggestions or concerns. Otherwise, we will move forward with the proposed release proces