Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-07-25 Thread Yash Mayya
e > >> reading the "Proposed Changes" section. I'd bet that this is also why we > >> use that ordering in the KIP template. > >> > >> 2. Why are we invoking SourceTask::updateOffsets so frequently when > >> exactly-once support is disabled?

Re: [VOTE] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Yash Mayya
Hi Hector, Thanks for the KIP! +1 (non-binding) Thanks, Yash On Tue, Jul 25, 2023 at 11:01 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Thanks for the KIP. As you say, not that controversial. > > +1 (non-binding) > > Thanks, > Andrew > > > On 25 Jul 2023, at 18:22, Hector

Re: Apache Kafka 3.6.0 release

2023-07-26 Thread Yash Mayya
Hi Hector, KIP-959 actually still requires 2 more binding votes to be accepted ( https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals). The non-binding votes from people who aren't committers (including myself) don't count towards the required lazy majority. Thanks, Yash On

[DISCUSS] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-08-22 Thread Yash Mayya
Hi all, I'd like to start a discussion thread for this KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-970%3A+Deprecate+and+remove+Connect%27s+redundant+task+configurations+endpoint . It proposes the deprecation and eventual removal of Kafka Connect's redundant task configurations end

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-08-22 Thread Yash Mayya
erent thread, ordering > guarantees might be harder to ensure if we do it from the other thread. The > current mechanism proposed, even though gets invoked multiple times, keeps > things simpler to reason about. > > Let me know how things look now. If it's all looking ok, I would go a

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-08-29 Thread Yash Mayya
Hi Sagar, > The size of offsets topic can be controlled by > setting appropriate topic retention values and > that is a standard practice in Kafka Kafka Connect enforces the `cleanup.policy` configuration for the offsets topic to be "compact" only (references - [1], [2]), so the topic retention r

[VOTE] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-08-29 Thread Yash Mayya
Hi all, This is the vote thread for KIP-970 which proposes deprecating (in the Apache Kafka 3.7 release) and eventually removing (in the next major Apache Kafka release - 4.0) Connect's redundant task configurations endpoint. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-970%3A+Depr

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-03 Thread Yash Mayya
Hi Chris, Thanks for the KIP, this looks like a really useful addition to Kafka Connect's log level REST APIs! I have a few questions and comments: > If no modifications to the namespace have > been made since the worker was started, > they will be null If no modifications to a logging namespace

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-03 Thread Yash Mayya
27;t account for the fact that at worker startup we'll still have loggers with non-null log levels - the root logger and any other named loggers which have explicit log levels configured in the log4j properties. On Mon, Sep 4, 2023 at 12:00 PM Yash Mayya wrote: > Hi Chris, > > Thank

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-06 Thread Yash Mayya
Hi Chris, Thanks for the clarification on the last modified timestamp tracking here and on the KIP, things look good to me now. On the persistence front, I hadn't considered the interplay between levels set by the log level REST APIs and those set by the log4j configuration files, and the user co

Re: [VOTE] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-09-06 Thread Yash Mayya
Hi all, I just wanted to bump up this vote thread. Thanks to everyone who's voted so far - we have 1 binding +1 vote and 3 non-binding +1 votes so far. Thanks, Yash On Wed, Aug 30, 2023 at 11:14 PM Sagar wrote: > +1 (non - binding). > > Thanks ! > Sagar. > > On Wed, 30 Aug 2023 at 11:09 PM, Ch

Re: [VOTE] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-09-08 Thread Yash Mayya
for the KIP! > > Mickael > > On Wed, Sep 6, 2023 at 6:05 PM Greg Harris > wrote: > > > > Hey Yash, > > > > +1(binding) > > > > Thanks for the KIP! > > Greg > > > > On Wed, Sep 6, 2023 at 6:59 AM Yash Mayya wrote: > > > > > &

[DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-09-17 Thread Yash Mayya
Hi all, I'd like to begin discussion on a KIP to allow creating connectors in a stopped state - https://cwiki.apache.org/confluence/display/KAFKA/KIP-980%3A+Allow+creating+connectors+in+a+stopped+state Thanks, Yash

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-09-21 Thread Yash Mayya
the case of a downgrade, how will Connect worker handle the optional > “state” field in config topic ? > > Thanks, > Ashwin > > > > > On Sun, Sep 17, 2023 at 11:09 PM Yash Mayya wrote: > > > Hi all, > > > > I'd like to begin discussion on a KIP

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-03 Thread Yash Mayya
more. > > 5. (NIt): We can link to our own Javadocs [2] instead of javadoc.io > > > [1] - > > https://github.com/apache/kafka/blob/dcd8c7d05f2f22f2d815405e7ab3ad7439669239/connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java#L234-L236 >

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-04 Thread Yash Mayya
ors in the stopped state, or add any other > special logic besides noting the new state in the config topic? Or is it > sufficient to write a non-running target state to the config topic and then > rely on existing logic to simply refuse to generate task configs for the > newly-created

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-05 Thread Yash Mayya
something else? > > 4. (Addressed) Thanks! Looks great. > > 6. (Addressed) Awesome, great to hear. The point about laggy connector > startup is very convincing; my paranoia is satiated. > > > Cheers, > > Chris > > On Wed, Oct 4, 2023 at 5:35 AM Yash Mayya wrote:

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-06 Thread Yash Mayya
t 10:49 PM Chris Egerton wrote: > Hi Yash, > > Yeah, I think just hardcoding with JSON-first, properties-second is fine. > IMO it's worth calling this out explicitly in the KIP. > > Apart from that, no further comments. LGTM, thanks for the KIP! > > Cheers, > > Chris

Re: [VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-08 Thread Yash Mayya
Hi Chris, Thanks for the KIP! +1 (binding) Yash On Fri, Oct 6, 2023 at 9:54 PM Greg Harris wrote: > Hey Chris, > > Thanks for the KIP! > I think that preserving the ephemeral nature of the logging change is > the right choice here, and using the config topic for intra-cluster > broadcast is be

[VOTE] KIP-980: Allow creating connectors in a stopped state

2023-10-08 Thread Yash Mayya
Hi all, I'd like to start a vote on KIP-980 which proposes allowing the creation of connectors in a stopped (or paused) state. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-980%3A+Allow+creating+connectors+in+a+stopped+state Discussion Thread - https://lists.apache.org/thread/om803

Re: [VOTE] KIP-980: Allow creating connectors in a stopped state

2023-10-16 Thread Yash Mayya
, 2023, 7:57 AM Chris Egerton > wrote: > > > > > Thanks for the KIP, Yash! > > > > > > +1 (binding) > > > > > > On Mon, Oct 9, 2023, 01:12 Yash Mayya wrote: > > > > > > > Hi all, > > > > > &g

Re: [VOTE] KIP-980: Allow creating connectors in a stopped state

2023-10-16 Thread Yash Mayya
Hi all, Thanks for participating in the discussion and voting! KIP-980 has been accepted with the following +1 votes: - Chris Egerton (binding) - Knowles Atchison Jr (non-binding) - Greg Harris (binding) - Mickael Maison (binding) - Yash Mayya (binding) The target release for

Re: Requesting permission to contribute to Apache Kafka

2023-11-02 Thread Yash Mayya
Hi Vedarth, I've granted you the necessary permissions. Thanks for your interest in contributing to Apache Kafka! Cheers, Yash On Thu, Nov 2, 2023 at 1:22 PM Vedarth Sharma wrote: > Hi, > > Please grant me permission to contribute to KIPs and assign jira tickets to > myself. > > wiki id and ji

Re: Requesting permission to contribute to Apache Kafka.

2023-11-07 Thread Yash Mayya
Hi Afshin, I've granted you the necessary permissions. Thanks for your interest in contributing to Apache Kafka! Cheers, Yash On Tue, Nov 7, 2023 at 3:52 PM Afshin Moazami wrote: > Hi, > I would like to request permission to contribute to Apache Kafka. > wiki ID: amoazami > Jira ID: afshing >

Re: [DISCUSS] KIP-1004: Enforce tasks.max property in Kafka Connect

2023-11-22 Thread Yash Mayya
Hi Chris, Thanks for the well written and comprehensive KIP! Given that we're already past the KIP freeze deadline for 3.7.0 ( https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.7.0) and there may not be a 3.8.0 release before the 4.0.0 release, would we then be forced to punt the re

Re: Permission to contribute to Apache Kafka

2024-05-22 Thread Yash Mayya
Hi Frédérik, I've granted you the necessary permissions. Let me know if something doesn't work as expected. Cheers, Yash On Wed, May 22, 2024 at 1:38 PM Frédérik Rouleau wrote: > Hi, > As I now have my wiki Id: frouleau and my Jira Id: fred-ro, can I have the > permission to contribute to KIP

Re: [VOTE] KIP-1040: Improve handling of nullable values in InsertField, ExtractField, and other transformations

2024-06-11 Thread Yash Mayya
Thanks for the KIP! +1 (binding) On Tue, Jun 11, 2024 at 7:40 PM Mario Fiore Vitale wrote: > Hi all, > > Just wanted to bump up this thread for visibility. > > Thanks! > > On Wed, May 29, 2024 at 5:31 PM Mickael Maison > wrote: > > > Hi Mario, > > > > +1 (binding) > > Thanks for the KIP! > > >

Re: Requesting permission to contribute to Apache Kafka

2023-12-14 Thread Yash Mayya
Hi Roman, I've granted the required permissions to your accounts. Cheers, Yash On Fri, Dec 15, 2023 at 12:12 PM Роман Бондарь wrote: > Hi all, > > Please add me as a contributor to kafka project > > JIRA username: rbond > Wiki username: rbond > GitHub username: gitrbond > > Thank you, > Roman

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

2023-12-28 Thread Yash Mayya
Congratulations Divij! On Wed, Dec 27, 2023 at 5:15 PM Luke Chen wrote: > Hi, Everyone, > > Divij has been a Kafka committer since June, 2023. He has remained very > active and instructive in the community since becoming a committer. It's my > pleasure to announce that Divij is now a member of K

Re: [VOTE] KIP-1004: Enforce tasks.max property in Kafka Connect

2024-01-03 Thread Yash Mayya
Hi Chris, +1 (binding), thanks for the KIP. Based on discussion in other threads, it looks like the community is aligned with having a 3.8 release before the 4.0 release so we should be able to remove the 'tasks.max.enforce' connector property in 4.0 (we'd discussed potentially having to live wit

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

2024-01-17 Thread Yash Mayya
Hi Ashwin, Thanks for the KIP. > If Connect runtime encounters an error in any of these steps, > it will cleanup (if required) and return an error response Could you please elaborate on the cleanup steps? For instance, if we encounter an error after wiping existing offsets but before writing the

Re: [VOTE] KIP-910: Update Source offsets for Source Connectors without producing records

2024-01-30 Thread Yash Mayya
Hi Sagar, Thanks for the KIP and apologies for the extremely long delay here! I think we could do with some wordsmithing on the Javadoc for the new `SourceTask::updateOffsets` method but that can be taken care of in the PR. +1 (binding) Thanks, Yash On Wed, Nov 15, 2023 at 11:43 PM Sagar wrote

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

2024-03-05 Thread Yash Mayya
ctor implements alterOffsets or not. This also means > that > > if initial_offsets is set in the ConnectorCreate request, we will return > a > > new REST entity (ConnectorInfoWithInitialOffsetsResponse ?) which will > be a > > child class of ConnectorInfo. > > > > (

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-26 Thread Yash Mayya
Congratulations Christo! On Tue, Mar 26, 2024 at 5:34 PM Luke Chen wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer: > Christo Lolov. > > Christo has been a Kafka contributor since 2021. He has made over 50 > commits. He authored KIP-902, KIP-963, a

Re: Permission to assign tickets in Jira

2024-03-27 Thread Yash Mayya
Hi Pavel, I've granted you the necessary permissions. Thanks for your interest in contributing to the Apache Kafka project! Cheers, Yash On Tue, Mar 26, 2024 at 11:32 PM Pavel Pozdeev wrote: > > Hi Team, > > Would it be possible to get a permission to assign tickets in Jira? > I've got a Jira

Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-04-12 Thread Yash Mayya
Hi Ivan, Thanks for reviving this KIP, I think it will be a useful addition to Connect! +1 (binding) Cheers, Yash On Tue, Apr 9, 2024 at 4:23 AM Knowles Atchison Jr wrote: > +1 (non binding) > > On Mon, Apr 8, 2024, 3:30 PM Chris Egerton > wrote: > > > Thanks Ivan! +1 (binding) from me. > >

Re: [ANNOUNCE] New Kafka PMC Member: Greg Harris

2024-04-13 Thread Yash Mayya
Congrats Greg! On Sun, 14 Apr, 2024, 05:56 Randall Hauch, wrote: > Congratulations, Greg! > > On Sat, Apr 13, 2024 at 6:36 PM Luke Chen wrote: > > > Congrats, Greg! > > > > On Sun, Apr 14, 2024 at 7:05 AM Viktor Somogyi-Vass > > wrote: > > > > > Congrats Greg! :) > > > > > > On Sun, Apr 14, 20

Re: [ANNOUNCE] New committer: Igor Soarez

2024-04-24 Thread Yash Mayya
Congratulations Igor! On Wed, 24 Apr, 2024, 23:36 Colin McCabe, wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer, Igor > Soarez. > > Igor has been a Kafka contributor since 2019. In addition to being a > regular contributor and reviewer, he has made signi

Re: [ANNOUNCE] New committer: Lianet Magrans

2024-08-28 Thread Yash Mayya
Congratulations Lianet! On Wed, Aug 28, 2024 at 9:05 PM David Jacot wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer, > Lianet Magrans. > > Lianet has been a Kafka contributor since June 2023. In addition to > being a regular contributor and reviewer, she

Re: [ANNOUNCE] New Kafka PMC Member: Josep Prat

2024-09-06 Thread Yash Mayya
Congratulations Josep! On Fri, 6 Sept, 2024, 21:55 Chris Egerton, wrote: > Hi all, > > Josep has been a Kafka committer since December 2022. He has remained very > active and instructive in the community since then, and it's my pleasure to > announce that he has accepted our invitation to become

RE: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-08-16 Thread Yash Mayya
Hi Diego, Thanks for writing this KIP. Are you still planning to work on this? If not, I'd be happy to try and take this to completion! Hi Chris, Thanks for your valuable inputs as always! > It looks like this KIP does not take the SinkTask::open and SinkTask::close methods into account > I th

RE: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-08-16 Thread Yash Mayya
Apologies for the poor formatting on the quoted bits in the previous email. On 2021/11/03 22:17:06 Diego Erdody wrote: > Hello, > > I'd like to propose a small KIP to add a new field to SinkRecord in order > to add support for topic-mutating SMTs (e.g. RegexRouter) to asynchronous > Sink Connector

Re: [DISCUSS] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-01 Thread Yash Mayya
Hi Jorge, Thanks for the KIP! I have the same confusion with the e2e-latency metrics as Sagar above. "e2e" would seem to indicate the latency between when the record was written to Kafka and when the record was written to the sink system by the connector - however, as per the KIP it looks like it

RE: Re: Permission to assign Apache Kafka Jiras to myself

2022-09-01 Thread Yash Mayya
Aug 11, 2022 at 3:47 PM Yash Mayya wrote: > > > > Hey folks, > > > > I can't currently assign Apache Kafka Jiras to myself and I just discovered > > that someone needs to add me to the contributors list in order for me to be > > able to do that. Could so

Re: [DISCUSS] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-03 Thread Yash Mayya
> > > > 3.1. Agree. 2.1. could help to clarify this. > > > > > One more thing - I was wondering > > > if there's a particular reason for having a min metric for e2e latency > > but > > > not for convert time? > > > > 3.2. Wa

Re: [DISCUSS] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-07 Thread Yash Mayya
c since "avg" would require recording a value on the > > sensor for each record (whereas we can get a "max" by only recording a > > metric value for the oldest record in each batch). > > 5.4. Recording record-latency per batch may not be as useful as there is no

Re: [DISCUSS] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-08 Thread Yash Mayya
Thanks, I think it makes sense to define these metrics at a DEBUG recording level. On Thu, Sep 8, 2022 at 2:51 PM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > On Thu, 8 Sept 2022 at 05:55, Yash Mayya wrote: > > > Hi Jorge, > > > > Thanks f

[DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-09-08 Thread Yash Mayya
Hi all, I would like to (re)start a new discussion thread on KIP-793 (Kafka Connect) which proposes some additions to the public SinkRecord interface in order to support topic mutating SMTs for sink connectors that do their own offset tracking. Links: KIP: https://cwiki.apache.org/confluence/pag

Re: [VOTE] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-22 Thread Yash Mayya
Hi Jorge, Thanks for the KIP. +1 (non-binding) Thanks, Yash On Mon, Sep 12, 2022 at 4:17 PM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Pressed send to soon. Updating subject. > > On Mon, 12 Sept 2022 at 11:45, Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com> wr

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-09-26 Thread Yash Mayya
o tracking of SMT-modified topic names > or partitions > put(records, Map.of()); > } > > public void put(Collection records, Map TopicPartition> updatedTopicPartitions) { > // real logic here > } > > This seems a lot easier than having to use try-catch logic, yet sti

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-10-03 Thread Yash Mayya
rSinkTask` in your proposed approach) > > > > The connector does have to do some of this bookkeeping in how they track > the topic partition offsets used in the `preCommit`, and the pre-commit > methods use the same `Map > currentOffsets` > data structure I'm suggestin

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-10-10 Thread Yash Mayya
Hi Randall, Thanks a lot for your valuable feedback so far! I've updated the KIP based on our discussion above. Could you please take another look? Thanks, Yash On Tue, Oct 4, 2022 at 12:40 AM Randall Hauch wrote: > On Mon, Oct 3, 2022 at 11:45 AM Yash Mayya wrote: > >

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-16 Thread Yash Mayya
Hi Chris, Thanks a lot for this KIP, I think something like this has been long overdue for Kafka Connect :) Some thoughts and questions that I had - 1. I'm wondering if you could elaborate a little more on the use case for the `DELETE /connectors/{connector}/offsets` API. I think we can all agre

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-16 Thread Yash Mayya
One more tiny thing, the Jira linked in the KIP seems to be a circular link to the KIP itself. Should it link to https://issues.apache.org/jira/browse/KAFKA-4107 instead? On Sun, Oct 16, 2022 at 8:12 PM Yash Mayya wrote: > Hi Chris, > > Thanks a lot for this KIP, I think something like

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-18 Thread Yash Mayya
nce isn't necessary. > It also reduces latency to resume the connector, especially for ones that > have to do a lot of state gathering on initialization to, e.g., read > offsets from an external system. > > 7. There should be no risk of mixed tasks after a downgrade, thanks to

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-11-01 Thread Yash Mayya
d. Furthermore, even with elaborate documentation in place, I'm not sure if it'll be very obvious to most people what the purpose of having these two `put` methods is and how they should be used by sink task implementations. What do you think? Thanks, Yash On Mon, Oct 10, 2022 at 9:33 PM Ya

[DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2022-11-02 Thread Yash Mayya
Hi all, I'd like to start a discussion thread on this small KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-882%3A+Make+Kafka+Connect+REST+API+request+timeouts+configurable It proposes the addition of a new Kafka Connect worker configuration to allow configuring REST API request timeo

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2022-11-02 Thread Yash Mayya
l the REST timeout for requests to the 'PUT > /connectors/{connector}/fence' endpoint, or just that it won't control the > timeout that we use for the call to Admin::fenceProducers? > > Cheers, > > Chris > > On Wed, Nov 2, 2022 at 10:0

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2022-11-04 Thread Yash Mayya
ation on the zombie fencing logic. I think we > might > > want to have some more subtle logic around the interaction between calls > to > > Admin::fenceProducers and a worker-level timeout property if we go that > > route, but we can cross that particular bridge if we get

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2022-11-04 Thread Yash Mayya
ed worker configuration that sets an upper bound for the timeout query parameter. Thanks, Yash On Sat, Nov 5, 2022 at 10:30 AM Yash Mayya wrote: > Hi Chris, > > Thanks again for your feedback. I think a worker configuration for the > upper bound makes sense - I initially thought we c

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-11-05 Thread Yash Mayya
]. > > [1] - > > https://github.com/apache/kafka/blob/9ab140d5419d735baae45aff56ffce7f5622744f/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java > [2] - > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-767%3A+Connect+Latency+Met

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-11-08 Thread Yash Mayya
te them on a running Connect cluster and then use various handles > to know how many times they've been polled, committed records, etc. If > necessary we can tweak those classes or even write our own. But anyways, > once that's all done, the test will be something like "create a con

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-11-12 Thread Yash Mayya
connector's group. We can try to detect this case and provide > a > > > helpful error message to the user explaining why the offset reset > request > > > has failed and some steps they can take to try to resolve things (wait > > for > > > slow task shutdown

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-12-07 Thread Yash Mayya
; > Good question! This is actually a subtle source of asymmetry in > the > > > > > current > > > > > > proposal. Requests to delete a consumer group with active members > > will > > > > > > fail, so if there are zombie sink tasks tha

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-12-16 Thread Yash Mayya
adopt it because it's not strictly > necessary to address the cases that we want to cover; everything can be > handled with a single method that gets invoked on offset alter/reset > requests. With exactly-once support, we added this hook because it was > designed to be invoked in a

Re: [ANNOUNCE] New Kafka PMC Member: Luke Chen

2022-12-16 Thread Yash Mayya
Congratulations Luke! On Sat, Dec 17, 2022, 01:11 Jun Rao wrote: > Hi, Everyone, > > Luke Chen has been a Kafka committer since Feb. 9, 2022. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that Luke is now a member of Kafka PMC. > > C

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2022-12-19 Thread Yash Mayya
Hi Mickael, Thanks for creating this KIP, this will be a super useful feature to enhance existing connectors in the Kafka Connect ecosystem. I have some similar concerns to the ones that Chris has outlined above, especially with regard to directly exposing Connect's Metrics object to plugins. I b

Re: [ANNOUNCE] New committer: Josep Prat

2022-12-21 Thread Yash Mayya
Congratulations Josep! On Tue, Dec 20, 2022, 22:56 Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer Josep > Prat. > > Josep has been contributing to Kafka since May 2021. He contributed 20 PRs > including the following 2 KIPs. > > KIP-773 D

Re: [VOTE] 3.3.2 RC1

2022-12-21 Thread Yash Mayya
Hi Chris, I did the following release validations - - Verified the MD5 / SHA-1 / SHA-512 checksums and the PGP signatures - Built from source using Java 8 and Scala 2.13 - Ran all the unit tests successfully - Ran all the integration tests successfully (couple of flaky failures that passed on a r

Re: [ANNOUNCE] New committer: Satish Duggana

2022-12-24 Thread Yash Mayya
Congratulations Satish! On Fri, Dec 23, 2022, 23:38 Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer Satish > Duggana. > > Satish has been a long time Kafka contributor since 2017. He is the main > driver behind KIP-405 that integrates Kafka

Re: [ANNOUNCE] New committer: Justine Olshan

2022-12-29 Thread Yash Mayya
Congratulations Justine! On Fri, Dec 30, 2022, 02:28 David Jacot wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Justine > Olshan. > > Justine has been contributing to Kafka since June 2019. She contributed 53 > PRs including the following KIPs. > > KI

Re: [ANNOUNCE] New committer: Stanislav Kozlovski

2023-01-17 Thread Yash Mayya
Congratulations, Stan! On Tue, Jan 17, 2023 at 9:20 PM Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Stanislav Kozlovski. > > Stan has been contributing to Apache Kafka since June 2018. He made various > contributions including the foll

Re: [ANNOUNCE] New committer: Walker Carlson

2023-01-17 Thread Yash Mayya
Congrats, Walker! On Wed, Jan 18, 2023 at 3:27 AM Matthias J. Sax wrote: > Dear community, > > I am pleased to announce Walker Carlson as a new Kafka committer. > > Walker has been contributing to Apache Kafka since November 2019. He > made various contributions including the following KIPs. > >

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2023-01-24 Thread Yash Mayya
e Metrics object). I'll try to build > > a list of all plugin types and add that to the KIP. > > > > Thanks, > > Mickael > > > > > > > > On Tue, Dec 27, 2022 at 4:54 PM Chris Egerton > wrote: > > > > > > Hi Yash, > >

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-24 Thread Yash Mayya
Hi Chris, I'm +1 (non-binding). Thanks again for proposing this extremely valuable addition to Kafka Connect! Thanks, Yash On Thu, Jan 19, 2023 at 12:11 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-875, which adds support for viewing and > manipulating the offsets o

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2023-02-03 Thread Yash Mayya
ample. > > > > > > Thanks, > > > Mickael > > > > > > > > > On Thu, Jan 26, 2023 at 3:54 PM Mickael Maison < > mickael.mai...@gmail.com> > > wrote: > > > > > > > > Hi Chris, > > > > > > > &

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-09 Thread Yash Mayya
ient. > > [1] - > > https://kafka.apache.org/33/javadoc/org/apache/kafka/connect/sink/SinkTask.html#open(java.util.Collection) > [2] - > > https://kafka.apache.org/33/javadoc/org/apache/kafka/connect/sink/SinkTask.html#close(java.util.Collection) > > Cheers, > > Chris &

Permission to assign Apache Kafka Jiras to myself

2022-08-11 Thread Yash Mayya
Hey folks, I can't currently assign Apache Kafka Jiras to myself and I just discovered that someone needs to add me to the contributors list in order for me to be able to do that. Could someone please do that for me? Here are my Jira account details: Username: yash.mayya Email: yash.ma...@gmail.c

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-13 Thread Yash Mayya
ic partitions. I'm hoping that this logic can stay internal, and by not > painting ourselves into a corner with the KIP, we give ourselves leeway to > tweak it in the future if necessary without filing another KIP or > introducing a pluggable interface. > > Cheers, > > Chr

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-14 Thread Yash Mayya
ssary calls to close/open over a given sink > task's lifetime), but should not lead to guaranteed resource leaks or > failure to obey API contract in any cases. > > Cheers, > > Chris > > On Mon, Feb 13, 2023 at 10:54 AM Yash Mayya wrote: > > > Hi Chris, > >

Re: [ANNOUNCE] New committer: Lucas Bradstreet

2023-02-16 Thread Yash Mayya
Congratulations Lucas! On Fri, Feb 17, 2023 at 3:25 AM Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer Lucas > Bradstreet. > > Lucas has been a long time Kafka contributor since Oct. 2018. He has been > extremely valuable for Kafka on both

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-18 Thread Yash Mayya
proposal, and we can both take > a look and make sure everything looks good enough before opening a vote > thread. > > Finally, I think you make a convincing case for a time-based eviction > policy. I wasn't thinking about the fairly common SMT pattern of deriving a >

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-21 Thread Yash Mayya
f a task class has not overridden the > multi-arg variant. But I think this is going a bit too far and would prefer > to keep things simple(r) for now. > > Cheers, > > Chris > > > On Sun, Feb 19, 2023 at 2:34 AM Yash Mayya wrote: > > > Hi Chris, &g

[VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-01 Thread Yash Mayya
Hi all, I'd like to call for a vote on the (hopefully) straightforward KIP-882 which adds support for configuring request timeouts on Kafka Connect REST APIs via query parameters along with a couple of related small improvements. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-882%3A+

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-01 Thread Yash Mayya
//lists.apache.org/thread/mgx8lczx2f57pk7x3vh0nqk00s79grgp. Thanks, Yash On Sat, Nov 5, 2022 at 11:42 PM Sagar wrote: > Hey Yash, > > Thanks for the explanation. I think it should be fine to delegate the > validation directly to the leader. > > Thanks! > Sagar. > > On Sat, Nov 5, 2022 at 10:42

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-02 Thread Yash Mayya
nderstand if you want to keep this KIP as tightly focused as possible, > but i'm worried that it is addressing the symptom and not the problem. I > want to make sure that this change is impactful and isn't obsoleted by a > later improvement. > > Thanks, > Greg > >

Re: [VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-02 Thread Yash Mayya
x27;, '10s' or '500ms'. > Is it too late to incorporate this change? > > Thanks, > Ashwin > > > On Wed, Mar 1, 2023 at 6:32 PM Yash Mayya wrote: > > > Hi all, > > > > I'd like to call for a vote on the (hopefully) straightforward K

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-08 Thread Yash Mayya
re the only ones with a > synchronicity constraint. > Again, I'm not necessarily saying that you must implement such an > asynchronous validation scheme in this KIP, but we should consider if that > is a more extensible solution. If we decided to implement configurable > synchron

Re: [ANNOUNCE] New Kafka PMC Member: David Arthur

2023-03-09 Thread Yash Mayya
Congrats David! On Thu, Mar 9, 2023, 23:42 Jun Rao wrote: > Hi, Everyone, > > David Arthur has been a Kafka committer since 2013. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that David is now a member of Kafka PMC. > > Congratulatio

Re: [ANNOUNCE] New Kafka PMC Member: Chris Egerton

2023-03-09 Thread Yash Mayya
Congratulations Chris! On Thu, Mar 9, 2023, 23:42 Jun Rao wrote: > Hi, Everyone, > > Chris Egerton has been a Kafka committer since July 2022. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that Chris is now a member of Kafka PMC. > >

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-03-12 Thread Yash Mayya
unctions and keep everything else backwards > compatible. After deriving all of the above, I think that's a reasonable > tradeoff to make. > > Thanks, > Greg > > On Tue, Feb 21, 2023 at 10:17 AM Chris Egerton > wrote: > > > Hi Yash, > > > > We'

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-19 Thread Yash Mayya
> and other operations later). > But as it stands, I don't think I see the value-add of configurable > timeouts once there is another solution which targets the validate call > duration specifically, and I'm concerned that configurable timeouts would > be made irrelev

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Yash Mayya
DISCUSS >> thread. >> > >> >> > >> +1 (binding). >> > >> >> > >> Best, >> > >> >> > >> On Wed, Mar 1, 2023 at 12:16 PM Tom Bentley >> > wrote: >> > >> >> > >> &g

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Yash Mayya
tentially just > fire-and-forget the request and, if new tasks are started for the connector > in the meantime, trust that the request will get automatically fenced out > without doing any more work). > > Cheers, > > Chris > > On Wed, Apr 12, 2023 at 1:01 PM Yash Mayya wrot

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-04-23 Thread Yash Mayya
> without doing a lot of book-keeping. > > I suppose there is a possible implementation of metadata book-keeping which > provides a reasonable system of virtual coordinates, it just ended up > equivalent to hydrating intermediate topics to compute a consistent record > orderin

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-04-24 Thread Yash Mayya
Hi Sagar, Thanks for the KIP! I have a few questions and comments: 1) I agree with Chris' point about the separation of a connector heartbeat mechanism and allowing source connectors to generate offsets without producing data. What is the purpose of the heartbeat topic here and are there any conc

Re: [ANNOUNCE] New PMC chair: Mickael Maison

2023-04-24 Thread Yash Mayya
Congratulations Mickael! On Fri, Apr 21, 2023 at 8:39 PM Jun Rao wrote: > Hi, everyone, > > After more than 10 years, I am stepping down as the PMC chair of Apache > Kafka. We now have a new chair Mickael Maison, who has been a PMC member > since 2020. I plan to continue to contribute to Apache

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-05-12 Thread Yash Mayya
to git shortlog). Congratulations to our new collaborators! > > Victoria Xia, Greg Harris, Divij Vaidya, Lucas Brutschy, Yash Mayya, > Philip Nee, vamossagar12,, Christo Lolov, Federico Valeri, andymg3, > RivenSun, Kirk True, Matthew de Detrich, Akhilesh C, Alyssa Huang, Artem > Liv

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-05-24 Thread Yash Mayya
to asf.yaml, I received a > > notification that the list is limited to only 10 people, not 20 as the > > documentation states. > > > > Here is the list of folks who will now be able to triage PRs and trigger > > builds: Victoria Xia, Greg Harris, Divij Vaidya, Lu

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-05-24 Thread Yash Mayya
gt; > > > > > > > Just a quick update: after merging the changes to asf.yaml, I > received > > a > > > > notification that the list is limited to only 10 people, not 20 as > the > > > > documentation states. > > > > > > > >

  1   2   >