Hi Ashwin, Thanks for the feedback. I intentionally went with the choice of an unambiguous milliseconds unit and this would be clearly documented in the public Kafka Connect documentation. I think supporting multiple time units might lead to unnecessary confusion (what happens when no unit is specified; what if an alternate short form for a time unit is used etc.). Furthermore, the worker configuration for max request timeout will also only accept millisecond values so this will be consistent across both the places.
However, it's definitely not too late to incorporate the change and I'd be happy to do so if there are others from the community who share the same opinion! Thanks, Yash On Thu, Mar 2, 2023 at 12:18 PM Ashwin <apan...@confluent.io.invalid> wrote: > Thanks for the KIP Yash - +1 (non-binding) > > One nitpick - > In one of the responses Chris had mentioned that the timeout param could be > like 'timeout=10s'. > The KIP seems to favour a millisecond timeout value and has an unwieldy > value in the example - `POST /connectors?timeout=120000` > > I like the idea of having smaller timeout values and the unit as part of > the value eg: '2m', '10s' or '500ms'. > Is it too late to incorporate this change? > > Thanks, > Ashwin > > > On Wed, Mar 1, 2023 at 6:32 PM Yash Mayya <yash.ma...@gmail.com> wrote: > > > Hi all, > > > > I'd like to call for a vote on the (hopefully) straightforward KIP-882 > > which adds support for configuring request timeouts on Kafka Connect REST > > APIs via query parameters along with a couple of related small > > improvements. > > > > KIP - > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-882%3A+Kafka+Connect+REST+API+timeout+improvements > > > > Discussion thread - > > https://lists.apache.org/thread/cygy115qmwpc3nj5omnj0crws2dw8nor > > > > Thanks, > > Yash > > >
