Hi Sagar, Thanks for the KIP and apologies for the extremely long delay here! I think we could do with some wordsmithing on the Javadoc for the new `SourceTask::updateOffsets` method but that can be taken care of in the PR.
+1 (binding) Thanks, Yash On Wed, Nov 15, 2023 at 11:43 PM Sagar <sagarmeansoc...@gmail.com> wrote: > Hey all, > > Bumping this vote thread again after quite a while. > > Thanks! > Sagar. > > On Wed, Sep 6, 2023 at 3:58 PM Sagar <sagarmeansoc...@gmail.com> wrote: > > > Hi All, > > > > Based on the latest discussion thread, it appears as if all open > questions > > have been answered. > > > > Hopefully now we are in a state where we can close out on the Voting > > process. > > > > Thanks everyone for the great feedback. > > > > Thanks! > > Sagar. > > > > On Fri, Aug 18, 2023 at 9:00 AM Sagar <sagarmeansoc...@gmail.com> wrote: > > > >> Hi All, > >> > >> Bumping the voting thread again. > >> > >> Thanks! > >> Sagar. > >> > >> On Wed, Aug 2, 2023 at 4:43 PM Sagar <sagarmeansoc...@gmail.com> wrote: > >> > >>> Attaching the KIP link for reference: > >>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-910%3A+Update+Source+offsets+for+Source+Connectors+without+producing+records > >>> > >>> Thanks! > >>> Sagar. > >>> > >>> On Wed, Aug 2, 2023 at 4:37 PM Sagar <sagarmeansoc...@gmail.com> > wrote: > >>> > >>>> Hi All, > >>>> > >>>> Calling a Vote on KIP-910 [1]. I feel we have converged to a > reasonable > >>>> design. Ofcourse I am open to any feedback/suggestions and would > address > >>>> them. > >>>> > >>>> Thanks! > >>>> Sagar. > >>>> > >>> >
