Review Request 33334: Patch for KAFKA-2131

/producer/ProducerConfig.java ca1c7fedbde7f53d64426da3a1aa3aeeafd2e9ad Diff: https://reviews.apache.org/r/4/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30801: Patch for KAFKA-1758

/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30801: Patch for KAFKA-1758

ptions also. updated the log message. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/#review81622 -------

Re: Review Request 24214: Patch for KAFKA-1374

data produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review83392 --- On May 18, 2015, 5:29 p.m., Manikumar Reddy O wrote: > > -

Review Request 34403: Patch for KAFKA-2198

--- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

://reviews.apache.org/r/34403/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

://reviews.apache.org/r/34403/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 34641: Patch for KAFKA-2214

/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

der in-progress as "errors". Other option could be returning a different error code. Let us wait for others suggestions/concerns. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: ht

Re: Review Request 33049: Patch for KAFKA-2084

tps://reviews.apache.org/r/33049/#comment137140> Are we using clientID as uniqueKey?. But as of now, clientID is not mandatory and it need not be unique acorss different producer and consumers. - Manikumar Reddy O On May 26, 2015, 6:53 p.m., Aditya Auradkar

Review Request 34805: Patch for KAFKA-2213

c9ade7208798fbd92d4ff49e183fe5f8925c82a9 core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 471ddff9bff1bdfa277c071e59e5c6b749b9c74f Diff: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34805: Patch for KAFKA-2213

/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9 core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 471ddff9bff1bdfa277c071e59e5c6b749b9c74f Diff: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

clients/src/main/java/org/apache/kafka/common/MetricName.java 4e810d56b753b7eeb662b99af5cdf36bcfba7ea7 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Review Request 30022: Patch for KAFKA-1761

: https://reviews.apache.org/r/30022/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30022: Patch for KAFKA-1761

88689df718364f5a9bef143d4cb7e807a9251786 Diff: https://reviews.apache.org/r/30022/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 30073: Patch for KAFKA-1109

--- Thanks, Manikumar Reddy O

Review Request 30128: Patch for KAFKA-1861

/browse/KAFKA-1861 Repository: kafka Description --- include clients test jar in maven artifacts Diffs - build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28 Diff: https://reviews.apache.org/r/30128/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69532 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 24, 2015, 5:13

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69533 --- Ship it! Non-Binding +1 - Manikumar Reddy O On Jan. 24, 2015, 5

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69534 --- Can you update the README.md document - Manikumar Reddy O On Jan

Re: Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69813 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 27, 2015, 4:16

Review Request 30801: Patch for KAFKA-1758

/ Testing --- Thanks, Manikumar Reddy O

Review Request 31627: Patch for KAFKA-1884

--- Thanks, Manikumar Reddy O

Review Request 35418: Patch for KAFKA-2264

b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb Diff: https://reviews.apache.org/r/35418/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35419: Patch for KAFKA-2262

Reddy O

Review Request 35421: Patch for KAFKA-2026

/ Testing --- Thanks, Manikumar Reddy O

Review Request 35424: Patch for KAFKA-2234

912b718ec9ad58b1c2d42337ed85bbb1b88162d6 Diff: https://reviews.apache.org/r/35424/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35437: Patch for KAFKA-2202

903318d15893af08104a97499798c9ad0ba98013 Diff: https://reviews.apache.org/r/35437/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35454: Patch for KAFKA-2159

2d75186a110075e0c322db4b9f7a8c964a7a3e88 core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35503: Patch for KAFKA-2012

8e095d652851f05365e1d3bbe3e9e1c3345b7a40 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35454: Patch for KAFKA-2159

scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 core/src/main/scala/kafka/server/OffsetManager.scala 5cca85cf727975f6d3acb2223fd186753ad761dc Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34805: Patch for KAFKA-2213

bd92d4ff49e183fe5f8925c82a9 > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 471ddff9bff1bdfa277c071e59e5c6b749b9c74f > > Diff: https://reviews.apache.org/r/34805/diff/ > > > Testing > --- > > > Thanks, > > Manikumar Reddy O > >

Re: Review Request 34805: Patch for KAFKA-2213

Diff: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35610: Patch for KAFKA-2265

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35503: Patch for KAFKA-2012

scala a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35503: Patch for KAFKA-2012

NewFile()). So we no need to re-create the LogSegment. Pl check. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 ----------

Re: Review Request 35503: Patch for KAFKA-2012

scala a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 35867: Patch for KAFKA-1901

/MetricsTest.java 544e120594de78c43581a980b1e4087b4fb98ccb core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89364 --- On June 25, 2015, 10:11 a.m., Manikumar Reddy O wrote: > > --- >

Review Request 35880: Patch for KAFKA-2295

168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

to easily add a "tainted" boolean field? i.e., if there are any > > additional source files that are untracked or staged but not committed? It should be posible with some git commands. But do we really need this? most of us will be running stable release or some tru

Re: Review Request 35867: Patch for KAFKA-1901

98ccb core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 52dc728bb1ab4b05e94dc528da1006040e2f28c9 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90305 ------- On June 25, 2015, 4:25 p.m., Manikumar Reddy O wrote: > >

Re: Review Request 35880: Patch for KAFKA-2295

.java db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90488 --- On July 6, 2015, 6:05 a.m., Manikumar Reddy O wrote: > > ---

Re: Review Request 35867: Patch for KAFKA-1901

/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 18917bc4464b9403b16d85d20c3fd4c24893d1d3 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34805: Patch for KAFKA-2213

://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34805: Patch for KAFKA-2213

Reddy O On July 10, 2015, 2:50 p.m., Manikumar Reddy O wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 35454: Patch for KAFKA-2159

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

--- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

34403/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

?lq=1 log.error() used for printing stackTrace. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91310 ----------

Re: Review Request 34403: Patch for KAFKA-2198

/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34403: Patch for KAFKA-2198

hen the catch block > > includes the System.exit(1). > > > > Also, I'm afraid that printing the entire stack trace is intimidating > > to non-developers who use the CLI. Perhaps the stack trace should go under > > log.error(...)? > > Manikumar Red

Re: Review Request 34641: Patch for KAFKA-2214

https://reviews.apache.org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

d". However, this is arguably more error prone because > > the log messages can change between Kafka versions (and oftentimes such > > changes are not prominently advertised, so you only notice this once your > > deployment script breaks). > > Manikumar Reddy O wrote

Re: Review Request 34641: Patch for KAFKA-2214

org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

> brokers/clients are running the same version or not. Implemented a simple finger print (commitId.hashcode()) mechanism. I felt commit.hashCode() should be sufficient for our requirement. - Manikumar Reddy --- This is an automatically gener

Re: Review Request 34641: Patch for KAFKA-2214

https://reviews.apache.org/r/34641/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 34641: Patch for KAFKA-2214

view92403 --- On Aug. 5, 2015, 3:19 p.m., Manikumar Reddy O wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 34641: Patch for KAFKA-2214

d status is given more preference than in-progress error status. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92024 -------

Re: Review Request 35867: Patch for KAFKA-1901

hanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

to explicitly register the app info in the consumer/producer/broker. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92078 ------

Re: Review Request 35867: Patch for KAFKA-1901

To reply, visit: https://reviews.apache.org/r/35867/#review92404 ------- On Aug. 9, 2015, 9:37 a.m., Manikumar Reddy O wrote: > > --- > This is an automaticall

Re: Review Request 35867: Patch for KAFKA-1901

/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35867: Patch for KAFKA-1901

ached mode. thanks for the review. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review95902 --- On Aug. 20, 2

Re: Review Request 36578: Patch for KAFKA-2338

) <https://reviews.apache.org/r/36578/#comment151144> The warning message can be : "WARNING: %s has been increased beyond the default max value of %d, update producer and consumer settings as well" Also do want to include patch for second point given in JIRA decription.. - Maniku

Re: Review Request 36578: Patch for KAFKA-2338

On Aug. 20, 2015, 11:07 a.m., Edward Ribeiro wrote: > > Also do want to include patch for second point given in JIRA decription.. just read previous reviews..ignore my comment. - Manikumar Reddy --- This is an automatically generated e-

Re: Review Request 34805: Patch for KAFKA-2213

://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23362: Patch for KAFKA-1325

.scala 5746ad4767589594f904aa085131dd95e56d72bb core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400 Diff: https://reviews.apache.org/r/23362/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23363: Patch for KAFKA-1325

6f4809da9968de293f365307ffd9cfe1d5c34ce0 Diff: https://reviews.apache.org/r/23363/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23396: Patch for KAFKA-1531

/23396/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23417: Patch for KAFKA-1531

: https://reviews.apache.org/r/23417/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23439: Patch for KAFKA-1258

/23439/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23440: Patch for KAFKA-1536

/browse/KAFKA-1536 Repository: kafka Description --- JIRA status set to Patch Available in kafka-patch-review script Diffs - kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef Diff: https://reviews.apache.org/r/23440/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23440: Patch for KAFKA-1536; addressing reviewer comments

dc45549f886440f1721c60aab9aa0a4af9b4cbef Diff: https://reviews.apache.org/r/23440/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23440: addressing reviewer comments

dc45549f886440f1721c60aab9aa0a4af9b4cbef Diff: https://reviews.apache.org/r/23440/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23705: Patch for KAFKA-1192

--- Thanks, Manikumar Reddy O

Re: Review Request 23705: Patch for KAFKA-1192

://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23705: Addressing Jun's comments

tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f Diff: https://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23705: Addressing Jun's comments

eviews.apache.org/r/23705/#review48265 --- On July 21, 2014, 3:16 p.m., Manikumar Reddy O wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 23705: Addressing Jun's comments

://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23705: Addressing Jun's comments

> On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 > > <https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165> > > > > Would key also be null possibly? > > Mani

Review Request 23858: Patch for KAFKA-1544

/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23858: Patch for KAFKA-1544

2faa196a4dc612bc634d5ff5f5f275d09073f13b Diff: https://reviews.apache.org/r/23858/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23858: Patch for KAFKA-1544

hread to decrease LogCleaner shutdown time > during shutdown > > > Diffs > - > > core/src/main/scala/kafka/log/LogCleaner.scala > 2faa196a4dc612bc634d5ff5f5f275d09073f13b > > Diff: https://reviews.apache.org/r/23858/diff/ > > > Testing > --- > > > Thanks, > > Manikumar Reddy O > >

Review Request 23962: Patch for KAFKA-1451

/23962/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23962: Patch for KAFKA-1451

org/r/23962/diff/ Testing --- Thanks, Manikumar Reddy O

Review Request 23983: Patch for KAFKA-1451

/23983/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23962: Patch for KAFKA-1451

org/r/23962/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23962: Patch for KAFKA-1451

23962/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 23962: Patch for KAFKA-1451

reply, visit: https://reviews.apache.org/r/23962/#review48965 ------- On July 29, 2014, 4:45 a.m., Manikumar Reddy O wrote: > > --- > This is an automatically g

  1   2   >