> On April 26, 2015, 6:53 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/LogManager.scala, line 133 > > <https://reviews.apache.org/r/30801/diff/1/?file=858786#file858786line133> > > > > Is there a reason we are limiting this to only NumberFormatException? > > Seems like a fix that applies to all errors. > > > > Also, worth changing the error message to a more generic statement > > about the problem and the fix (resetting the recovery checkpoint to 0).
Yes, we can catch other exceptions also. updated the log message. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/#review81622 ----------------------------------------------------------- On May 9, 2015, 7:02 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30801/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 7:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1758 > https://issues.apache.org/jira/browse/KAFKA-1758 > > > Repository: kafka > > > Description > ------- > > Addressing Neha's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogManager.scala > e781ebac2677ebb22e0c1fef0cf7e5ad57c74ea4 > > Diff: https://reviews.apache.org/r/30801/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
